refactor service skills (#260 tier-3) #264

Merged

timur merged 1 commit from pr-260-new-skills into development

2026-05-19 13:39:37 +00:00

timur commented

2026-05-19 13:39:36 +00:00

Owner

Closes the second half of #260 (the first half — cleanup pass on existing service skills — landed in 0634d4d).

Three new skills under skills/hero/service/:

hero_service_scaffold.md — end-to-end flow via WorkspaceScaffolder + hero_rpc_generator CLI, generated 5-crate layout, post-scaffold validation, explicit known-gaps section.
hero_service_check.md — lean read-only audit (split from _check_fix), one-command lab infocheck, finding→fix pointer table.
hero_service_refactor.md — 10-step legacy-migration plan driving the lab infocheck fix-loop, with explicit acceptance criteria.

Source-of-truth basis: inspected the scaffolder after #55 + #54 landed; skills describe what's emitted today. Pure markdown + .toml sidecar (no YAML frontmatter), cross-links by skill name.

Closes the second half of #260 (the first half — cleanup pass on existing service skills — landed in `0634d4d`). Three new skills under `skills/hero/service/`: - `hero_service_scaffold.md` — end-to-end flow via `WorkspaceScaffolder` + `hero_rpc_generator` CLI, generated 5-crate layout, post-scaffold validation, explicit known-gaps section. - `hero_service_check.md` — lean read-only audit (split from `_check_fix`), one-command `lab infocheck`, finding→fix pointer table. - `hero_service_refactor.md` — 10-step legacy-migration plan driving the `lab infocheck` fix-loop, with explicit acceptance criteria. Source-of-truth basis: inspected the scaffolder after #55 + #54 landed; skills describe what's emitted today. Pure markdown + `.toml` sidecar (no YAML frontmatter), cross-links by skill name.

timur added 1 commit

2026-05-19 13:39:36 +00:00

hero/service skills: add scaffold / check / refactor skills (#260 tier-3)

Build and Test (lab workspace) / build-and-test (pull_request) Failing after 3s

Details

3b04435ddc

Three new skills under `skills/hero/service/` that close out the tier-3
deliverables on hero_skills#260. Tier-1 (audit of existing skills) landed
in 2a05555; tier-3 was blocked on hero_rpc#54 + #55, which now have
§1-§6 of #55 landed on the `issue-55-codegen-alignment` branch
(WorkspaceScaffolder emits `_admin` against hero_admin_lib, §5 main.rs
boilerplate, `_sdk`/`_admin` naming, per-binary `service.toml`,
hero_lifecycle rename).

- `hero_service_scaffold.md` — end-to-end flow for a new Hero service:
  required user inputs, the WorkspaceScaffolder library API + the
  `hero_rpc_generator` CLI, the generated 5-crate layout, the known
  gaps the scaffolder does NOT yet emit (Makefile/buildenv.sh deletion,
  `_examples` crate, `PURPOSE.md`, `README.md`,
  `.forgejo/workflows/build-linux.yaml`, the hero_rpc2 trait SDK still
  pending), and the post-scaffold validation loop
  (cargo build → lab infocheck → lab service --install/--start).

- `hero_service_check.md` — fast read-only audit. Single command
  (`lab infocheck`); per-dimension spot-checks (naming, service.toml,
  base wiring, socket paths, lab-driven lifecycle, OpenRPC); live
  smoke-test recipe; pointer table from finding → fix recipe in
  hero_service_check_fix.

- `hero_service_refactor.md` — migrating legacy services. Step-by-step
  plan (baseline → rename _ui/_client → fix service.toml → rewrite
  main.rs against herolib_core::base → swap admin to hero_admin_lib →
  stage the SDK toward the hero_rpc2 trait emitter → drop Makefile /
  scripts / .nu → regenerate PURPOSE.md/README.md → add _examples →
  add release CI). Drives the lab infocheck fix-loop and lists explicit
  acceptance criteria.

All three follow the existing `hero/service/` format: pure markdown
body + .toml sidecar (description, technology, links, tags, purposes),
no YAML frontmatter. Cross-link via `[skill_name](skill_name)` so
agents follow the wiring rules from hero_service_toml_info,
herolib_base, hero_sockets, etc. without duplication.

Reference services per parent META lhumina_code/hero_skills#262: model
on hero_proc (wiring + hero_proc_admin) and hero_compute (workspace
layout). hero_inspector is explicitly flagged as NOT a reference.

Refs lhumina_code/hero_skills#260, lhumina_code/hero_skills#262,
lhumina_code/hero_rpc#54, lhumina_code/hero_rpc#55.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>