refactor: rename hero_proc_ui -> hero_proc_admin (ui.sock -> admin.sock) #98

Closed

mik-tf wants to merge 1 commit from development_mik_proc_admin_rename into development

mik-tf commented

2026-05-07 20:46:44 +00:00

Owner

Aligns the hero_proc producer with the workspace _admin convention codified by hero_router/src/service_manager/services/*.rs (the SSOT) and the hero_service_test skill. hero_skills/service_proc.nu already expects hero_proc_admin in SP_BINARIES (line 43); this PR fixes the producer/consumer mismatch so service_proc start --download works end-to-end again.

Mirrors hero_db PR #29 (5c9a14e). Priority-1 producer under lhumina_code/home#228 .

Changes

crates/hero_proc_ui/ → crates/hero_proc_admin/
crates/hero_proc_lib_ui/ → crates/hero_proc_lib_admin/
package + bin name + clap command name → hero_proc_admin
socket path ui.sock → admin.sock (preserves hero_router/ui.sock refs since hero_router migration is its own producer arc)
env var HERO_PROC_UI_BASE_PATH → HERO_PROC_ADMIN_BASE_PATH
workspace Cargo.toml members + dep paths
buildenv.sh BINARIES
Makefile UI_SOCKET path
scripts/build_lib.sh socket + screen-session names
README.md, internal docs (paths.md, overview.md, etc.)
testcases/*.md (24 files) and tests/scripts/05_rename_verification.sh
.claude/skills/run_ui_tests/SKILL.md

Bundled mechanical debt (s65/s68/s70 playbook item 22)

cargo fmt --all (pre-existing trailing-whitespace in secrets.rs)
clippy fix: empty_line_after_doc_comments in crates/hero_proc_sdk/src/secrets.rs:29

Workspace-build gate (per `feedback_workspace_build_before_merge.md`)

cargo fmt --check
cargo clippy --workspace --all-targets -- -D warnings
cargo build --workspace --release

Reference: lhumina_code/hero_db#29

Signed-off-by: mik-tf

Aligns the hero_proc producer with the workspace `_admin` convention codified by `hero_router/src/service_manager/services/*.rs` (the SSOT) and the `hero_service_test` skill. `hero_skills/service_proc.nu` already expects `hero_proc_admin` in `SP_BINARIES` (line 43); this PR fixes the producer/consumer mismatch so `service_proc start --download` works end-to-end again. Mirrors hero_db PR #29 (5c9a14e). Priority-1 producer under https://forge.ourworld.tf/lhumina_code/home/issues/228 . ## Changes - `crates/hero_proc_ui/` → `crates/hero_proc_admin/` - `crates/hero_proc_lib_ui/` → `crates/hero_proc_lib_admin/` - package + bin name + clap command name → `hero_proc_admin` - socket path `ui.sock` → `admin.sock` (preserves `hero_router/ui.sock` refs since hero_router migration is its own producer arc) - env var `HERO_PROC_UI_BASE_PATH` → `HERO_PROC_ADMIN_BASE_PATH` - workspace `Cargo.toml` members + dep paths - `buildenv.sh BINARIES` - `Makefile UI_SOCKET` path - `scripts/build_lib.sh` socket + screen-session names - `README.md`, internal docs (`paths.md`, `overview.md`, etc.) - `testcases/*.md` (24 files) and `tests/scripts/05_rename_verification.sh` - `.claude/skills/run_ui_tests/SKILL.md` ## Bundled mechanical debt (s65/s68/s70 playbook item 22) - `cargo fmt --all` (pre-existing trailing-whitespace in `secrets.rs`) - clippy fix: `empty_line_after_doc_comments` in `crates/hero_proc_sdk/src/secrets.rs:29` ## Workspace-build gate (per `feedback_workspace_build_before_merge.md`) - [x] `cargo fmt --check` - [x] `cargo clippy --workspace --all-targets -- -D warnings` - [x] `cargo build --workspace --release` Reference: https://forge.ourworld.tf/lhumina_code/hero_db/pulls/29 Signed-off-by: mik-tf

mik-tf added 1 commit

2026-05-07 20:46:44 +00:00

refactor: rename hero_proc_ui -> hero_proc_admin (ui.sock -> admin.sock)

Tests / test (pull_request) Failing after 4m19s

Details

Build and Test / build (pull_request) Failing after 5m9s

Details

2727d2b4e8

Aligns hero_proc producer with the workspace _admin convention codified by
hero_router/src/service_manager/services/*.rs (the SSOT) and the
hero_service_test skill. hero_skills service_proc.nu already expects
hero_proc_admin in SP_BINARIES; this commit fixes the producer/consumer
mismatch so service_proc start --download works end-to-end.

Mirrors hero_db PR #29 (5c9a14e). One repo per session under home#228.

Changes:
- crates/hero_proc_ui/  -> crates/hero_proc_admin/
- crates/hero_proc_lib_ui/ -> crates/hero_proc_lib_admin/
- package + bin name + clap command name -> hero_proc_admin
- socket path ui.sock -> admin.sock (preserves hero_router/ui.sock refs;
  hero_router migration is its own producer arc)
- env var HERO_PROC_UI_BASE_PATH -> HERO_PROC_ADMIN_BASE_PATH
- workspace Cargo.toml members + dep paths
- buildenv.sh BINARIES
- Makefile UI_SOCKET path
- scripts/build_lib.sh socket + screen-session names
- README.md, PURPOSE.md, internal docs (paths.md, overview.md, etc.)
- testcases/*.md (24 files) and tests/scripts/05_rename_verification.sh
- .claude/skills/run_ui_tests/SKILL.md

Bundled mechanical debt (mirrors session 65/68/70 playbook item 22):
- cargo fmt --all (pre-existing trailing-whitespace in secrets.rs)
- clippy fix: empty_line_after_doc_comments in
  crates/hero_proc_sdk/src/secrets.rs:29

Workspace-build gate green:
  cargo fmt --check
  cargo clippy --workspace --all-targets -- -D warnings
  cargo build --workspace --release

References:
- lhumina_code/home#228
- lhumina_code/hero_db#29

Signed-off-by: mik-tf

mik-tf commented

2026-05-08 02:04:52 +00:00

Author

Owner

Superseded by upstream commit 8f28cd4 on development which performed the equivalent hero_proc_ui -> hero_proc_admin / ui.sock -> admin.sock rename plus ae30a57 (bash/make removal). Closing this PR.

Superseded by upstream commit 8f28cd4 on development which performed the equivalent hero_proc_ui -> hero_proc_admin / ui.sock -> admin.sock rename plus ae30a57 (bash/make removal). Closing this PR.