lhumina_code/hero_db
0
0
Fork 0
Code Issues 4 Pull requests Projects Releases 2 Packages 2 Wiki Activity Actions

refactor: rename hero_db_ui → hero_db_admin (web.sock → admin.sock) #29

Merged
mik-tf merged 1 commit from development_mik_db_admin_rename into development 2026-05-07 20:36:54 +00:00
Conversation 0 Commits 1 Files changed 34 +154 -167
mik-tf commented 2026-05-07 19:01:13 +00:00
Owner
Copy link

Summary

Rename hero_db's admin dashboard binary from hero_db_ui → hero_db_admin, and the matching socket from web.sock → admin.sock, to comply with the hero_service_test skill's naming convention table:

  • Admin UI (Askama) = hero_${name}_admin → admin.sock
  • End-user web UI (Askama) = hero_${name}_web → web.sock
  • _ui suffix is the old admin name (explicitly flagged in the skill).

PURPOSE.md and the in-repo CLAUDE.md both already describe this binary as an "admin HTML dashboard"; Cargo.toml [package].description says the same. The recent commit c019fa7 (despiegk + Sonnet 4.6) renamed the socket ui.sock → web.sock citing the convention but landed on the wrong row of the table — this PR completes the rebrand to the correct one.

Scope

Rebranded references across:

  • crate dir + Cargo.tomls (workspace + crate)
  • buildenv.sh BINARIES, plus VERSION sync 0.3.2 → 0.5.0 matching workspace.version
  • crates/hero_db/src/main.rs ActionBuilder + kill_other socket path
  • crates/hero_db_app WASM URL bases (/hero_db/ui → /hero_db/admin)
  • All in-repo docs (PURPOSE.md, CLAUDE.md, README.md, specs/hero_login.md, Makefile)
  • Env var HERO_DB_UI_BIND → HERO_DB_ADMIN_BIND

Out of scope (deferred)

hero_service_test skill §8 — Makefile + bash script removal in favour of nu-only lifecycle: filed separately at #28 . Independent of --download greenness on the from-nothing public-cloud bootstrap that is session 76's primary goal.

Verification

  • cargo build --release -p hero_db -p hero_db_server -p hero_db_admin ✅ green
  • cargo fmt --check ✅ clean
  • cargo clippy --release -- -D warnings ✅ clean
  • Final grep sweep: zero remaining hero_db_ui / HERO_DB_UI / hero_db web.sock references in committable files (excluding historical AUDIT_REPORT_2025-02-28.md).

Test plan

  • CI build-linux green for both x86_64-musl + aarch64-gnu matrix legs
  • Tag v0.5.0-rc1 after merge → publishes 6 target-triple-named assets (hero_db, hero_db_server, hero_db_admin × 2 archs)
  • hero_skills service_db.nu consumer PR (separate session 76 PR) updates SVX_BINARIES + healthcheck/kill_other socket paths to admin.sock, plus defensive HERO_SOCKET_DIR: $sock_base env (mirrors service_planner.nu:33)
  • Re-validate service_complete --download on a fresh hero.threefold.store VM. Closes the cascade of lhumina_code/hero_demo#65 + lhumina_code/hero_skills#237 + lhumina_code/hero_skills#238

Signed-off-by: mik-tf

## Summary Rename hero_db's admin dashboard binary from `hero_db_ui` → `hero_db_admin`, and the matching socket from `web.sock` → `admin.sock`, to comply with the `hero_service_test` skill's naming convention table: - Admin UI (Askama) = `hero_${name}_admin` → `admin.sock` - End-user web UI (Askama) = `hero_${name}_web` → `web.sock` - `_ui` suffix is the **old admin name** (explicitly flagged in the skill). PURPOSE.md and the in-repo CLAUDE.md both already describe this binary as an "admin HTML dashboard"; Cargo.toml `[package].description` says the same. The recent commit `c019fa7` (despiegk + Sonnet 4.6) renamed the socket `ui.sock → web.sock` citing the convention but landed on the wrong row of the table — this PR completes the rebrand to the correct one. ## Scope Rebranded references across: - crate dir + `Cargo.toml`s (workspace + crate) - `buildenv.sh` BINARIES, plus VERSION sync `0.3.2 → 0.5.0` matching `workspace.version` - `crates/hero_db/src/main.rs` ActionBuilder + `kill_other` socket path - `crates/hero_db_app` WASM URL bases (`/hero_db/ui` → `/hero_db/admin`) - All in-repo docs (PURPOSE.md, CLAUDE.md, README.md, specs/hero_login.md, Makefile) - Env var `HERO_DB_UI_BIND` → `HERO_DB_ADMIN_BIND` ## Out of scope (deferred) `hero_service_test` skill §8 — Makefile + bash script removal in favour of nu-only lifecycle: filed separately at https://forge.ourworld.tf/lhumina_code/hero_db/issues/28 . Independent of `--download` greenness on the from-nothing public-cloud bootstrap that is session 76's primary goal. ## Verification - `cargo build --release -p hero_db -p hero_db_server -p hero_db_admin` ✅ green - `cargo fmt --check` ✅ clean - `cargo clippy --release -- -D warnings` ✅ clean - Final grep sweep: zero remaining `hero_db_ui` / `HERO_DB_UI` / hero_db `web.sock` references in committable files (excluding historical `AUDIT_REPORT_2025-02-28.md`). ## Test plan - [ ] CI build-linux green for both x86_64-musl + aarch64-gnu matrix legs - [ ] Tag `v0.5.0-rc1` after merge → publishes 6 target-triple-named assets (`hero_db`, `hero_db_server`, `hero_db_admin` × 2 archs) - [ ] hero_skills `service_db.nu` consumer PR (separate session 76 PR) updates `SVX_BINARIES` + healthcheck/kill_other socket paths to `admin.sock`, plus defensive `HERO_SOCKET_DIR: $sock_base` env (mirrors `service_planner.nu:33`) - [ ] Re-validate `service_complete --download` on a fresh `hero.threefold.store` VM. Closes the cascade of https://forge.ourworld.tf/lhumina_code/hero_demo/issues/65 + https://forge.ourworld.tf/lhumina_code/hero_skills/issues/237 + https://forge.ourworld.tf/lhumina_code/hero_skills/issues/238 Signed-off-by: mik-tf
refactor: rename hero_db_ui → hero_db_admin (web.sock → admin.sock)
All checks were successful
CI / cargo check + clippy (pull_request) Successful in 2m9s
Details
CI / cargo test (pull_request) Successful in 2m27s
Details
Build and Test / build (pull_request) Successful in 5m7s
Details
5c9a14eb10 
Per the hero_service_test skill convention table, an admin HTML dashboard
maps to `hero_${service}_admin` + `admin.sock`, not `_ui`/`_web`. PURPOSE.md
+ Cargo.toml description both call this binary an "admin UI" — bring the
binary name and socket name in line with that.

Producer changes:
- crates/hero_db_ui/ → crates/hero_db_admin/ (git mv)
- [package].name + [lib].name + [[bin]].name → hero_db_admin
- $HERO_SOCKET_DIR/hero_db/web.sock → admin.sock (default_http_socket)
- HERO_DB_UI_BIND env var → HERO_DB_ADMIN_BIND
- workspace Cargo.toml members entry
- buildenv.sh BINARIES + VERSION 0.3.2→0.5.0 (matches workspace.version)
- crates/hero_db/src/main.rs: ActionBuilder name, kill_other socket path
- crates/hero_db_app: WASM URL bases /hero_db/ui → /hero_db/admin (app.rs,
  navbar.rs, rpc.rs)
- PURPOSE.md, in-repo CLAUDE.md, README.md, specs/hero_login.md, Makefile,
  hero_db_admin/Makefile: tables, socket layout, hero_router mapping

The cargo fmt --all run also touched a couple of unrelated import-order
nits (hero_db_server/src/main.rs, hero_db_admin) — pure formatting churn.

Refs:
- lhumina_code/hero_demo#65 (cascade root)
- lhumina_code/hero_skills#237 (downstream)
- lhumina_code/hero_skills#238 (downstream)
- #28 (deferred §8 cleanup)

Signed-off-by: mik-tf
mik-tf merged commit cde8024219 into development 2026-05-07 20:36:54 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
prio_critical

   
prio_low

   
type_bug

   
type_contact

   
type_issue

   
type_lead

   
type_question

   
type_story

   
type_task
No labels
prio_critical
prio_low
type_bug
type_contact
type_issue
type_lead
type_question
type_story
type_task
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
lhumina_code/hero_db!29
No description provided.