lhumina_code/hero_matrixchat
0
0
Fork 0
Code Issues 3 Pull requests Projects Releases 1 Packages Wiki Activity Actions

fix(ci): unblock release pipeline (features default + fmt debt) #7

Merged
mik-tf merged 2 commits from development_mik_features_default into development 2026-05-05 03:42:29 +00:00
Conversation 0 Commits 2 Files changed 4 +29 -16
mik-tf commented 2026-05-05 03:26:59 +00:00
Owner
Copy link

Two upstream-CI-path fixes bundled, both required for v0.1.0-rc1+ to ship.

(1) Declare empty default feature on hero_matrixchat_sdk

The new build-linux.yaml (#5) drives cargo via ALL_FEATURES=default, but no workspace member had a [features] section. v0.1.0-rc1 build-linux failed instantly with:

error: none of the selected packages contains this feature: default
selected packages: hero_matrixchat, hero_matrixchat_sdk, hero_matrixchat_server, hero_matrixchat_ui, hero_matrixchat_examples

Fix: add [features]\ndefault = [] to crates/hero_matrixchat_sdk/Cargo.toml. Mirrors hero_foundry_core / hero_biz_app convention. One crate with default is enough for cargo's workspace-wide --features default resolution.

(2) cargo fmt — clear ci.yml format debt

The pre-existing ci.yml workflow runs cargo fmt --all --check on push to development + PRs. After 0907fca (fix(logging): add herolib_core::logger HeroTracingLayer) three main.rs files diverged from rustfmt:

  • crates/hero_matrixchat/src/main.rs
  • crates/hero_matrixchat_server/src/main.rs
  • crates/hero_matrixchat_ui/src/main.rs

Mechanical cargo fmt — no behaviour changes (import order, struct constructor formatting, line wrapping).

Resolves #6.

Verified locally

cargo fmt --check                                              # OK
cargo clippy --workspace --all-targets -- -D warnings          # OK
cargo build --workspace --features default --release           # 52s OK

Next

  • Squash-merge with explicit user OK
  • Re-tag v0.1.0-rc2 (rc1 stays in place — assets-less, harmless)

Signed-off-by: mik-tf

## Two upstream-CI-path fixes bundled, both required for v0.1.0-rc1+ to ship. ### (1) Declare empty default feature on hero_matrixchat_sdk The new `build-linux.yaml` (https://forge.ourworld.tf/lhumina_code/hero_matrixchat/pulls/5) drives cargo via `ALL_FEATURES=default`, but no workspace member had a `[features]` section. v0.1.0-rc1 build-linux failed instantly with: ``` error: none of the selected packages contains this feature: default selected packages: hero_matrixchat, hero_matrixchat_sdk, hero_matrixchat_server, hero_matrixchat_ui, hero_matrixchat_examples ``` Fix: add `[features]\ndefault = []` to `crates/hero_matrixchat_sdk/Cargo.toml`. Mirrors `hero_foundry_core` / `hero_biz_app` convention. One crate with `default` is enough for cargo's workspace-wide `--features default` resolution. ### (2) cargo fmt — clear ci.yml format debt The pre-existing `ci.yml` workflow runs `cargo fmt --all --check` on push to development + PRs. After https://forge.ourworld.tf/lhumina_code/hero_matrixchat/commit/0907fca (`fix(logging): add herolib_core::logger HeroTracingLayer`) three main.rs files diverged from rustfmt: - `crates/hero_matrixchat/src/main.rs` - `crates/hero_matrixchat_server/src/main.rs` - `crates/hero_matrixchat_ui/src/main.rs` Mechanical `cargo fmt` — no behaviour changes (import order, struct constructor formatting, line wrapping). Resolves https://forge.ourworld.tf/lhumina_code/hero_matrixchat/issues/6. ## Verified locally ``` cargo fmt --check # OK cargo clippy --workspace --all-targets -- -D warnings # OK cargo build --workspace --features default --release # 52s OK ``` ## Next - Squash-merge with explicit user OK - Re-tag `v0.1.0-rc2` (rc1 stays in place — assets-less, harmless) Signed-off-by: mik-tf
fix(ci): declare empty default feature on hero_matrixchat_sdk
Some checks failed
CI / build (pull_request) Failing after 3s
Details
101eaae7af 
build-linux.yaml passes ALL_FEATURES=default to cargo, but no workspace
member declared a [features] section, so cargo errored out with:

  none of the selected packages contains this feature: default

Mirror the foundry / biz convention by adding [features] default = []
to the SDK crate (parallel to hero_foundry_core in
https://forge.ourworld.tf/lhumina_code/hero_foundry/blob/development/crates/hero_foundry_core/Cargo.toml
and hero_biz_app in
https://forge.ourworld.tf/lhumina_code/hero_biz/blob/development/crates/hero_biz_app/Cargo.toml).

Verified: cargo build --workspace --features default --release passes.

Signed-off-by: mik-tf
style: cargo fmt — clear ci.yml format debt from 0907fca
All checks were successful
CI / build (pull_request) Successful in 1m1s
Details
f0fd36af4e 
Three main.rs files diverged from rustfmt after
0907fca
introduced HeroTracingLayer. ci.yml's `cargo fmt --all --check` step
fails on every push since.

Mechanical `cargo fmt` — no behaviour changes, only:
- import order normalisation (LOG_LEVEL_* alphabetical, Layer/Context grouping)
- struct constructor multi-line formatting
- nested .with(...) line breaking

Resolves #6

Signed-off-by: mik-tf
mik-tf changed title from fix(ci): declare empty default feature on hero_matrixchat_sdk to fix(ci): unblock release pipeline (features default + fmt debt) 2026-05-05 03:31:16 +00:00
mik-tf merged commit 879e1e7cdd into development 2026-05-05 03:42:29 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
prio_critical

   
prio_low

   
type_bug

   
type_contact

   
type_issue

   
type_lead

   
type_question

   
type_story

   
type_task
No labels
prio_critical
prio_low
type_bug
type_contact
type_issue
type_lead
type_question
type_story
type_task
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
lhumina_code/hero_matrixchat!7
No description provided.