[ci] fmt debt in `0907fca` breaks cargo fmt --check on development #6

New issue

Closed

opened 2026-05-05 00:21:35 +00:00 by mik-tf · 0 comments

mik-tf commented

2026-05-05 00:21:35 +00:00

Owner

What

cargo fmt --check fails on development after commit 0907fca (fix(logging): add herolib_core::logger HeroTracingLayer to all binaries).

Files needing format:

crates/hero_matrixchat/src/main.rs
crates/hero_matrixchat_server/src/main.rs
crates/hero_matrixchat_ui/src/main.rs

Diff is mechanical (use ordering, tracing_subscriber import grouping, struct constructor formatting).

Why this surfaced now

The new .forgejo/workflows/build-linux.yaml introduced in #5 is cargo build only and does NOT enforce fmt — but the existing ci.yml does, and started failing on every commit since 0907fca.

Fix

One-liner:

cargo fmt
git add crates/hero_matrixchat*/src/main.rs
git commit -m "style: cargo fmt"

Workspace pre-merge gate

Per lhumina_code/home#204 (and feedback_workspace_build_before_merge.md workspace memory) — every non-trivial PR should pass cargo fmt --check && cargo clippy --workspace --all-targets -- -D warnings && cargo build --workspace --release locally before merge.

Filed by mik-tf during session 58 (cluster E port).

Signed-off-by: mik-tf

## What `cargo fmt --check` fails on `development` after commit https://forge.ourworld.tf/lhumina_code/hero_matrixchat/commit/0907fca (`fix(logging): add herolib_core::logger HeroTracingLayer to all binaries`). Files needing format: - `crates/hero_matrixchat/src/main.rs` - `crates/hero_matrixchat_server/src/main.rs` - `crates/hero_matrixchat_ui/src/main.rs` Diff is mechanical (use ordering, tracing_subscriber import grouping, struct constructor formatting). ## Why this surfaced now The new `.forgejo/workflows/build-linux.yaml` introduced in https://forge.ourworld.tf/lhumina_code/hero_matrixchat/pulls/5 is `cargo build` only and does NOT enforce fmt — but the existing `ci.yml` does, and started failing on every commit since `0907fca`. ## Fix One-liner: ``` cargo fmt git add crates/hero_matrixchat*/src/main.rs git commit -m "style: cargo fmt" ``` ## Workspace pre-merge gate Per https://forge.ourworld.tf/lhumina_code/home/issues/204 (and `feedback_workspace_build_before_merge.md` workspace memory) — every non-trivial PR should pass `cargo fmt --check && cargo clippy --workspace --all-targets -- -D warnings && cargo build --workspace --release` locally before merge. Filed by mik-tf during session 58 (cluster E port). Signed-off-by: mik-tf