Align hero_voice workspace structure with hero_services #4

Merged

mahmoud merged 9 commits from development_standardize into development 2026-02-24 11:50:18 +00:00

Conversation 0 Commits 9 Files changed 62 +9850 -1995

mahmoud commented 2026-02-24 09:20:44 +00:00

Owner

Copy link

Description

Bring the hero_voice workspace into full structural alignment with hero_services after the 5-crate conversion.

Changes

• Add SSH private key setup step to build.yaml and build-linux.yaml — without it CI cannot fetch hero_rpc_osis and herolib_* from private forge.ourworld.tf repos
• Remove test.yaml workflow — it was a duplicate of build.yaml (check + test + lint); hero_services has no separate test workflow
• Add LICENSE (Apache-2.0) at workspace root to match all other hero repos
• Add per-crate Makefile to all 5 crates (hero_voice, hero_voice_server, hero_voice_client, hero_voice_ui, hero_voice_rhai) following the identical pattern from hero_services
• Delete crates/hero_voice/sdk/ — stale location from before sdk_client_dir was introduced; Rust SDK is now generated directly to crates/hero_voice_client/
• Delete sdk/ at workspace root — stale JS types from an earlier build config that had .with_wasm() enabled; no JS is generated by the current build

Related Issues

• #3

### Description Bring the hero_voice workspace into full structural alignment with hero_services after the 5-crate conversion. ### Changes - Add SSH private key setup step to build.yaml and build-linux.yaml — without it CI cannot fetch hero_rpc_osis and herolib_* from private forge.ourworld.tf repos - Remove test.yaml workflow — it was a duplicate of build.yaml (check + test + lint); hero_services has no separate test workflow - Add LICENSE (Apache-2.0) at workspace root to match all other hero repos - Add per-crate Makefile to all 5 crates (hero_voice, hero_voice_server, hero_voice_client, hero_voice_ui, hero_voice_rhai) following the identical pattern from hero_services - Delete crates/hero_voice/sdk/ — stale location from before sdk_client_dir was introduced; Rust SDK is now generated directly to crates/hero_voice_client/ - Delete sdk/ at workspace root — stale JS types from an earlier build config that had .with_wasm() enabled; no JS is generated by the current build ### Related Issues - https://forge.ourworld.tf/lhumina_code/hero_voice/issues/3

mahmoud added 1 commit 2026-02-24 09:20:44 +00:00

feat: align hero_voice workspace structure with hero_services reference pattern ... 9ceb3ccf58

- Add SSH private key setup to build.yaml and build-linux.yaml (required
  for fetching private forge.ourworld.tf git dependencies)
- Remove redundant test.yaml workflow (covered by build.yaml)
- Add LICENSE (Apache-2.0) at workspace root
- Add per-crate Makefile to all 5 crates matching hero_services pattern
- Remove stale crates/hero_voice/sdk/ (old generated SDK location)
- Remove stale sdk/ at workspace root (JS types from removed wasm config)

mahmoud added 1 commit 2026-02-24 09:56:32 +00:00

refactor: Split Hero Voice server into dedicated RPC and HTTP services ... 2dc78fcfcb

- Create `hero_voice_openrpc` for core JSON-RPC backend
- Introduce `hero_voice_http` for UI, WebSockets, and RPC proxy
- Implement Model Context Protocol (MCP) handling
- Embed web UI assets and logic directly into `hero_voice_http`
- Update build environment, dependencies, and workspace configuration

mahmoud added 1 commit 2026-02-24 10:01:45 +00:00

refactor: replace axum::serve with hyper service ... c95b20d10e

- Add `hyper`, `hyper-util`, and `tower` dependencies
- Refactor TCP listener to use `hyper` service directly
- Refactor Unix socket listener to use `hyper` service
- Replace `axum::serve` with explicit `hyper` connections
- Enable WebSocket upgrades for `hyper` connections

mahmoud added 1 commit 2026-02-24 10:07:35 +00:00

chore: Remove hero_rpc_client dependency ... 478f8fe3ac

- Remove from workspace dependencies
- Remove local development patch

mahmoud added 1 commit 2026-02-24 10:19:07 +00:00

build: update local Cargo config for monorepo dev ... 566a47244b

- Add `hero_rpc_osis` local path override
- Expand `hero_lib` local path overrides
- Update comments on local dev setup
- Reorganize `[patch]` sections

mahmoud added 1 commit 2026-02-24 11:07:19 +00:00

fix: resolve cargo check failures for CI ... ddc33dc52e

- build.rs: use client_crate_dir() instead of removed sdk_client_dir()
- build.rs: append hand-written module declarations to always-regenerated lib.rs
- hero_voice/Cargo.toml: add [features] section (voice, all-domains, default)
- hero_voice_http/main.rs: remove unused tower::ServiceExt import
- .gitignore: exclude OSchema generator flat-output files from voice/
- Add generated src/services/mod.rs placeholder to workspace

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

mahmoud added 1 commit 2026-02-24 11:16:39 +00:00

fix: resolve all clippy lint warnings ... 730fcb0200

- tests.rs: remove duplicate #![cfg(test)] (already gated in mod.rs)
- openrpc/main.rs: use unwrap_or instead of unnecessary closure
- convert.rs: move constant assertion to const block
- ws.rs: remove useless .into() on String
- hero_voice_client/Cargo.toml: allow doc_lazy_continuation (generated code)

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

mahmoud added 1 commit 2026-02-24 11:26:57 +00:00

ci: add Cargo cache and SSH keepalive to fix git clone hangs ... 2c66d1fc95

- Cache ~/.cargo/registry and ~/.cargo/git/db keyed by Cargo.lock
  so large git deps (hero_rpc, hero_lib, 8000+ objects) are not
  re-fetched from scratch on every CI run
- Add SSH ServerAliveInterval/TCPKeepAlive to prevent connection
  drops during large pack transfers

mahmoud added 1 commit 2026-02-24 11:45:13 +00:00

ci: update hero_rpc lock + add Cargo cache and SSH keepalive ... 8f48a16fe6

- Cargo.lock: bump hero_rpc to 2ac573a (fix duplicate #![cfg(test)]
  in generated tests.rs — was triggering clippy::duplicated_attributes)
- build.yaml: cache ~/.cargo/registry and ~/.cargo/git/db keyed by
  Cargo.lock to avoid re-fetching 8000+ objects on every CI run
- build.yaml: add SSH ServerAliveInterval/TCPKeepAlive to prevent
  connection drops during large pack transfers

mahmoud merged commit e9664cb82b into development 2026-02-24 11:50:18 +00:00

mahmoud referenced this pull request from a commit 2026-02-24 11:50:19 +00:00

Merge pull request 'Align hero_voice workspace structure with hero_services' (#4) from development_standardize into development

mahmoud deleted branch development_standardize 2026-02-24 11:50:25 +00:00

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels

No items

No labels

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

lhumina_code/hero_voice!4

No description provided.