lhumina_code/hero_voice
4
0
Fork 0
Code Issues 4 Pull requests Projects Releases 2 Packages Wiki Activity Actions

fix(voice): drop broken hero-bootstrap-bridge.css link #18

Merged
zaelgohary merged 1 commit from development_fix_iframe_paths into development 2026-04-29 11:19:55 +00:00
Conversation 0 Commits 1 Files changed 1 -1
zaelgohary commented 2026-04-29 11:05:19 +00:00
Member
Copy link

Summary

<link href="/hero-bootstrap-bridge.css"> 404'd because hero_router doesn't expose the bridge CSS at root. Same fix pattern as hero_proc PR #72.

Related Issue

Closes #19

Changes

  • Removed the broken stylesheet link from index.html

Test Results

playwright trace: 0 failed requests on voice open.

before

## Summary `<link href="/hero-bootstrap-bridge.css">` 404'd because hero_router doesn't expose the bridge CSS at root. Same fix pattern as hero_proc PR #72. ## Related Issue Closes https://forge.ourworld.tf/lhumina_code/hero_voice/issues/19 ## Changes - Removed the broken stylesheet link from index.html ## Test Results playwright trace: 0 failed requests on voice open. ![before](https://forge.ourworld.tf/attachments/2303ddbe-166b-442a-9050-be0092daa2b1)
before-fix.png
80 KiB
fix(voice): drop broken hero-bootstrap-bridge.css link (404 in iframe)
All checks were successful
Build / build (pull_request) Successful in 9m30s
Details
a21f1ef32d
zaelgohary merged commit 4371bb76d4 into development 2026-04-29 11:19:55 +00:00
zaelgohary deleted branch development_fix_iframe_paths 2026-04-29 11:19:55 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
prio_critical

   
prio_low

   
type_bug

   
type_contact

   
type_issue

   
type_lead

   
type_question

   
type_story

   
type_task
No labels
prio_critical
prio_low
type_bug
type_contact
type_issue
type_lead
type_question
type_story
type_task
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
zaelgohary
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
lhumina_code/hero_voice!18
No description provided.