feat(slides): add first_slide field to DeckInfo + clean stale rpc.sock from --info #57

Merged
mik-tf merged 1 commit from development_mik into development 2026-05-10 23:17:41 +00:00
Owner

Focused follow-up after PR #56 (closed as superseded by upstream a83ffff + 3b89ec2).

Changes

  • Port first_slide: Option<String> field on DeckInfo from development_kristof fb3b622. discovery.rs::deck_info_from_path populates it from the first slide with a generated PNG. Exposed in deck.list JSON output and deck_summary_value for UI thumbnail rendering.

  • Drop stale rpc.sock entries from --info JSON output:

    • hero_slides CLI binds no sockets — sockets: []
    • hero_slides_admin only binds admin.sock — drop the rpc entry

Verified locally

  • deck.list JSON now carries first_slide for both example decks (01_title for hero_slides_intro, 01_intro for sample_deck)
  • hero_slides_admin --info reports sockets: ['admin'] only
  • Slides server compiles + restarts clean

Diff stat

5 files, +14 / -18.

Signed-off-by: mik-tf

Focused follow-up after PR #56 (closed as superseded by upstream a83ffff + 3b89ec2). ## Changes - **Port `first_slide: Option<String>` field on `DeckInfo`** from `development_kristof` `fb3b622`. `discovery.rs::deck_info_from_path` populates it from the first slide with a generated PNG. Exposed in `deck.list` JSON output and `deck_summary_value` for UI thumbnail rendering. - **Drop stale `rpc.sock` entries from `--info` JSON output:** - `hero_slides` CLI binds no sockets — `sockets: []` - `hero_slides_admin` only binds `admin.sock` — drop the rpc entry ## Verified locally - `deck.list` JSON now carries `first_slide` for both example decks (`01_title` for `hero_slides_intro`, `01_intro` for `sample_deck`) - `hero_slides_admin --info` reports `sockets: ['admin']` only - Slides server compiles + restarts clean ## Diff stat 5 files, +14 / -18. Signed-off-by: mik-tf
feat(slides): add first_slide field to DeckInfo + clean stale rpc.sock from --info
Some checks failed
Test / test (push) Failing after 3s
Test / test (pull_request) Failing after 3s
2a289f7734
- Port first_slide: Option<String> from development_kristof fb3b622.
  discovery.rs::deck_info_from_path populates it from the first slide
  with a generated PNG; rpc.rs exposes it in deck.list and
  deck_summary_value for UI thumbnail display.
- Drop stale rpc.sock entries from --info JSON of hero_slides (CLI binds
  no sockets) and hero_slides_admin (admin only binds admin.sock).

Verified locally: deck.list JSON now carries first_slide=01_title for
hero_slides_intro and first_slide=01_intro for sample_deck;
hero_slides_admin --info reports sockets: ['admin'] only.

Signed-off-by: mik-tf
mik-tf merged commit ff1fca73c1 into development 2026-05-10 23:17:41 +00:00
mik-tf deleted branch development_mik 2026-05-10 23:17:41 +00:00
Sign in to join this conversation.
No reviewers
No labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
lhumina_code/hero_slides!57
No description provided.