lhumina_code/hero_slides
22
0
Fork 0
Code Issues 6 Pull requests Projects Releases Packages Wiki Activity Actions

style: cargo fmt across workspace — green CI #33

Closed
mik-tf wants to merge 1 commit from development_mik_1 into development
pull from: development_mik_1
merge into: lhumina_code:development
Conversation 2 Commits 1 Files changed 9 +38 -35
mik-tf commented 2026-04-26 01:45:09 +00:00
Owner
Copy link

Sixth repo in the home#188 CI sweep. CI was failing only on fmt-check; rest already green. Ran cargo fmt --all on 4 files. Pure formatting, no source changes.

Verified local: cargo fmt --check, cargo check, cargo clippy -D warnings, cargo test all pass.

Sixth repo in the [home#188](https://forge.ourworld.tf/lhumina_code/home/issues/188) CI sweep. CI was failing only on fmt-check; rest already green. Ran cargo fmt --all on 4 files. Pure formatting, no source changes. Verified local: cargo fmt --check, cargo check, cargo clippy -D warnings, cargo test all pass.
style: cargo fmt across workspace
Some checks failed
Test / test (push) Failing after 2s
Details
Test / test (pull_request) Failing after 2s
Details
78208fd4f5 
CI workflow `.forgejo/workflows/test.yaml` runs `cargo fmt --check` as
the only step that was actually red on every push to development.
`cargo check`, `cargo clippy --workspace -- -D warnings`, and
`cargo test --workspace` all already pass on a clean development
checkout — only the formatting drift was failing.

Files normalized (4):
- crates/hero_slides/src/main.rs
- crates/hero_slides_server/openrpc.client.generated.rs
- crates/hero_slides_server/src/startup.rs
- crates/hero_slides_ui/src/routes.rs

No source-code changes — pure formatting.

Sixth repo in the home#188 CI sweep — turned out to be the simplest
case so far (no clippy errors, no stale tests, no workflow shape
issues; just `cargo fmt --all`).

Discipline note: I initially assumed the failure was the same
hero_proc_sdk `inputs`-field drift hero_embedder hit, started fixing
that, and almost shipped a wrong fix.  Caught it by reverting source
to development and reproducing — the actual failure surfaced cleanly
as fmt-only.  Lesson: reproduce the actual CI error before assuming
the cause; the fact that local check passed should have been a
signal earlier.

Tracker: lhumina_code/home#188
mik-tf commented 2026-04-26 01:53:15 +00:00
Author
Owner
Copy link

Pivoted to path B (proper fix), not path A (workflow gymnastics)

The original draft of this PR was just cargo fmt. Then CI surfaced a deeper issue: the workspace has path deps to a sibling-cloned hero_lib, which CI can't resolve. I almost shipped a workflow change that clones hero_lib alongside on each run — user pushed back: that's not real reproducibility. Force-pushed 120493b with the proper fix.

What this PR now does

Converted path deps to git deps:

  • Cargo.toml (root): removed [patch."https://forge.../hero_lib.git"] herolib_ai = { path = "../hero_lib/..." }
  • crates/hero_slides_lib/Cargo.toml: path = "../../../hero_lib/..." → git = "...", branch = "development"
  • crates/hero_slides_server/Cargo.toml: same
  • crates/hero_slides_rhai/Cargo.toml: same
  • Also removed 3 stale commented-out git-dep lines pointing at a long-gone branch (origin/development_ai_imageref)
  • cargo fmt --all across 4 files (the original lint failure)
  • Reverted the workflow-clone-sibling step (no longer needed; reproducibility is in Cargo.toml itself)

Why this is the right scope

  • Path deps to sibling clones only work in the canonical dev layout. CI / cargo install / release artifacts (home#187) all need this to compile from a clean checkout.
  • Adding sibling-clone gymnastics to the workflow papers over the underlying brittleness — any new external path dep later silently breaks CI.
  • Local devs who want to test against their own hero_lib changes can opt in via a local [patch] section. Default config = production reproducibility.

Closes

  • #34 — was the "defer this" tracker; obsolete now that path B is done.

Local verification

cargo fmt --check                          ✓
cargo check --workspace                    ✓
cargo clippy --workspace -- -D warnings    ✓
cargo test --workspace                     ✓ (0 tests)

Tracker: home#188

## Pivoted to path B (proper fix), not path A (workflow gymnastics) The original draft of this PR was just `cargo fmt`. Then CI surfaced a deeper issue: the workspace has **path deps to a sibling-cloned hero_lib**, which CI can't resolve. I almost shipped a workflow change that clones hero_lib alongside on each run — user pushed back: that's not real reproducibility. Force-pushed `120493b` with the proper fix. ## What this PR now does **Converted path deps to git deps:** - `Cargo.toml` (root): removed `[patch."https://forge.../hero_lib.git"] herolib_ai = { path = "../hero_lib/..." }` - `crates/hero_slides_lib/Cargo.toml`: `path = "../../../hero_lib/..."` → `git = "...", branch = "development"` - `crates/hero_slides_server/Cargo.toml`: same - `crates/hero_slides_rhai/Cargo.toml`: same - Also removed 3 stale commented-out git-dep lines pointing at a long-gone branch (`origin/development_ai_imageref`) - `cargo fmt --all` across 4 files (the original lint failure) - Reverted the workflow-clone-sibling step (no longer needed; reproducibility is in Cargo.toml itself) ## Why this is the right scope - Path deps to sibling clones only work in the canonical dev layout. CI / `cargo install` / release artifacts ([home#187](https://forge.ourworld.tf/lhumina_code/home/issues/187)) all need this to compile from a clean checkout. - Adding sibling-clone gymnastics to the workflow papers over the underlying brittleness — any new external path dep later silently breaks CI. - Local devs who want to test against their own hero_lib changes can opt in via a local `[patch]` section. Default config = production reproducibility. ## Closes - [#34](https://forge.ourworld.tf/lhumina_code/hero_slides/issues/34) — was the "defer this" tracker; obsolete now that path B is done. ## Local verification ``` cargo fmt --check ✓ cargo check --workspace ✓ cargo clippy --workspace -- -D warnings ✓ cargo test --workspace ✓ (0 tests) ``` Tracker: [home#188](https://forge.ourworld.tf/lhumina_code/home/issues/188)
mik-tf force-pushed development_mik_1 from 78208fd4f5
Some checks failed
Test / test (push) Failing after 2s
Details
Test / test (pull_request) Failing after 2s
Details
to 120493bcc7
All checks were successful
Test / test (pull_request) Successful in 1m13s
Details
Test / test (push) Successful in 1m35s
Details
2026-04-26 01:53:16 +00:00 Compare
mik-tf closed this pull request 2026-04-26 01:55:34 +00:00
mik-tf commented 2026-04-26 01:55:51 +00:00
Author
Owner
Copy link

Squash-merged to development as 2ce31c3. Branch deleted. Path deps → git deps. CI now buildable from any clean checkout.

Squash-merged to `development` as [`2ce31c3`](https://forge.ourworld.tf/lhumina_code/hero_slides/commit/2ce31c3). Branch deleted. Path deps → git deps. CI now buildable from any clean checkout.
All checks were successful
Test / test (pull_request) Successful in 1m13s
Details
Test / test (push) Successful in 1m35s
Details

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
lhumina_code/hero_slides!33
No description provided.