sync with integration #320

Merged
omarz merged 3 commits from integration into main 2026-06-10 12:46:33 +00:00
Member
No description provided.
ci: add prebaked lab-builder image + build workflow
Some checks failed
build lab-builder image / build-push (push) Has been cancelled
e544d82a5b
docker/lab-builder/Dockerfile: ubuntu:22.04 + rust 1.96 + musl + upx + a lab
prebuilt from this branch. build-lab-builder.yaml builds it via the runner's
docker socket and pushes lab-builder:latest-<branch> to the forge registry
(login as hero.releaser).
fix(lab/install): default install.sh to main + document URL-branch is ignored
All checks were successful
build lab-builder image / build-push (push) Successful in 2m25s
71fc042f4c
The one-liner `curl .../raw/branch/<X>/crates/lab/install.sh | bash` does
not build lab from branch <X>: piped from curl, the script cannot see the
URL it was fetched from, so it fell through to its hardcoded default
(`development`). Releases on main/integration silently built the build tool
from development-pinned deps.

Implements the two outstanding suggestions from hero_skills#317
(the BRANCH env var is already honored):

- Default to `main` instead of `development` for stability.
- Document prominently (install.sh header, --help, crates/lab/README.md)
  that the branch in the curl URL is ignored and callers MUST pass
  `--branch X` / `BRANCH=X` to build from a non-default branch.

Also repoint the gnu publish template's install curl at branch/main so it
matches the new default (the musl workflow already builds lab via
`cargo install --path` from the checked-out commit and is untouched).

Refs hero_skills#317

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
fix(lab/install): clone hero_skills from main, not development
All checks were successful
build lab-builder image / build-push (push) Successful in 6s
2972e8f6bf
cmd_build_lab's ensure_hero_skills_repo() hardcoded `git clone --branch
development` when no hero_skills checkout existed, so a source-build of
lab on a fresh machine silently pulled the floating development channel —
the same multi-socket-vs-rpc.sock mismatch reported in hero_skills#316.

Default the fresh-clone branch to stable `main` via a SKILLS_CLONE_BRANCH
constant. Only affects the no-checkout case; an existing checkout is used
on whatever branch it is already on.

Refs hero_skills#316

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
omarz merged commit e8642a0290 into main 2026-06-10 12:46:33 +00:00
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
lhumina_code/hero_skills!320
No description provided.