fix(service_complete + nutools/services): close session-74 upstream debts #239

Merged

mik-tf merged 1 commit from development_mik_session75_debts into development

2026-05-07 18:08:29 +00:00

mik-tf commented

2026-05-07 18:03:51 +00:00

Owner

Three consumer-side fixes surfaced during the session-74 from-nothing-on-DO validation. No Rust changes.

1. `service_complete --download` skips cargo-only services

code / os / livekit have no Forgejo CI release pipeline; their start fell through to the cargo install path on a fresh public-cloud VM with no Rust toolchain and failed with ROOTDIR not set.

Fix: under --download, drop those three from the starts list before the loop.

Closes #233

2. `service_complete` soft-fails per service

The previous error make short-circuited the whole loop on the first failing service, so operators never saw the full picture in one run.

Fix: collect failures into an accumulator, keep marching, print a per-service summary at the end. Nu disallows mut-var capture inside catch closures, so the catch returns the error message and the outer scope mutates.

Closes #234

3. Drop `service_webbuilder` references

The module file was never landed, but mod.nu:37, dispatcher.nu:61, 73, 89, 326-330 referenced it. Any use nutools/modules/services * failed with Module not found.

Fix: removal (per issue, the lower-risk path until the module ships).

Closes #236

Out of scope: hero_skills#235

Obsoleted by upstream rebrand bedaffb (producer [[bin]] hero_collab_ui → hero_collab_web) and 51afcfd (consumer service_collab.nu pre-flipped) at 2026-05-07 11:19/11:20. Will be closed as obsolete once the producer buildenv.sh BINARIES flips to hero_collab_web — otherwise the next CI build fails on missing target/release/hero_collab_ui.

Validation

nu -c "use ./mod.nu *; print 0" parses clean (previously failed with module_not_found for service_webbuilder).
service_complete --download no longer schedules code/os/livekit.

Three consumer-side fixes surfaced during the session-74 from-nothing-on-DO validation. No Rust changes. ## 1. `service_complete --download` skips cargo-only services `code` / `os` / `livekit` have no Forgejo CI release pipeline; their `start` fell through to the cargo install path on a fresh public-cloud VM with no Rust toolchain and failed with `ROOTDIR not set`. Fix: under `--download`, drop those three from the `starts` list before the loop. Closes https://forge.ourworld.tf/lhumina_code/hero_skills/issues/233 ## 2. `service_complete` soft-fails per service The previous `error make` short-circuited the whole loop on the first failing service, so operators never saw the full picture in one run. Fix: collect failures into an accumulator, keep marching, print a per-service summary at the end. Nu disallows mut-var capture inside catch closures, so the catch returns the error message and the outer scope mutates. Closes https://forge.ourworld.tf/lhumina_code/hero_skills/issues/234 ## 3. Drop `service_webbuilder` references The module file was never landed, but `mod.nu:37`, `dispatcher.nu:61, 73, 89, 326-330` referenced it. Any `use nutools/modules/services *` failed with `Module not found`. Fix: removal (per issue, the lower-risk path until the module ships). Closes https://forge.ourworld.tf/lhumina_code/hero_skills/issues/236 ## Out of scope: hero_skills#235 Obsoleted by upstream rebrand `bedaffb` (producer `[[bin]] hero_collab_ui → hero_collab_web`) and `51afcfd` (consumer `service_collab.nu` pre-flipped) at 2026-05-07 11:19/11:20. Will be closed as obsolete once the producer `buildenv.sh BINARIES` flips to `hero_collab_web` — otherwise the next CI build fails on missing `target/release/hero_collab_ui`. ## Validation - `nu -c "use ./mod.nu *; print 0"` parses clean (previously failed with `module_not_found` for `service_webbuilder`). - `service_complete --download` no longer schedules code/os/livekit.

mik-tf added 1 commit

2026-05-07 18:03:51 +00:00

fix(service_complete + nutools/services): close session-74 upstream debts

Build and Publish Skills / build-and-publish (pull_request) Successful in 3s

Details

4435609def

Three independent fixes surfaced during the session-74 from-nothing-on-DO validation:

1. service_complete --download skips cargo-only services (code/os/livekit).
   Their `start` fell through to the cargo install path on a fresh public-cloud
   VM with no Rust toolchain and failed with "ROOTDIR not set".
   Closes #233

2. service_complete soft-fails per service.
   The previous `error make` short-circuited the whole loop on the first
   failing service, so operators never saw the full picture in one run.
   Now collects failures, prints a per-service summary at the end, and
   keeps marching. Nu disallows mut-var capture inside catch closures, so
   the catch returns the error message and the outer scope mutates.
   Closes #234

3. Drop service_webbuilder references from mod.nu + dispatcher.nu.
   The module file was never landed but mod.nu line 37 and dispatcher.nu
   lines 61, 73, 89, 326-330 referenced it, so any
   `use nutools/modules/services *` failed with "Module not found".
   Per the issue, removal is the lower-risk path until the module ships.
   Closes #236

hero_skills#235 (consumer hero_collab_web vs hero_collab_ui naming) is
NOT addressed here — it was obsoleted by upstream rebrand bedaffb (producer
crates/hero_collab_ui [[bin]] → hero_collab_web) and 51afcfd (consumer
service_collab.nu pre-flipped) on 2026-05-07. The release tag v0.5.0-rc1
still ships the old _ui name; the next tag will ship _web. Will be closed
as obsolete with a pointer once the producer's buildenv.sh BINARIES is
flipped to hero_collab_web (otherwise the next CI build fails on missing
target/release/hero_collab_ui).

Signed-off-by: mik-tf