fix(lib): export svc_verify_elf for use by per-service modules #212

Merged

mik-tf merged 1 commit from development_mik_export_verify_elf into development

2026-05-05 15:18:57 +00:00

mik-tf commented

2026-05-05 13:39:30 +00:00

Owner

PR #210 introduced svx_install_onnx_runtime_from_ci in service_editor.nu, which calls svc_verify_elf via the use ./lib.nu * import. svc_verify_elf wasn't exported, so at runtime nu treated it as an external command name and failed with the generic 'External command failed' error — masking a name-resolution miss.

Caught during the heroci smoke for D-05 session 60: hero_editor_server and hero_editor_ui installed fine (svc_install_from_ci uses svc_verify_elf in the same file via lexical scope), but the .so install in service_editor.nu's helper hit the unexported call and errored.

One-line fix mirrors the same export decision made for svc_download_asset in PR #210 (both helpers are now part of the per-service consumer surface for ONNX-using services in sessions 60/61/62).

PR #210 introduced `svx_install_onnx_runtime_from_ci` in `service_editor.nu`, which calls `svc_verify_elf` via the `use ./lib.nu *` import. `svc_verify_elf` wasn't exported, so at runtime nu treated it as an external command name and failed with the generic 'External command failed' error — masking a name-resolution miss. Caught during the heroci smoke for D-05 session 60: `hero_editor_server` and `hero_editor_ui` installed fine (`svc_install_from_ci` uses `svc_verify_elf` in the same file via lexical scope), but the `.so` install in `service_editor.nu`'s helper hit the unexported call and errored. One-line fix mirrors the same export decision made for `svc_download_asset` in PR #210 (both helpers are now part of the per-service consumer surface for ONNX-using services in sessions 60/61/62).

mik-tf added 1 commit

2026-05-05 13:39:30 +00:00

fix(lib): export svc_verify_elf for use by per-service modules

Build and Publish Skills / build-and-publish (pull_request) Successful in 3s

Details

f4bc118526

PR #210 introduced svx_install_onnx_runtime_from_ci in
service_editor.nu, which calls svc_verify_elf via the `use ./lib.nu *`
import. svc_verify_elf wasn't exported, so at runtime nu treated it
as an external command name and failed with the generic "External
command failed" error — masking a name-resolution miss.

Caught during the heroci smoke for D-05 session 60: hero_editor_server
and hero_editor_ui installed fine (svc_install_from_ci uses
svc_verify_elf in the same file via lexical scope), but the .so
install in service_editor.nu's helper hit the unexported call and
errored.

One-line fix mirrors the same export decision made for svc_download_asset
in PR #210 (both helpers are now part of the per-service consumer
surface for ONNX-using services in sessions 60/61/62).

Signed-off-by: mik-tf