lhumina_code/hero_skills
2
0
Fork 0
Code Issues 12 Pull requests 2 Projects Releases 1 Packages 1 Wiki Activity Actions

revert PR #163 — start_base/start_full/islands_build merged by mistake #166

Merged
mahmoud merged 3 commits from revert_service_os_bundles_islands_build into development 2026-04-29 07:47:03 +00:00
Conversation 0 Commits 3 Files changed 3 +9 -285
mahmoud commented 2026-04-29 05:36:33 +00:00
Owner
Copy link

PR #163 was merged into development (commit 2ce6005) but the convention concerns raised in the review on that PR were not addressed. This PR reverts the merge so tools/modules/services/service_os.nu is back to its pre-merge state.

For the rationale, see the review comment on the original PR: #163 (comment)

In short:

  • start_base / start_full duplicate service_complete (in packages.nu) with a divergent curated list — drift is already visible (commit 3 of #163 had to remove service_codescalers).
  • 13 sibling use ./service_*.nu imports in service_os.nu turn a leaf module into a meta-orchestrator, which is not the convention the rest of the modules follow.
  • start_full skips service_core's core_step health/retry machinery, so it's strictly less robust than the pattern it bypasses.
  • islands_build builds lhumina_code/hero_archipelagos (a separate repo, separate toolchain) — it belongs in its own module, not in service_os.nu.

The svx_check_islands preflight warn was a nice add on its own — if we want to keep that, we can re-introduce it as a small follow-up against service_os start without the bundle commands.

Reverts 2ce600501e.

PR #163 was merged into `development` (commit 2ce6005) but the convention concerns raised in the review on that PR were not addressed. This PR reverts the merge so `tools/modules/services/service_os.nu` is back to its pre-merge state. For the rationale, see the review comment on the original PR: https://forge.ourworld.tf/lhumina_code/hero_skills/pulls/163#issuecomment-26485 In short: - `start_base` / `start_full` duplicate `service_complete` (in `packages.nu`) with a divergent curated list — drift is already visible (commit 3 of #163 had to remove `service_codescalers`). - 13 sibling `use ./service_*.nu` imports in `service_os.nu` turn a leaf module into a meta-orchestrator, which is not the convention the rest of the modules follow. - `start_full` skips `service_core`'s `core_step` health/retry machinery, so it's strictly less robust than the pattern it bypasses. - `islands_build` builds `lhumina_code/hero_archipelagos` (a separate repo, separate toolchain) — it belongs in its own module, not in `service_os.nu`. The `svx_check_islands` preflight warn was a nice add on its own — if we want to keep that, we can re-introduce it as a small follow-up against `service_os start` without the bundle commands. Reverts 2ce600501edaed152b6a11c229525261cd0fd8b4.
revert "feat(service_os): bundle commands and islands_build" (PR #163)
All checks were successful
Build and Publish Skills / build-and-publish (pull_request) Successful in 2s
Details
a4a1fcf019 
This reverts merge commit 2ce6005, which landed PR #163 against the
intent of the review on that PR (see the comment thread). The
start_base / start_full bundles duplicate service_complete with a
divergent curated list, and islands_build belongs in its own module
rather than service_os.nu — see PR #163 for the full discussion.

Removes the 278 added lines and restores tools/modules/services/service_os.nu
to its pre-merge state.
Fix — three references aligned at /home/mahmoud/hero/code/hero_skills/tools/modules/services/service_aibroker.nu:
All checks were successful
Build and Publish Skills / build-and-publish (pull_request) Successful in 4s
Details
a94fb177c8 
- Line 17 (header comment about extra shipped binaries)
  - Line 89 (SVX_BINARIES block comment)
  - Line 91 (SVX_BINARIES constant)
Merge branch 'development' into revert_service_os_bundles_islands_build
All checks were successful
Build and Publish Skills / build-and-publish (pull_request) Successful in 2s
Details
7dfe46bc09
mahmoud merged commit afb8d51fe5 into development 2026-04-29 07:47:03 +00:00
mahmoud deleted branch revert_service_os_bundles_islands_build 2026-04-29 07:47:07 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
prio_critical

   
prio_low

   
type_bug

   
type_contact

   
type_issue

   
type_lead

   
type_question

   
type_story

   
type_task
No labels
prio_critical
prio_low
type_bug
type_contact
type_issue
type_lead
type_question
type_story
type_task
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
lhumina_code/hero_skills!166
No description provided.