lhumina_code/hero_services
23
0
Fork 0
Code Issues 7 Pull requests Projects Releases 1 Packages 1 Wiki Activity Actions

Fix hero_indexer repo URL in service TOML #31

Closed
mik-tf wants to merge 1 commit from development_fix_indexer_repo_url into development
pull from: development_fix_indexer_repo_url
merge into: lhumina_code:development
Conversation 2 Commits 1 Files changed 1 +1 -1
mik-tf commented 2026-02-26 14:07:15 +00:00
Owner
Copy link

Fix hero_indexer service definition pointing to empty hero_index_server repo.

Changes

  • Update services/user/hero_indexer.toml repo URL from hero_index_server to hero_indexer

Testing

  • Verified lhumina_code/hero_indexer exists with development branch
  • Verified lhumina_code/hero_index_server is an empty repo

Issue #29 status

This PR + hero_inspector PR #2 address all 4 failures from #29:

Service Fix
hero_indexer This PR — correct repo URL
hero_inspector hero_inspector PR #2 — fix Makefile TARGET
hero_embedder No fix needed — new Dockerfile builder (rust:bookworm) has g++
hero_voice No fix needed — same reason

Closes #29

Fix hero_indexer service definition pointing to empty `hero_index_server` repo. ## Changes - Update `services/user/hero_indexer.toml` repo URL from `hero_index_server` to `hero_indexer` ## Testing - Verified `lhumina_code/hero_indexer` exists with `development` branch - Verified `lhumina_code/hero_index_server` is an empty repo ## Issue #29 status This PR + [hero_inspector PR #2](https://forge.ourworld.tf/lhumina_code/hero_inspector/pulls/2) address all 4 failures from #29: | Service | Fix | |---|---| | hero_indexer | **This PR** — correct repo URL | | hero_inspector | [hero_inspector PR #2](https://forge.ourworld.tf/lhumina_code/hero_inspector/pulls/2) — fix Makefile TARGET | | hero_embedder | No fix needed — new Dockerfile builder (`rust:bookworm`) has `g++` | | hero_voice | No fix needed — same reason | Closes #29
fix: correct hero_indexer repo URL from hero_index_server to hero_indexer
All checks were successful
Build and Test / build (pull_request) Successful in 5m22s
Details
003141c3fb 
The TOML referenced lhumina_code/hero_index_server which is an empty
repo. The actual repo is lhumina_code/hero_indexer.

Co-Authored-By: mik-tf <mik@threefold.io>
mik-tf changed title from WIP: Fix hero_indexer repo URL in service TOML to Fix hero_indexer repo URL in service TOML 2026-02-26 14:34:33 +00:00
mik-tf commented 2026-02-26 16:33:49 +00:00
Author
Owner
Copy link

@timur

Lmk what you think! We can review + merge, and also cherry pick and close the PR too.

@timur Lmk what you think! We can review + merge, and also cherry pick and close the PR too.
mik-tf requested review from timur 2026-02-26 16:34:34 +00:00
mik-tf closed this pull request 2026-02-27 14:52:33 +00:00
mik-tf commented 2026-02-27 14:52:33 +00:00
Author
Owner
Copy link

Superseded by #43 (combined deploy branch with all PRs merged).

Superseded by #43 (combined deploy branch with all PRs merged).
All checks were successful
Build and Test / build (pull_request) Successful in 5m22s
Details

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
timur
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
lhumina_code/hero_services!31
No description provided.