lhumina_code/hero_service
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

chore(deps): drop stale hero_rpc#85 TEMPORARY comments + regen against current hero_rpc #4

Merged
timur merged 1 commit from chore-drop-stale-hero-rpc-85-comments into development 2026-05-20 08:51:08 +00:00
Conversation 0 Commits 1 Files changed 8 +291 -304
timur commented 2026-05-20 08:51:00 +00:00
Owner
Copy link

Cleanup follow-up to #2.

Summary

  • Three Cargo.toml files (hero_service, hero_service_server, hero_service_sdk) carried # TEMPORARY branch override — switch back to "development" once hero_rpc#85 is merged. Those comments are now orphans (the branch pins were flipped back in #2; hero_rpc#85 is merged via hero_rpc#87). Dropped.
  • Regenerated osis_server_generated.rs, rpc_generated.rs, docs/catalog/openrpc.json, tests.rs, and Cargo.lock against current hero_rpc development (commit 41961658). The regen picks up hero_rpc#83's typed-error-category fields on RpcResponse (error_kind, RpcResponse::invalid / ::not_found / ::permission_denied).

Test plan

  • cargo build --workspace clean.
  • cargo test --workspace clean (2 catalog CRUD tests pass).
Cleanup follow-up to #2. ## Summary - Three Cargo.toml files (`hero_service`, `hero_service_server`, `hero_service_sdk`) carried `# TEMPORARY branch override — switch back to "development" once hero_rpc#85 is merged.` Those comments are now orphans (the branch pins were flipped back in #2; hero_rpc#85 is merged via hero_rpc#87). Dropped. - Regenerated `osis_server_generated.rs`, `rpc_generated.rs`, `docs/catalog/openrpc.json`, `tests.rs`, and `Cargo.lock` against current hero_rpc development (commit `41961658`). The regen picks up hero_rpc#83's typed-error-category fields on `RpcResponse` (`error_kind`, `RpcResponse::invalid` / `::not_found` / `::permission_denied`). ## Test plan - [x] `cargo build --workspace` clean. - [x] `cargo test --workspace` clean (2 catalog CRUD tests pass). 
The branch pins were flipped back to `development` in #2; the TEMPORARY
comments that pointed at hero_rpc#85 are now orphans. Drop them.

No code change — just the comments. Build clean.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
timur merged commit 4deb59e88e into development 2026-05-20 08:51:08 +00:00
timur deleted branch chore-drop-stale-hero-rpc-85-comments 2026-05-20 08:51:08 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
lhumina_code/hero_service!4
No description provided.