lhumina_code/hero_router
3
0
Fork 0
Code Issues 19 Pull requests 1 Projects Releases 9 Packages Wiki Activity Actions

chore(hero_router): D-10 sweep — cargo update + conservative dep audit #106

Merged
mik-tf merged 1 commit from development_mik_d10_s100 into development 2026-05-16 03:49:07 +00:00
Conversation 0 Commits 1 Files changed 3 +4 -69
mik-tf commented 2026-05-16 03:48:22 +00:00
Owner
Copy link

Summary

D-10 sweep (hero_proc#102) for hero_router — T1 #5, last T1 repo. After this lands, T1 = 6/6 done and T2 (14 app services) opens.

hero_router is unusual: a single binary by design (server + admin + CLI roles combined per repo CLAUDE.md), so the canonical multi-binary service.toml pattern collapses to one binary entry. hero_router_test has a distinct service.name and stays standalone (same pattern as the 7 standalone MCP sub-binaries kept out of hero_aibroker#142).

Branch-name deviation (one-off)

Per the standing rule (memory/feedback_branch_name_development_mik.md) the branch should be literal development_mik. The literal name was unsafe to use this session because origin/development_mik already exists with content authored by Kristof (despiegk), including a merge of origin/development_mik_service_manager_v2 (the feedback_never_merge_hero_router_pr92 branch) into it. Per memory/feedback_branch_cleanup_only_own_authored.md I cannot touch that branch, and per the never-merge-PR#92 rule I must not let that content propagate. Pushed to development_mik_d10_s100 as the safest workaround. Will not be repeated for future sweeps unless the same conflict surfaces — origin/development_mik should be cleaned up by Kristof at his discretion.

Changes

  • cargo update: 4 packages picked up — hero_proc_sdk + hero_proc_lib_ui 6dd27c85 → a436a20f (s97 #103); herolib_core + herolib_derive 37125e55 → 9b5912bf (s96 #140).
  • crates/hero_router/Cargo.toml: stripped 2 zero-match deps (thiserror, hero_service).
  • crates/hero_router_test/Cargo.toml: stripped 1 zero-match dep (serde — only serde_json is used).
  • No service.toml changes needed (already canonical for the single-binary design).
  • No source code changes.

Diff: 3 files, +4 / −69. Cargo.lock accounts for nearly all of the line delta.

D-10 acceptance (5/5)

# Criterion Result
1 cargo update clean ✓ — 4 packages, no errors
2 lab infocheck clean ✓ — 2 crate(s) clean, 0 finding(s) total
3 Conservative dep audit ✓ — 3 zero-match deps stripped (verified by grep -rE 'use <crate>::|<crate>::' src/)
4 lab build --release --install --workspace --policy-mode warn ✓ — 1 binary built (hero_router); hero_router_test (kind=cmdline) verified compile via cargo build; hero_inspector_app (Dioxus WASM lib) verified compile via cargo check
5 Smoke + tests lab service hero_router --install --start: 6/6 smoke (rpc.sock + admin.sock × {health, openrpc, heroservice, system.ping}). TCP 9988 health 200 + heroservice protocol=ui. cargo test --workspace --release: 105 passed, 1 pre-existing failure (cache::tests::derive_group_name_falls_back_to_stem_for_unknown_sockets asserts "sockets" == "legacy" — verified pre-existing on origin/development via stash-and-rerun; out of D-10 scope)

Refs

## Summary D-10 sweep ([hero_proc#102](https://forge.ourworld.tf/lhumina_code/hero_proc/issues/102)) for `hero_router` — **T1 #5, last T1 repo**. After this lands, T1 = 6/6 done and T2 (14 app services) opens. `hero_router` is unusual: a single binary by design (server + admin + CLI roles combined per repo `CLAUDE.md`), so the canonical multi-binary `service.toml` pattern collapses to one binary entry. `hero_router_test` has a distinct `service.name` and stays standalone (same pattern as the 7 standalone MCP sub-binaries kept out of [hero_aibroker#142](https://forge.ourworld.tf/lhumina_code/hero_aibroker/pulls/142)). ## Branch-name deviation (one-off) Per the standing rule (`memory/feedback_branch_name_development_mik.md`) the branch should be literal `development_mik`. The literal name was unsafe to use this session because `origin/development_mik` already exists with content authored by Kristof (`despiegk`), including a merge of `origin/development_mik_service_manager_v2` (the `feedback_never_merge_hero_router_pr92` branch) into it. Per `memory/feedback_branch_cleanup_only_own_authored.md` I cannot touch that branch, and per the never-merge-PR#92 rule I must not let that content propagate. Pushed to `development_mik_d10_s100` as the safest workaround. Will not be repeated for future sweeps unless the same conflict surfaces — `origin/development_mik` should be cleaned up by Kristof at his discretion. ## Changes - `cargo update`: 4 packages picked up — `hero_proc_sdk` + `hero_proc_lib_ui` `6dd27c85 → a436a20f` (s97 [#103](https://forge.ourworld.tf/lhumina_code/hero_proc/pulls/103)); `herolib_core` + `herolib_derive` `37125e55 → 9b5912bf` (s96 [#140](https://forge.ourworld.tf/lhumina_code/hero_lib/pulls/140)). - `crates/hero_router/Cargo.toml`: stripped 2 zero-match deps (`thiserror`, `hero_service`). - `crates/hero_router_test/Cargo.toml`: stripped 1 zero-match dep (`serde` — only `serde_json` is used). - No `service.toml` changes needed (already canonical for the single-binary design). - No source code changes. Diff: 3 files, +4 / −69. Cargo.lock accounts for nearly all of the line delta. ## D-10 acceptance (5/5) | # | Criterion | Result | |---|---|---| | 1 | `cargo update` clean | ✓ — 4 packages, no errors | | 2 | `lab infocheck` clean | ✓ — 2 crate(s) clean, 0 finding(s) total | | 3 | Conservative dep audit | ✓ — 3 zero-match deps stripped (verified by `grep -rE 'use <crate>::\|<crate>::' src/`) | | 4 | `lab build --release --install --workspace --policy-mode warn` | ✓ — 1 binary built (`hero_router`); `hero_router_test` (`kind=cmdline`) verified compile via `cargo build`; `hero_inspector_app` (Dioxus WASM lib) verified compile via `cargo check` | | 5 | Smoke + tests | `lab service hero_router --install --start`: **6/6** smoke (rpc.sock + admin.sock × {health, openrpc, heroservice, system.ping}). TCP 9988 health 200 + heroservice `protocol=ui`. `cargo test --workspace --release`: **105 passed, 1 pre-existing failure** (`cache::tests::derive_group_name_falls_back_to_stem_for_unknown_sockets` asserts `"sockets" == "legacy"` — verified pre-existing on `origin/development` via stash-and-rerun; out of D-10 scope) | ## Refs - Tracker: https://forge.ourworld.tf/lhumina_code/hero_proc/issues/102 - Status table: https://forge.ourworld.tf/lhumina_code/hero_proc/issues/102#issuecomment-33220 - D-10 spec: `decisions/D-10-service-toml-sweep-scope-order-acceptance.md` - Sibling sweeps (T1 done): hero_lib [#140](https://forge.ourworld.tf/lhumina_code/hero_lib/pulls/140) `9b5912bf`, hero_proc [#103](https://forge.ourworld.tf/lhumina_code/hero_proc/pulls/103) `a436a20f`, hero_db [#31](https://forge.ourworld.tf/lhumina_code/hero_db/pulls/31) `3585150c`, hero_aibroker [#142](https://forge.ourworld.tf/lhumina_code/hero_aibroker/pulls/142) `94e6b76d`, hero_code [#15](https://forge.ourworld.tf/lhumina_code/hero_code/pulls/15) `53a8d37` (retro)
chore(hero_router): D-10 sweep — cargo update + conservative dep audit
All checks were successful
Build & Test / check (pull_request) Successful in 2m24s
Details
d34fcc65af 
Closes hero_proc#102 entry for hero_router (T1 #5, last T1).

Lightweight sweep: hero_router is a single-binary repo by design (server +
admin + CLI roles combined per repo CLAUDE.md), so the canonical
multi-binary service.toml pattern collapses to one binary.
hero_router_test has a distinct service.name and stays standalone.

Changes
- cargo update: 4 packages picked up (hero_proc_sdk +
  hero_proc_lib_ui 6dd27c85 → a436a20f via s97 #103;
  herolib_core + herolib_derive 37125e55 → 9b5912bf via s96 #140).
- crates/hero_router/Cargo.toml: stripped 2 zero-match deps
  (thiserror, hero_service).
- crates/hero_router_test/Cargo.toml: stripped 1 zero-match dep
  (serde — only serde_json is used).

D-10 acceptance (5/5)
1. cargo update clean.
2. lab infocheck: 2 crate(s) clean, 0 finding(s).
3. Conservative dep audit: 3 zero-match deps stripped (verified by
   `grep -rE 'use <crate>::|<crate>::' src/` against each declared
   workspace dep).
4. lab build --release --install --workspace --policy-mode warn: 1
   binary built (hero_router); hero_router_test (kind=cmdline) and
   hero_inspector_app (Dioxus WASM lib) verified compile via
   cargo build/check.
5. Smoke: lab service hero_router --install --start passed 6/6
   (rpc.sock + admin.sock health/openrpc/heroservice/system.ping); TCP
   9988 health 200 + heroservice protocol=ui. cargo test --workspace
   --release: 105 passed, 1 pre-existing failure
   (cache::tests::derive_group_name_falls_back_to_stem_for_unknown_sockets,
   asserts "sockets" == "legacy" — verified pre-existing on origin/development
   via stash-and-rerun; out of D-10 scope).

Refs
- lhumina_code/hero_proc#102
- lhumina_code/hero_proc#102 (comment)

Signed-off-by: mik-tf
Signed-off-by: mik-tf <logismos@protonmail.ch>
mik-tf merged commit acb53b14f3 into development 2026-05-16 03:49:07 +00:00
mik-tf deleted branch development_mik_d10_s100 2026-05-16 03:49:08 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
prio_critical

   
prio_low

   
type_bug

   
type_contact

   
type_issue

   
type_lead

   
type_question

   
type_story

   
type_task
No labels
prio_critical
prio_low
type_bug
type_contact
type_issue
type_lead
type_question
type_story
type_task
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
lhumina_code/hero_router!106
No description provided.