lhumina_code/hero_proc_archive
Archived
24
0
Fork 0
forked from geomind_code/zinit_archive2
Code Issues Pull requests Activity

fix our skills #3

New issue
Closed
opened 2026-03-18 05:37:20 +00:00 by despiegk · 4 comments
despiegk commented 2026-03-18 05:37:20 +00:00
Owner
Copy link

see /Users/despiegk/hero/code/hero_skills/claude/skills/zinit_sdk/SKILL.md

this needs to make it easy for other projects to use zinit which is now called hero_proc

(need to change in skill to)

lets pin the skill On branch development_kristof_ttyd
make sure they use that one to link too

see /Users/despiegk/hero/code/hero_skills/claude/skills/zinit_sdk/SKILL.md this needs to make it easy for other projects to use zinit which is now called hero_proc (need to change in skill to) lets pin the skill On branch development_kristof_ttyd make sure they use that one to link too
despiegk commented 2026-03-18 07:19:43 +00:00
Author
Owner
Copy link

Implementation Spec for Issue #3 — Fix zinit_sdk Skill for hero_proc

Objective

Update the skill file at /Users/despiegk/hero/code/hero_skills/claude/skills/zinit_sdk/SKILL.md to accurately reflect the renamed project (zinit → hero_proc): correct all type names, socket paths, env var names, and the Cargo.toml dependency snippet. Rename the skill directory from zinit_sdk to hero_proc_sdk. Pin the install snippet to the development_kristof_ttyd branch of lhumina_code/hero_proc.

Requirements

  • Rename skill directory zinit_sdk/ → hero_proc_sdk/ (git mv)
  • Update frontmatter: name, description, trigger phrases, related_skills
  • Replace all use zinit_sdk::*; → use hero_proc_sdk::*;
  • Replace ZinitRPCAPIClient → HeroProcRPCAPIClient everywhere
  • Remove non-existent types ZinitHandle and AsyncZinitClient
  • Update socket paths: /run/hero_proc.sock, $HOME/hero/var/sockets/hero_proc_server.sock
  • Update env var: ZINIT_SOCKET → HERO_PROC_SOCKET
  • Update Cargo.toml snippet: https://forge.ourworld.tf/lhumina_code/hero_proc.git, branch = "development_kristof_ttyd"
  • Update "See Also" link to https://forge.ourworld.tf/lhumina_code/hero_proc
  • Scan sibling skills for zinit_sdk cross-references and update to hero_proc_sdk

Files to Modify

  • /Users/despiegk/hero/code/hero_skills/claude/skills/zinit_sdk/SKILL.md → renamed to hero_proc_sdk/SKILL.md and fully updated
  • Any sibling skill with zinit_sdk in related_skills: frontmatter

Implementation Steps

Step 1 — Rename directory

git mv .../zinit_sdk .../hero_proc_sdk

Step 2 — Update YAML frontmatter

New name: hero_proc_sdk, update description and trigger phrases

Step 3 — Update all use zinit_sdk imports → use hero_proc_sdk

Step 4 — Replace all ZinitRPCAPIClient → HeroProcRPCAPIClient

Step 5 — Remove ZinitHandle / AsyncZinitClient references

Step 6 — Update socket paths, env vars, and troubleshooting sections

Step 7 — Update Cargo.toml installation snippet (repo URL + branch)

Step 8 — Update "See Also" section

Step 9 — Scan & update sibling skills referencing zinit_sdk

Acceptance Criteria

  • Directory renamed to hero_proc_sdk/
  • Zero occurrences of ZinitRPCAPIClient remain
  • Zero occurrences of use zinit_sdk:: remain
  • Zero occurrences of ZinitHandle or AsyncZinitClient remain
  • Cargo.toml snippet uses lhumina_code/hero_proc.git + development_kristof_ttyd branch
  • Socket paths and env var updated to hero_proc naming
  • "See Also" links to https://forge.ourworld.tf/lhumina_code/hero_proc
  • Sibling skills updated

Notes

  • Keep "zinit" as a trigger phrase for backward compatibility (agents asked about old name will find this skill)
  • zinit_cmd skill may also need a parallel rename but is out of scope for this issue
  • Repo URL changed from geomind_code/zinit → lhumina_code/hero_proc
# Implementation Spec for Issue #3 — Fix `zinit_sdk` Skill for `hero_proc` ## Objective Update the skill file at `/Users/despiegk/hero/code/hero_skills/claude/skills/zinit_sdk/SKILL.md` to accurately reflect the renamed project (`zinit` → `hero_proc`): correct all type names, socket paths, env var names, and the Cargo.toml dependency snippet. Rename the skill directory from `zinit_sdk` to `hero_proc_sdk`. Pin the install snippet to the `development_kristof_ttyd` branch of `lhumina_code/hero_proc`. ## Requirements - Rename skill directory `zinit_sdk/` → `hero_proc_sdk/` (git mv) - Update frontmatter: `name`, `description`, trigger phrases, `related_skills` - Replace all `use zinit_sdk::*;` → `use hero_proc_sdk::*;` - Replace `ZinitRPCAPIClient` → `HeroProcRPCAPIClient` everywhere - Remove non-existent types `ZinitHandle` and `AsyncZinitClient` - Update socket paths: `/run/hero_proc.sock`, `$HOME/hero/var/sockets/hero_proc_server.sock` - Update env var: `ZINIT_SOCKET` → `HERO_PROC_SOCKET` - Update Cargo.toml snippet: `https://forge.ourworld.tf/lhumina_code/hero_proc.git`, `branch = "development_kristof_ttyd"` - Update "See Also" link to `https://forge.ourworld.tf/lhumina_code/hero_proc` - Scan sibling skills for `zinit_sdk` cross-references and update to `hero_proc_sdk` ## Files to Modify - `/Users/despiegk/hero/code/hero_skills/claude/skills/zinit_sdk/SKILL.md` → renamed to `hero_proc_sdk/SKILL.md` and fully updated - Any sibling skill with `zinit_sdk` in `related_skills:` frontmatter ## Implementation Steps ### Step 1 — Rename directory `git mv .../zinit_sdk .../hero_proc_sdk` ### Step 2 — Update YAML frontmatter New name: `hero_proc_sdk`, update description and trigger phrases ### Step 3 — Update all `use zinit_sdk` imports → `use hero_proc_sdk` ### Step 4 — Replace all `ZinitRPCAPIClient` → `HeroProcRPCAPIClient` ### Step 5 — Remove `ZinitHandle` / `AsyncZinitClient` references ### Step 6 — Update socket paths, env vars, and troubleshooting sections ### Step 7 — Update Cargo.toml installation snippet (repo URL + branch) ### Step 8 — Update "See Also" section ### Step 9 — Scan & update sibling skills referencing `zinit_sdk` ## Acceptance Criteria - [ ] Directory renamed to `hero_proc_sdk/` - [ ] Zero occurrences of `ZinitRPCAPIClient` remain - [ ] Zero occurrences of `use zinit_sdk::` remain - [ ] Zero occurrences of `ZinitHandle` or `AsyncZinitClient` remain - [ ] Cargo.toml snippet uses `lhumina_code/hero_proc.git` + `development_kristof_ttyd` branch - [ ] Socket paths and env var updated to `hero_proc` naming - [ ] "See Also" links to `https://forge.ourworld.tf/lhumina_code/hero_proc` - [ ] Sibling skills updated ## Notes - Keep `"zinit"` as a trigger phrase for backward compatibility (agents asked about old name will find this skill) - `zinit_cmd` skill may also need a parallel rename but is out of scope for this issue - Repo URL changed from `geomind_code/zinit` → `lhumina_code/hero_proc`
despiegk commented 2026-03-18 07:26:57 +00:00
Author
Owner
Copy link

Test Results

  • Status: FAIL
  • Total: 4
  • Passed: 3
  • Failed: 1

Failure Details

Test: harness::tests::test_harness_starts_and_stops

thread 'harness::tests::test_harness_starts_and_stops' panicked at tests/integration/src/harness.rs:385:52:
harness should start: hero_proc_server binary not found. Run `cargo build -p hero_proc_server` first, set HERO_PROC_SERVER_BIN, or use `cargo test` (which builds it automatically via artifact deps)

Root cause: The integration test harness requires the hero_proc_server binary to be present, but it was not found during the test run. This is a test environment setup issue, not a code defect — the binary needs to be built with cargo build -p hero_proc_server before this test can pass.

Passing Tests

  • fixtures::tests::test_dependency_chain_creates_three_services ✓
  • fixtures::tests::test_dependent_service_serializes ✓
  • fixtures::tests::test_minimal_service_serializes ✓

Warnings

  • hero_proc_lib: unused import ActionSpec in db/integration_tests.rs:614
  • hero_proc-integration-tests: unused function shell_escape in fixtures.rs:84
  • hero_proc-integration-tests: unused functions add_loop_service and add_dependent_service in service_management.rs
## Test Results - Status: FAIL - Total: 4 - Passed: 3 - Failed: 1 ### Failure Details **Test:** `harness::tests::test_harness_starts_and_stops` ``` thread 'harness::tests::test_harness_starts_and_stops' panicked at tests/integration/src/harness.rs:385:52: harness should start: hero_proc_server binary not found. Run `cargo build -p hero_proc_server` first, set HERO_PROC_SERVER_BIN, or use `cargo test` (which builds it automatically via artifact deps) ``` **Root cause:** The integration test harness requires the `hero_proc_server` binary to be present, but it was not found during the test run. This is a test environment setup issue, not a code defect — the binary needs to be built with `cargo build -p hero_proc_server` before this test can pass. ### Passing Tests - `fixtures::tests::test_dependency_chain_creates_three_services` ✓ - `fixtures::tests::test_dependent_service_serializes` ✓ - `fixtures::tests::test_minimal_service_serializes` ✓ ### Warnings - `hero_proc_lib`: unused import `ActionSpec` in `db/integration_tests.rs:614` - `hero_proc-integration-tests`: unused function `shell_escape` in `fixtures.rs:84` - `hero_proc-integration-tests`: unused functions `add_loop_service` and `add_dependent_service` in `service_management.rs`
despiegk commented 2026-03-18 07:27:31 +00:00
Author
Owner
Copy link

Implementation Complete

Changes Made

Skill directory renamed:

  • claude/skills/zinit_sdk/ → claude/skills/hero_proc_sdk/ (in hero_skills repo, via git mv)

hero_proc_sdk/SKILL.md — full update:

  • Frontmatter: name changed to hero_proc_sdk, description updated, trigger phrases refreshed (ZinitHandle/AsyncZinitClient removed, hero_proc_sdk/HeroProcRPCAPIClient added, zinit kept for backward compat)
  • All use zinit_sdk::*; → use hero_proc_sdk::*; (10 occurrences)
  • All ZinitRPCAPIClient → HeroProcRPCAPIClient
  • Socket paths: /run/zinit.sock → /run/hero_proc.sock, zinit_server.sock → hero_proc_server.sock
  • Env var: ZINIT_SOCKET → HERO_PROC_SOCKET
  • Cargo.toml snippet now uses https://forge.ourworld.tf/lhumina_code/hero_proc.git, branch = "development_kristof_ttyd"
  • Prose: Zinit SDK → hero_proc SDK, zinit server → hero_proc server, etc.
  • Removed non-existent types ZinitHandle / AsyncZinitClient
  • See Also: now links to https://forge.ourworld.tf/lhumina_code/hero_proc

Sibling skill updated:

  • hero_rpc_server_lifecycle/SKILL.md: cross-reference updated from zinit_sdk → hero_proc_sdk

Test Results

  • 3/4 unit tests passed
  • 1 integration test (test_harness_starts_and_stops) failed due to missing hero_proc_server binary in test environment — pre-existing environment issue, unrelated to skill changes. Build with cargo build -p hero_proc_server to resolve.

Notes

  • zinit kept as a trigger phrase for backward compatibility
  • zinit_cmd skill may also need a parallel rename to hero_proc_cmd — flagged as follow-up
## Implementation Complete ### Changes Made **Skill directory renamed:** - `claude/skills/zinit_sdk/` → `claude/skills/hero_proc_sdk/` (in hero_skills repo, via `git mv`) **`hero_proc_sdk/SKILL.md` — full update:** - Frontmatter: `name` changed to `hero_proc_sdk`, description updated, trigger phrases refreshed (`ZinitHandle`/`AsyncZinitClient` removed, `hero_proc_sdk`/`HeroProcRPCAPIClient` added, `zinit` kept for backward compat) - All `use zinit_sdk::*;` → `use hero_proc_sdk::*;` (10 occurrences) - All `ZinitRPCAPIClient` → `HeroProcRPCAPIClient` - Socket paths: `/run/zinit.sock` → `/run/hero_proc.sock`, `zinit_server.sock` → `hero_proc_server.sock` - Env var: `ZINIT_SOCKET` → `HERO_PROC_SOCKET` - Cargo.toml snippet now uses `https://forge.ourworld.tf/lhumina_code/hero_proc.git`, `branch = "development_kristof_ttyd"` - Prose: `Zinit SDK` → `hero_proc SDK`, `zinit server` → `hero_proc server`, etc. - Removed non-existent types `ZinitHandle` / `AsyncZinitClient` - See Also: now links to `https://forge.ourworld.tf/lhumina_code/hero_proc` **Sibling skill updated:** - `hero_rpc_server_lifecycle/SKILL.md`: cross-reference updated from `zinit_sdk` → `hero_proc_sdk` ### Test Results - 3/4 unit tests passed - 1 integration test (`test_harness_starts_and_stops`) failed due to missing `hero_proc_server` binary in test environment — pre-existing environment issue, unrelated to skill changes. Build with `cargo build -p hero_proc_server` to resolve. ### Notes - `zinit` kept as a trigger phrase for backward compatibility - `zinit_cmd` skill may also need a parallel rename to `hero_proc_cmd` — flagged as follow-up
despiegk commented 2026-03-18 07:28:08 +00:00
Author
Owner
Copy link

Implementation committed in hero_skills repo: 7b5c2cd

Changes: zinit_sdk skill renamed to hero_proc_sdk, all references updated, pinned to development_kristof_ttyd branch.

Implementation committed in hero_skills repo: `7b5c2cd` Changes: zinit_sdk skill renamed to hero_proc_sdk, all references updated, pinned to `development_kristof_ttyd` branch.
Commenting is not possible because the repository is archived.
No Branch/Tag specified
Branches Tags
development
development_kristof_ttyd
main
development_home27
development_dioxus_bootstrap
fix/system-config-startup
development_mik_6_1
development_tty2
development_kristof
v0.4.0
archive/development_tty
v0.1.3
v0.1.2
v0.1.1
v0.1.0
v0.0.1-rc1
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
lhumina_code/hero_proc_archive#3
No description provided.