lhumina_code/hero_proc
1
0
Fork 0
Code Issues 23 Pull requests Projects Releases 1 Packages Wiki Activity Actions

fix(job): propagate spec.tags to Job.tags on job.create #50

Merged
mahmoud merged 1 commit from development_job_tags_propagation into development 2026-04-27 16:44:01 +00:00
Conversation 0 Commits 1 Files changed 1 +1
mahmoud commented 2026-04-27 14:52:54 +00:00
Owner
Copy link

The RPC handler stored the ActionSpec on job.spec (with tags) but never
copied tags onto the top-level Job.tags. As a result JobSummary.tags
returned by job.list was always empty, breaking every caller that
filters or matches by tag — including hero_codescalers' Jobs tab and the
new jobs.cleanup RPC.

One-line fix: set tags: spec.tags.clone() before moving spec into the
struct.

The RPC handler stored the ActionSpec on `job.spec` (with tags) but never copied tags onto the top-level `Job.tags`. As a result `JobSummary.tags` returned by `job.list` was always empty, breaking every caller that filters or matches by tag — including hero_codescalers' Jobs tab and the new `jobs.cleanup` RPC. One-line fix: set `tags: spec.tags.clone()` before moving spec into the struct.
fix(job): propagate spec.tags to Job.tags on job.create
All checks were successful
Tests / test (pull_request) Successful in 3m55s
Details
Build and Test / build (pull_request) Successful in 5m42s
Details
91bb2664c7 
The RPC handler stored the ActionSpec on `job.spec` (with tags) but never
copied tags onto the top-level `Job.tags`. As a result `JobSummary.tags`
returned by `job.list` was always empty, breaking every caller that
filters or matches by tag — including hero_codescalers' Jobs tab and the
new `jobs.cleanup` RPC.

One-line fix: set `tags: spec.tags.clone()` before moving spec into the
struct.
mahmoud merged commit 115f74c035 into development 2026-04-27 16:44:01 +00:00
mahmoud deleted branch development_job_tags_propagation 2026-04-27 16:44:04 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
prio_critical

   
prio_low

   
type_bug

   
type_contact

   
type_issue

   
type_lead

   
type_question

   
type_story

   
type_task
No labels
prio_critical
prio_low
type_bug
type_contact
type_issue
type_lead
type_question
type_story
type_task
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
lhumina_code/hero_proc!50
No description provided.