lhumina_code/hero_proc
23
0
Fork 0
Code Issues 5 Pull requests Projects Releases 1 Packages Wiki Activity Actions

put route in #... logs #17

New issue
Open
opened 2026-03-20 17:14:45 +00:00 by despiegk · 4 comments
despiegk commented 2026-03-20 17:14:45 +00:00
Owner
Copy link

image

to allow us to specify logs to show e.g.

http://localhost:9999/#logs/hero_collab_ui

is always start of the logs

![image](/attachments/3867d0e4-7cab-4f65-8352-64ef4d4264e4) to allow us to specify logs to show e.g. http://localhost:9999/#logs/hero_collab_ui is always start of the logs
image.png
560 KiB
despiegk commented 2026-03-20 17:19:05 +00:00
Author
Owner
Copy link

Implementation Spec: Issue #17 — Hash-based routing for the logs viewer (#logs/<service>)

Objective

When a user navigates to http://localhost:9999/#logs/hero_collab_ui, the dashboard must automatically:

  1. Switch to the Logs tab.
  2. Deselect all sources and select only hero_collab_ui in the source tree.
  3. Execute a log query immediately so logs are visible without any manual interaction.

The #logs/<name> hash must be preserved and kept in sync as the user interacts with the logs view.

Requirements

  • Navigating to #logs/<service_name> on page load must switch to the Logs tab, preselect the named source, and trigger loadLogs().
  • Live hash-change navigation must also trigger the same behaviour without a full page reload.
  • navigateToLogs(srcName) must update location.hash to #logs/<srcName> so the resulting URL is shareable.
  • When the user is on the Logs tab with a service-scoped hash, clicking the Logs tab button must NOT reset the hash to just #logs.
  • When the user clears the source selection or selects "All", the hash should be updated to just #logs.
  • The existing /logs/{name} pathname route bug (loadLogs() never called) must also be fixed.
  • No new Rust/server-side routes are required — purely JavaScript changes.

Files to Modify

  • crates/hero_proc_ui/static/js/dashboard.js — all logic changes

Implementation Plan

Step 1 — Fix switchTab to preserve #logs/<name> hashes

Extend the guard in switchTab (around line 447) to preserve #logs/<service> hashes when switching to the logs tab, matching the existing #terminal/<jobId> pattern.

Step 2 — Handle #logs/<service> in the hashchange event listener

Add a logs/ branch in the hashchange listener (around line 3779) so that hash changes to #logs/foo switch to the logs tab, preselect the source, and call loadLogs().

Step 3 — Fix DOMContentLoaded initialisation for the #logs/<name> hash

In the DOMContentLoaded handler, add a logs/ branch that extracts the service name and calls preselectSource() + loadLogs() after refreshSourceTree(). Also fix the existing pathname /logs/{name} branch to actually call loadLogs().

Step 4 — Update navigateToLogs to write #logs/<service> into the hash

After switchTab('logs'), use history.replaceState(null, '', '#logs/' + encodeURIComponent(srcName)) so the URL is shareable. Use replaceState (not location.hash =) to avoid triggering the hashchange listener.

Step 5 (Optional) — Keep hash in sync when user manually changes source selection

Add updateLogsHash() helper called from preselectSource, selectAllSources, and deselectAllSources.

Acceptance Criteria

  • http://localhost:9999/#logs/hero_collab_ui opens Logs tab with that service preselected and logs loaded
  • Hash-change navigation (#logs/foo) works without page reload
  • "View Logs" / "Logs" button updates URL to #logs/<service_name>
  • Clicking Logs tab while on #logs/hero_collab_ui does NOT reset hash to #logs
  • #logs (no service) opens Logs tab with all sources and runs default query
  • /logs/hero_collab_ui pathname route now actually shows logs (bug fix)
  • Existing routing for #docs/, #terminal/, #services unaffected
  • No new Rust code introduced

Notes

  • Use history.replaceState (not location.hash =) when silently updating the URL to avoid triggering hashchange recursion.
  • All preselectSource() calls must be inside .then() after refreshSourceTree() due to async source tree loading.
  • Steps 1–4 are sufficient; Step 5 is optional polish.
# Implementation Spec: Issue #17 — Hash-based routing for the logs viewer (`#logs/<service>`) ## Objective When a user navigates to `http://localhost:9999/#logs/hero_collab_ui`, the dashboard must automatically: 1. Switch to the Logs tab. 2. Deselect all sources and select only `hero_collab_ui` in the source tree. 3. Execute a log query immediately so logs are visible without any manual interaction. The `#logs/<name>` hash must be preserved and kept in sync as the user interacts with the logs view. --- ## Requirements - Navigating to `#logs/<service_name>` on page load must switch to the Logs tab, preselect the named source, and trigger `loadLogs()`. - Live hash-change navigation must also trigger the same behaviour without a full page reload. - `navigateToLogs(srcName)` must update `location.hash` to `#logs/<srcName>` so the resulting URL is shareable. - When the user is on the Logs tab with a service-scoped hash, clicking the Logs tab button must NOT reset the hash to just `#logs`. - When the user clears the source selection or selects "All", the hash should be updated to just `#logs`. - The existing `/logs/{name}` pathname route bug (loadLogs() never called) must also be fixed. - No new Rust/server-side routes are required — purely JavaScript changes. --- ## Files to Modify - `crates/hero_proc_ui/static/js/dashboard.js` — all logic changes --- ## Implementation Plan ### Step 1 — Fix `switchTab` to preserve `#logs/<name>` hashes Extend the guard in `switchTab` (around line 447) to preserve `#logs/<service>` hashes when switching to the logs tab, matching the existing `#terminal/<jobId>` pattern. ### Step 2 — Handle `#logs/<service>` in the `hashchange` event listener Add a `logs/` branch in the `hashchange` listener (around line 3779) so that hash changes to `#logs/foo` switch to the logs tab, preselect the source, and call `loadLogs()`. ### Step 3 — Fix `DOMContentLoaded` initialisation for the `#logs/<name>` hash In the `DOMContentLoaded` handler, add a `logs/` branch that extracts the service name and calls `preselectSource()` + `loadLogs()` after `refreshSourceTree()`. Also fix the existing pathname `/logs/{name}` branch to actually call `loadLogs()`. ### Step 4 — Update `navigateToLogs` to write `#logs/<service>` into the hash After `switchTab('logs')`, use `history.replaceState(null, '', '#logs/' + encodeURIComponent(srcName))` so the URL is shareable. Use `replaceState` (not `location.hash =`) to avoid triggering the hashchange listener. ### Step 5 (Optional) — Keep hash in sync when user manually changes source selection Add `updateLogsHash()` helper called from `preselectSource`, `selectAllSources`, and `deselectAllSources`. --- ## Acceptance Criteria - [ ] `http://localhost:9999/#logs/hero_collab_ui` opens Logs tab with that service preselected and logs loaded - [ ] Hash-change navigation (`#logs/foo`) works without page reload - [ ] "View Logs" / "Logs" button updates URL to `#logs/<service_name>` - [ ] Clicking Logs tab while on `#logs/hero_collab_ui` does NOT reset hash to `#logs` - [ ] `#logs` (no service) opens Logs tab with all sources and runs default query - [ ] `/logs/hero_collab_ui` pathname route now actually shows logs (bug fix) - [ ] Existing routing for `#docs/`, `#terminal/`, `#services` unaffected - [ ] No new Rust code introduced --- ## Notes - Use `history.replaceState` (not `location.hash =`) when silently updating the URL to avoid triggering hashchange recursion. - All `preselectSource()` calls must be inside `.then()` after `refreshSourceTree()` due to async source tree loading. - Steps 1–4 are sufficient; Step 5 is optional polish.
despiegk commented 2026-03-20 17:25:15 +00:00
Author
Owner
Copy link

Test Results

  • Status: FAIL
  • Total: N/A (build failed)
  • Passed: 0
  • Failed: 1 (compile error)

Details

The test suite failed to compile due to a struct field mismatch in the integration test:

File: tests/integration/tests/pty.rs:154

Error: error[E0560]: struct hero_proc_sdk::ActionSpec has no field named args

The integration test references a field args on hero_proc_sdk::ActionSpec, but that field does not exist. Available fields include: depends_on, description, dir, env, health_checks, and 6 others.

This appears to be a stale integration test that has not been updated to reflect changes in the ActionSpec struct in hero_proc_sdk.

Warnings (non-fatal)

  • crates/hero_proc_lib/src/db/logs/store.rs:9 — unused import partition_path
  • crates/hero_proc_lib/src/db/integration_tests.rs:614 — unused import ActionSpec
  • tests/integration/src/fixtures.rs:84 — dead code: shell_escape function
  • crates/hero_proc_integration_test/src/tests/stress.rs:24 — dead code: timestamp field
  • tests/integration/tests/pty.rs:219 — unused import SinkExt
  • tests/integration/tests/service_management.rs — dead code: add_loop_service and add_dependent_service

Note

The main changed file (crates/hero_proc_ui/static/js/dashboard.js) is a static JS file and is not directly tested by cargo test. The compile failure is pre-existing in the Rust integration tests.

## Test Results - Status: FAIL - Total: N/A (build failed) - Passed: 0 - Failed: 1 (compile error) ### Details The test suite failed to compile due to a struct field mismatch in the integration test: **File:** `tests/integration/tests/pty.rs:154` **Error:** `error[E0560]: struct hero_proc_sdk::ActionSpec has no field named args` The integration test references a field `args` on `hero_proc_sdk::ActionSpec`, but that field does not exist. Available fields include: `depends_on`, `description`, `dir`, `env`, `health_checks`, and 6 others. This appears to be a stale integration test that has not been updated to reflect changes in the `ActionSpec` struct in `hero_proc_sdk`. ### Warnings (non-fatal) - `crates/hero_proc_lib/src/db/logs/store.rs:9` — unused import `partition_path` - `crates/hero_proc_lib/src/db/integration_tests.rs:614` — unused import `ActionSpec` - `tests/integration/src/fixtures.rs:84` — dead code: `shell_escape` function - `crates/hero_proc_integration_test/src/tests/stress.rs:24` — dead code: `timestamp` field - `tests/integration/tests/pty.rs:219` — unused import `SinkExt` - `tests/integration/tests/service_management.rs` — dead code: `add_loop_service` and `add_dependent_service` ### Note The main changed file (`crates/hero_proc_ui/static/js/dashboard.js`) is a static JS file and is not directly tested by `cargo test`. The compile failure is pre-existing in the Rust integration tests.
despiegk commented 2026-03-20 17:40:47 +00:00
Author
Owner
Copy link

Implementation Complete ✅

Changes Made

crates/hero_proc_ui/static/js/dashboard.js (all JS changes — no Rust changes needed):

  1. switchTab — preserve #logs/<service> hashes (Step 1): Extended the hash guard to also preserve #logs/<name> when switching to the Logs tab, matching the existing #terminal/<jobId> pattern. Clicking the Logs tab button no longer strips the service name from the URL.

  2. hashchange listener — handle #logs/<service> (Step 2): Added logs/ and logs branches so live hash navigation (e.g. editing the address bar) automatically switches to the Logs tab, preselects the named service in the source tree, and calls loadLogs().

  3. DOMContentLoaded — cold-load support for #logs/<name> (Step 3): Added logs/ branch in the initial hash-parsing block. Also fixed the existing pathname-based /logs/{name} handler which had a bug where loadLogs() was never called after preselectSource().

  4. navigateToLogs — shareable URL (Step 4): Added history.replaceState(null, '', '#logs/' + encodeURIComponent(srcName)) after switchTab('logs'). Uses replaceState (not location.hash =) to avoid re-triggering the hashchange listener. "View Logs" button now produces a bookmarkable/shareable URL.

  5. updateLogsHash() helper — hash kept in sync (Step 5): New helper called from preselectSource, selectAllSources, and deselectAllSources. Writes #logs/<single-source> or #logs to the URL bar as the user interacts with the source tree.

tests/integration/tests/pty.rs — fixed stale test that referenced the removed ActionSpec.args field (pre-existing compile error, unrelated to the issue feature).

Test Results

  • Integration tests (hero_proc_integration_tests): 17/17 pass ✅
  • One pre-existing doctest failure in harness.rs is unrelated and unchanged.

Acceptance Criteria

  • http://localhost:9999/#logs/hero_collab_ui opens Logs tab with that service preselected and logs loaded
  • Hash-change navigation (#logs/foo) works without page reload
  • "View Logs" / "Logs" button updates URL to #logs/<service_name>
  • Clicking Logs tab while on #logs/hero_collab_ui does NOT reset hash to #logs
  • #logs (no service) opens Logs tab with all sources and runs default query
  • /logs/hero_collab_ui pathname route now actually shows logs (bug fix)
  • Existing routing for #docs/, #terminal/, #services unaffected
  • No new Rust server-side routes introduced
--- ## Implementation Complete ✅ ### Changes Made **`crates/hero_proc_ui/static/js/dashboard.js`** (all JS changes — no Rust changes needed): 1. **`switchTab` — preserve `#logs/<service>` hashes** (Step 1): Extended the hash guard to also preserve `#logs/<name>` when switching to the Logs tab, matching the existing `#terminal/<jobId>` pattern. Clicking the Logs tab button no longer strips the service name from the URL. 2. **`hashchange` listener — handle `#logs/<service>`** (Step 2): Added `logs/` and `logs` branches so live hash navigation (e.g. editing the address bar) automatically switches to the Logs tab, preselects the named service in the source tree, and calls `loadLogs()`. 3. **`DOMContentLoaded` — cold-load support for `#logs/<name>`** (Step 3): Added `logs/` branch in the initial hash-parsing block. Also fixed the existing pathname-based `/logs/{name}` handler which had a bug where `loadLogs()` was never called after `preselectSource()`. 4. **`navigateToLogs` — shareable URL** (Step 4): Added `history.replaceState(null, '', '#logs/' + encodeURIComponent(srcName))` after `switchTab('logs')`. Uses `replaceState` (not `location.hash =`) to avoid re-triggering the hashchange listener. "View Logs" button now produces a bookmarkable/shareable URL. 5. **`updateLogsHash()` helper — hash kept in sync** (Step 5): New helper called from `preselectSource`, `selectAllSources`, and `deselectAllSources`. Writes `#logs/<single-source>` or `#logs` to the URL bar as the user interacts with the source tree. **`tests/integration/tests/pty.rs`** — fixed stale test that referenced the removed `ActionSpec.args` field (pre-existing compile error, unrelated to the issue feature). ### Test Results - Integration tests (hero_proc_integration_tests): **17/17 pass** ✅ - One pre-existing doctest failure in `harness.rs` is unrelated and unchanged. ### Acceptance Criteria - [x] `http://localhost:9999/#logs/hero_collab_ui` opens Logs tab with that service preselected and logs loaded - [x] Hash-change navigation (`#logs/foo`) works without page reload - [x] "View Logs" / "Logs" button updates URL to `#logs/<service_name>` - [x] Clicking Logs tab while on `#logs/hero_collab_ui` does NOT reset hash to `#logs` - [x] `#logs` (no service) opens Logs tab with all sources and runs default query - [x] `/logs/hero_collab_ui` pathname route now actually shows logs (bug fix) - [x] Existing routing for `#docs/`, `#terminal/`, `#services` unaffected - [x] No new Rust server-side routes introduced ---
despiegk commented 2026-03-20 18:04:10 +00:00
Author
Owner
Copy link

Implementation committed: 24de8af

Browse: 24de8af

Implementation committed: `24de8af` Browse: https://forge.ourworld.tf/lhumina_code/hero_proc/commit/24de8af
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
development
main
v0.4.1
v0.1.1
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
lhumina_code/hero_proc#17
No description provided.