hero_osis: drop hero_osis_seed binary + --seed-dir startup hook (hero_rpc#117) #65
No reviewers
Labels
No labels
prio_critical
prio_low
type_bug
type_contact
type_issue
type_lead
type_question
type_story
type_task
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
lhumina_code/hero_osis!65
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "issue-117-osis-cleanup"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
This is the hero_osis side of hero_rpc#117 — the typed-SDK seeder (
seed::{blank, random, from_dir}emitted into each<service>_sdkcrate) is now the only blessed seeding path. The standalonehero_osis_seedbinary and the server's--seed-dirstartup hook both bypassed the typed SDK and seeded via raw JSON-RPC; this PR removes both.Deletions
crates/hero_osis_server/src/bin/seed.rs— the standalone seeder binarydocs/SEEDING.md— the TOML format reference moves into the SDKseed::from_dirdoc comments[[binaries]] hero_osis_seedentry fromcrates/hero_osis_server/service.toml[[bin]] hero_osis_seedfromcrates/hero_osis_server/Cargo.toml(and its.hero_builder_backupsnapshot)hero_osis_seedfromscripts/{run,build,install}.rhaiHERO_OSIS_SEED_DIRenv-var docs fromREADME.md+docs/SOCKETS.md--seed-dirfromtests/e2e/run.shlaunch command (with a marker comment pointing at hero_rpc#117)GETTING_STARTED.mdseeding walkthrough replaced with a TODO pointing at hero_rpc#117 / hero_rpc#115Rewrites
tests/e2e_seed.rsis now a single#[ignore]-tagged stub. Seed E2E coverage belongs in the workspace-roottests/crate that hero_rpc#115 will land, exercising the typed SDK seeder.Not touched (on purpose)
crates/hero_osis_server/src/bin/hero_osis.rsis regenerated from hero_rpc's generator on every build. Its--seed-dirplumbing follows the upstream template and will fall away automatically when the matching hero_rpc#117 patch lands and we bump the hero_rpc branch ref.Test plan
cargo check --workspacepasses locallycargo test --workspace --no-runcompiles locallygrep -rn 'hero_osis_seed\|--seed-dir' crates scripts docs tests Cargo.toml *.mdreturns only the explanatory marker lines listed above (zero functional references)hero_osis.rsdrops thecli.seed_dir/DomainService.seed_dirreferences on its ownRefs: hero_rpc#117, hero_rpc#115
The typed-SDK seeder (hero_rpc#117 — seed::{blank, random, from_dir} emitted into each <service>_sdk crate) is now the only blessed seeding path. The standalone hero_osis_seed binary and the server's --seed-dir startup hook both bypassed the typed SDK and seeded via raw JSON-RPC; this commit removes both. - delete crates/hero_osis_server/src/bin/seed.rs - drop [[binaries]] hero_osis_seed entry from service.toml - drop [[bin]] hero_osis_seed from Cargo.toml (and hero_builder backup) - remove HERO_OSIS_SEED_DIR / SEEDING docs from README + SOCKETS - delete docs/SEEDING.md (TOML format reference moves into the SDK seed::from_dir doc comments) - replace the GETTING_STARTED.md seeding walkthrough with a TODO pointing at hero_rpc#117 / hero_rpc#115 - drop hero_osis_seed from scripts/{run,build,install}.rhai - drop --seed-dir from tests/e2e/run.sh launch command and leave a comment-out marker pointing at hero_rpc#117 - mark tests/e2e_seed.rs as #[ignore] pending hero_rpc#115's workspace-root tests crate The server main binary (crates/hero_osis_server/src/bin/hero_osis.rs) is regenerated from hero_rpc's generator on every build; its --seed-dir plumbing follows the upstream template and will fall away when the matching hero_rpc#117 patch lands. Refs: hero_rpc#117