fix missing communication, media, and job domain registrations #11

Closed

mik-tf wants to merge 0 commits from development_fix_missing_domains into development

pull from: development_fix_missing_domains

merge into: lhumina_code:development

lhumina_code:development

lhumina_code:development_mik

lhumina_code:development_kristof

lhumina_code:development_mock_data

lhumina_code:main

Conversation 0 Commits - Files changed - +1 -1

mik-tf commented 2026-02-28 19:42:36 +00:00

Owner

Copy link

Summary

• Add communication to all-domains feature in hero_osis_openrpc/Cargo.toml
• Add media and job domain registration blocks in main.rs
• Add production seed data (data/seed/root/identity/user_admin.toml) for default admin user

Closes #10

Test plan

• Build hero_osis_openrpc with all-domains feature
• Verify communication, media, and job appear in startup logs
• Test RPC calls to communication.message.list, media.album.list, job.task.list
• Verify admin user is seeded from data/seed/ directory

🤖 Generated with Claude Code

## Summary - Add `communication` to `all-domains` feature in `hero_osis_openrpc/Cargo.toml` - Add `media` and `job` domain registration blocks in `main.rs` - Add production seed data (`data/seed/root/identity/user_admin.toml`) for default admin user Closes #10 ## Test plan - [ ] Build hero_osis_openrpc with `all-domains` feature - [ ] Verify `communication`, `media`, and `job` appear in startup logs - [ ] Test RPC calls to `communication.message.list`, `media.album.list`, `job.task.list` - [ ] Verify admin user is seeded from `data/seed/` directory 🤖 Generated with [Claude Code](https://claude.com/claude-code)

mik-tf added 1 commit 2026-02-28 19:42:36 +00:00

fix: register missing communication, media, and job domains ... 378e880efb

- Add "communication" to all-domains feature in hero_osis_openrpc Cargo.toml
  (was present in core hero_osis but missing from openrpc server)
- Add media and job domain registration blocks in main.rs
  (modules existed but were never instantiated/registered)
- Add production seed data (data/seed/) with default admin user

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

mik-tf added 1 commit 2026-03-01 04:11:54 +00:00

fix: add livekit-api as optional dep for communication feature ... f777d1cc0e

The communication domain's rpc.rs uses livekit_api::access_token
directly but the crate wasn't listed as a dependency. Gate it on
the communication feature flag.

mik-tf added 1 commit 2026-03-02 02:42:17 +00:00

Merge remote-tracking branch 'origin/development' into development_fix_missing_domains 046461b63f

mik-tf added 1 commit 2026-03-02 16:58:59 +00:00

fix: update hero_rpc to pick up application_error dispatch fix ... 7c1bac67bf

hero_rpc PR #2 merged: service method errors (wrong password, expired
token, etc.) now return code -32000 with the actual message instead of
-32601 "Method not found". This makes auth failures readable on the
login screen.

Also updates herolib to latest development.

mik-tf referenced this pull request from lhumina_code/hero_services 2026-03-02 17:43:38 +00:00

Production Hardening: Auth Security, UX, Tests, Docs #44

mik-tf added 1 commit 2026-03-02 18:17:41 +00:00

feat: auth security hardening — CSPRNG, Argon2, username binding, rate limiting, tests ... 8f446cab21

Security fixes in AuthServiceHandler (identity/rpc.rs):
- Replace DefaultHasher with OsRng for cryptographically secure session tokens and challenges
- Add verify_password() supporting argon2id and legacy SHA-256 (migration path)
- Add hash_password() using argon2id for new password storage
- Fix login() to match user by username first, then verify password — prevents cross-user password hash collisions
- Add per-username rate limiting: 5 failures per 5-minute window

Fix broken super::server::* import in all 17 auto-generated tests.rs files → super::*

Auth tests (identity/tests.rs):
- test_auth_happy_path: get_challenge → login → validate_session → logout
- test_auth_wrong_password: must return InvalidSignature (regression guard against -32601)
- test_auth_unknown_user: unknown username must fail
- test_auth_challenge_replay: second use of same challenge must fail with ChallengeFailed
- test_auth_rate_limiting: 6th attempt must be rejected even with correct password
- test_auth_session_tokens_unique: 10 consecutive sessions must all have unique tokens
- test_auth_argon2_password: argon2-stored password verifies correctly

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

mik-tf changed title from WIP: fix missing communication, media, and job domain registrations to fix missing communication, media, and job domain registrations 2026-03-02 19:30:55 +00:00

mik-tf added 1 commit 2026-03-04 18:43:01 +00:00

chore: bump rust-version to 1.93 per hero_ecosystem standard ... ff6c0b55cf

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

mik-tf closed this pull request 2026-03-05 00:21:21 +00:00

Some checks failed

Hide all checks

Build and Test / build (pull_request) Failing after 15s

Details

Pull request closed

This pull request cannot be reopened because the branch was deleted.

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels

No items

No labels

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

lhumina_code/hero_osis!11

No description provided.