fix(islands): wire books, compute, voice to archipelago embeds #75

Merged

mahmoud merged 2 commits from development_fix_island_embeds into development

2026-04-20 08:19:40 +00:00

salmaelsoly commented

2026-04-19 15:37:49 +00:00

Member

Summary

Replaces the three remaining ExternalServiceIframe fallbacks in island_content.rs with the real archipelago embed components (BooksApp, ComputeApp, VoiceApp). Those components construct the iframe src via IslandContext::with_window_id(...) and carry the per-island theme/auth sync wiring that the generic fallback lacks.

Closes #74

Changes

crates/hero_os_app/src/island_content.rs
- Added BooksApp, ComputeApp, VoiceApp cfg-gated re-exports alongside the existing embed imports.
- Books arm: replaced the unconditional iframe with BooksApp (feature island-books) and kept the native HeroBooksApp arm under island-books-native.
- Compute arm: split the previously unconditional iframe into ComputeApp (feature island-compute) and an iframe fallback for the defensive "neither feature" case.
- Voice arm: replaced the iframe with VoiceApp (feature island-voice), keeping the existing native arm.
- Dropped stale comments that said the books UI was served as a standalone iframe.
crates/hero_os_app/Cargo.toml
- Declared island-voice = ["dep:hero_archipelagos_voice"].
- Added hero_archipelagos_voice as an optional git dep on branch = "development" (mirroring the other hero_archipelagos_* crate declarations).
- Added island-books and island-voice to the default web feature list so the new arms are selected in the default web build.
Cargo.lock — regenerated to include the new archipelago crates (books, compute, voice) and their transitive deps.

Test Plan

cargo check -p hero_os_app --no-default-features --features web passes (13 warnings, all pre-existing).
cargo check -p hero_os_app --no-default-features --features web-native passes (15 warnings, all pre-existing).
In a running hero_os web build, opening the books island renders the .books-island wrapper from BooksApp rather than .embed-container-plain. Same for compute (.compute-embed.embed-container) and voice (.voice-embed / .voice-island per VoiceApp).
The iframe src for each of the three islands contains hero_window_id=<id> when a window_id is provided (verified by inspecting the src attribute in the devtools inspector).

## Summary Replaces the three remaining `ExternalServiceIframe` fallbacks in `island_content.rs` with the real archipelago embed components (`BooksApp`, `ComputeApp`, `VoiceApp`). Those components construct the iframe `src` via `IslandContext::with_window_id(...)` and carry the per-island theme/auth sync wiring that the generic fallback lacks. ## Related Issue Closes https://forge.ourworld.tf/lhumina_code/hero_os/issues/74 ## Changes - `crates/hero_os_app/src/island_content.rs` - Added `BooksApp`, `ComputeApp`, `VoiceApp` cfg-gated re-exports alongside the existing embed imports. - Books arm: replaced the unconditional iframe with `BooksApp` (feature `island-books`) and kept the native `HeroBooksApp` arm under `island-books-native`. - Compute arm: split the previously unconditional iframe into `ComputeApp` (feature `island-compute`) and an iframe fallback for the defensive "neither feature" case. - Voice arm: replaced the iframe with `VoiceApp` (feature `island-voice`), keeping the existing native arm. - Dropped stale comments that said the books UI was served as a standalone iframe. - `crates/hero_os_app/Cargo.toml` - Declared `island-voice = ["dep:hero_archipelagos_voice"]`. - Added `hero_archipelagos_voice` as an optional git dep on `branch = "development"` (mirroring the other `hero_archipelagos_*` crate declarations). - Added `island-books` and `island-voice` to the default `web` feature list so the new arms are selected in the default web build. - `Cargo.lock` — regenerated to include the new archipelago crates (`books`, `compute`, `voice`) and their transitive deps. ## Test Plan - [x] `cargo check -p hero_os_app --no-default-features --features web` passes (13 warnings, all pre-existing). - [x] `cargo check -p hero_os_app --no-default-features --features web-native` passes (15 warnings, all pre-existing). - [ ] In a running hero_os web build, opening the `books` island renders the `.books-island` wrapper from `BooksApp` rather than `.embed-container-plain`. Same for `compute` (`.compute-embed.embed-container`) and `voice` (`.voice-embed` / `.voice-island` per `VoiceApp`). - [ ] The iframe `src` for each of the three islands contains `hero_window_id=<id>` when a window_id is provided (verified by inspecting the `src` attribute in the devtools inspector).

salmaelsoly added 1 commit

2026-04-19 15:37:49 +00:00

fix(islands): wire books, compute, voice to archipelago embeds

Build and Test / test (pull_request) Failing after 36s

Details

77eaed907d

Swap the three remaining ExternalServiceIframe fallbacks for their
hero_archipelagos embed components (BooksApp, ComputeApp, VoiceApp)
so that per-island theme sync, window_id, and hero_router URL
resolution work correctly.

- island-books / island-voice added to the default web feature set
- island-voice feature declared (dep:hero_archipelagos_voice)
- hero_archipelagos_voice added as an optional git dep alongside
  books/compute

#74