lhumina_code/hero_os
5
0
Fork 0
Code Issues 30 Pull requests Projects 1 Releases Packages Wiki Activity Actions

fix(os): point inspector island at /hero_router/ui/ #119

Merged
zaelgohary merged 1 commit from development_fix_inspector_url into development 2026-04-30 11:33:05 +00:00
Conversation 0 Commits 1 Files changed 1 +1 -1
zaelgohary commented 2026-04-30 10:46:30 +00:00
Member
Copy link

Summary

Inspector island iframe was hitting /hero_router/ which returns 404 — that path was never a real route, it relied on the now-removed trailing-slash 301 redirect. Use /hero_router/ui/ (the ui.sock proxy path) so relative <link href="css/..."> URLs resolve correctly.

Related Issue

Part of #121 (normalize all island_url entries to /hero_/ui/). Depends on hero_router #80.

Changes

  • Inspector island URL: /hero_router/ → /hero_router/ui/.

Test Results

cargo check, fmt, test pass. /hero_router/ui/css/bootstrap.min.css returns 200.

## Summary Inspector island iframe was hitting `/hero_router/` which returns 404 — that path was never a real route, it relied on the now-removed trailing-slash 301 redirect. Use `/hero_router/ui/` (the ui.sock proxy path) so relative `<link href="css/...">` URLs resolve correctly. ## Related Issue Part of #121 (normalize all island_url entries to /hero_<svc>/ui/). Depends on hero_router #80. ## Changes - Inspector island URL: `/hero_router/` → `/hero_router/ui/`. ## Test Results cargo check, fmt, test pass. /hero_router/ui/css/bootstrap.min.css returns 200.
fix(os): point inspector island at /hero_router/ui/ so dashboard CSS resolves
All checks were successful
Build and Test / build (pull_request) Successful in 2m53s
Details
8b449d4975 
Inspector iframe was loaded at /hero_router/ which 404s. Use the ui.sock
proxy path so relative <link href="css/..."> URLs resolve correctly.
zaelgohary merged commit 6246b504d4 into development 2026-04-30 11:33:05 +00:00
zaelgohary deleted branch development_fix_inspector_url 2026-04-30 11:33:05 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
prio_critical

   
prio_low

   
type_bug

   
type_contact

   
type_issue

   
type_lead

   
type_question

   
type_story

   
type_task
No labels
prio_critical
prio_low
type_bug
type_contact
type_issue
type_lead
type_question
type_story
type_task
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
zaelgohary
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
lhumina_code/hero_os!119
No description provided.