build: honor CARGO_TARGET_DIR and DX_ENV in remaining Makefile targets #106
No reviewers
Labels
No labels
prio_critical
prio_low
type_bug
type_contact
type_issue
type_lead
type_question
type_story
type_task
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
lhumina_code/hero_os!106
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "fix/makefile-target-dir-and-dx-env"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Two follow-ups to existing build-system patterns the Makefile already
declared but didn't apply consistently:
install / installdev: cp lines hardcoded
target/{release,debug}/...instead of using the
CARGO_TARGET_DIR ?= targetvariable alreadydefined at line 17 (and used by the WASM_*_OUTPUT paths). With
Hero's standard
CARGO_TARGET_DIR=~/hero/build/cargo, cargo builtinto the override path while cp still looked under ./target and
failed with "No such file or directory". No behavior change when
CARGO_TARGET_DIR isn't set.
web / dev / desktop: missed prepending
$(DX_ENV)(which clearsRUSTC_WRAPPER so sccache stops treating dx as the compiler — see
2b97cdf). Same sccache "Compiler not supported" failure that2b97cdffixed forbuild/build-wasmwas hitting the dev-servertargets. No behavior change when RUSTC_WRAPPER isn't set.
Co-Authored-By: Claude Opus 4.7 (1M context) noreply@anthropic.com
Two follow-ups to existing build-system patterns the Makefile already declared but didn't apply consistently: 1. install / installdev: cp lines hardcoded `target/{release,debug}/...` instead of using the `CARGO_TARGET_DIR ?= target` variable already defined at line 17 (and used by the WASM_*_OUTPUT paths). With Hero's standard `CARGO_TARGET_DIR=~/hero/build/cargo`, cargo built into the override path while cp still looked under ./target and failed with "No such file or directory". No behavior change when CARGO_TARGET_DIR isn't set. 2. web / dev / desktop: missed prepending `$(DX_ENV)` (which clears RUSTC_WRAPPER so sccache stops treating dx as the compiler — see2b97cdf). Same sccache "Compiler not supported" failure that2b97cdffixed for `build` / `build-wasm` was hitting the dev-server targets. No behavior change when RUSTC_WRAPPER isn't set. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>