lhumina_code/hero_os
5
0
Fork 0
Code Issues 30 Pull requests Projects 1 Releases Packages Wiki Activity Actions

fix(loader): route island WASMs through hero_router #103

Merged
zaelgohary merged 1 commit from development_fix_island_js_url_prefix into development 2026-04-29 11:21:14 +00:00
Conversation 0 Commits 1 Files changed 1 +1 -1
zaelgohary commented 2026-04-29 11:05:20 +00:00
Member
Copy link

Summary

Dynamic island loader fetched /islands/{id}/... at root, but hero_router only forwards /hero_os/ui/* to hero_os_ui. Prepended the OS base path so the request reaches the right backend.

Related Issue

Closes #44

Changes

  • Pointed island JS URL at /hero_os/ui/islands/...

Test Results

playwright trace: services WASM now loads (200 OK); secondary backend 404s are separate deployment issues.

services island showing WASM 404 before fix

## Summary Dynamic island loader fetched `/islands/{id}/...` at root, but hero_router only forwards `/hero_os/ui/*` to hero_os_ui. Prepended the OS base path so the request reaches the right backend. ## Related Issue Closes https://forge.ourworld.tf/lhumina_code/hero_os/issues/44 ## Changes - Pointed island JS URL at /hero_os/ui/islands/... ## Test Results playwright trace: services WASM now loads (200 OK); secondary backend 404s are separate deployment issues. ![services island showing WASM 404 before fix](https://forge.ourworld.tf/attachments/84135cf3-fbfb-436c-89a0-b54ef311f387)
services-island-before.png
68 KiB
fix(loader): prefix island JS URLs with /hero_os/ui so they route through hero_router
All checks were successful
Build and Test / build (pull_request) Successful in 4m20s
Details
28e53edea5
zaelgohary merged commit b1db0ada3f into development 2026-04-29 11:21:14 +00:00
zaelgohary deleted branch development_fix_island_js_url_prefix 2026-04-29 11:21:15 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
prio_critical

   
prio_low

   
type_bug

   
type_contact

   
type_issue

   
type_lead

   
type_question

   
type_story

   
type_task
No labels
prio_critical
prio_low
type_bug
type_contact
type_issue
type_lead
type_question
type_story
type_task
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
zaelgohary
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
lhumina_code/hero_os!103
No description provided.