lhumina_code/hero_logic
1
0
Fork 0
Code Issues 17 Pull requests 1 Projects Releases 1 Packages Wiki Activity Actions

fix(ui): revert workflow_editor.html island injection #37

Merged
timur merged 1 commit from fix/revert-workflow-editor-island into development 2026-05-14 11:16:16 +00:00
Conversation 0 Commits 1 Files changed 1 +2 -382
timur commented 2026-05-14 11:09:52 +00:00
Owner
Copy link

PR #36 injected the island CSS/HTML/JS directly into workflow_editor.html. The injection broke the layout for non-overlay sessions — opening /workflows/{sid} rendered only the header.

Reverts the HTML template to its pre-#32 layout (the state the user had working). Run redirect goes back to /workflows/{wf}/edit?play={sid} (embedded overlay view, same UX as before all the island work). /plays/{sid} still redirects there.

The bottom-bar pause/resume feature is gone from the editor view for now. I'll re-add it via a non-conflicting approach in a follow-up.

382 deletions, 4 insertions.

PR #36 injected the island CSS/HTML/JS directly into workflow_editor.html. The injection broke the layout for non-overlay sessions — opening /workflows/{sid} rendered only the header. Reverts the HTML template to its pre-#32 layout (the state the user had working). Run redirect goes back to /workflows/{wf}/edit?play={sid} (embedded overlay view, same UX as before all the island work). /plays/{sid} still redirects there. The bottom-bar pause/resume feature is gone from the editor view for now. I'll re-add it via a non-conflicting approach in a follow-up. 382 deletions, 4 insertions.
Reverts the two routing changes #35 introduced and puts the
pause/resume island where it actually belongs — embedded in the
workflow editor view alongside the live span tree.

Why:
- The dedicated /plays/{sid} detail page I built in #32 broke the
  existing UX: users opened a play and saw a different page than
  the workflow editor they came from. They asked for an ADDITION,
  not a separate view.
- Run now redirects back to /workflows/{wf}/edit?play={sid} (the
  pre-#32 behavior) and /plays/{sid} redirects there too.
- The bottom-bar island (Logs / Pending resumes / Events tabs +
  resizable + collapsible + localStorage state) is now rendered
  inside workflow_editor.html and only appears when an overlay
  play is active (window.OVERLAY_PLAY_SID set).
- Hooks into the existing pollOverlay() loop instead of running a
  second polling cycle.

The dedicated play_detail.html page still exists for direct
navigation but is no longer the canonical Run target.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
#36 added a bottom-bar island directly into workflow_editor.html.
The CSS + HTML + JS injection broke the existing editor layout for
non-overlay sessions: opening any /workflows/{sid} page (no
?play=) rendered only the header — every other panel (toolbar,
sidebar, code, graph) disappeared.

Reverts workflow_editor.html to its pre-#32 layout (which the user
had working) and changes the Run redirect back to the embedded
overlay view (/workflows/{wf}/edit?play={sid}). The /plays/{sid}
route still redirects there.

What remains:
- play_detail.html (the dedicated detail page from #32) is still
  reachable for direct navigation but isn't the Run target.
- The pause/resume bottom-bar feature is not in the workflow editor
  view right now — I'll re-add it in a follow-up with a layout
  approach that doesn't conflict with the editor's grid.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
timur force-pushed fix/revert-workflow-editor-island from 0b210d7e48 to fe1769acea 2026-05-14 11:15:58 +00:00 Compare
timur merged commit 4c9168e448 into development 2026-05-14 11:16:16 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
lhumina_code/hero_logic!37
No description provided.