refactor(sdk): centralize openrpc_client! macro in hero_livekit_sdk #26

Merged

ashraf merged 2 commits from development_sdk_openrpc_client into main 2026-04-27 12:15:37 +00:00

Conversation 0 Commits 2 Files changed 10 +40 -34

ashraf commented 2026-04-23 14:46:17 +00:00

Member

Copy link

Summary

• Added openrpc.rs module to hero_livekit_sdk with the single canonical openrpc_client! invocation
• Migrated all consumers (UI, examples, rhai) to import from SDK instead of invoking the macro directly
• Removed hero_rpc_derive direct dependency from consumer crates

Related Issue

Closes #3

Changes

• New: crates/hero_livekit_sdk/src/openrpc.rs with centralized openrpc_client! macro
• Modified: crates/hero_livekit_sdk/src/lib.rs to export new module
• Modified: crates/hero_livekit_ui/ to import from SDK
• Modified: crates/hero_livekit_examples/ to import from SDK
• Modified: crates/hero_livekit_rhai/ to import from SDK

Test Results

34 tests passed, 0 failures

## Summary - Added `openrpc.rs` module to `hero_livekit_sdk` with the single canonical `openrpc_client!` invocation - Migrated all consumers (UI, examples, rhai) to import from SDK instead of invoking the macro directly - Removed `hero_rpc_derive` direct dependency from consumer crates ## Related Issue Closes https://forge.ourworld.tf/lhumina_code/hero_livekit/issues/3 ## Changes - New: `crates/hero_livekit_sdk/src/openrpc.rs` with centralized `openrpc_client!` macro - Modified: `crates/hero_livekit_sdk/src/lib.rs` to export new module - Modified: `crates/hero_livekit_ui/` to import from SDK - Modified: `crates/hero_livekit_examples/` to import from SDK - Modified: `crates/hero_livekit_rhai/` to import from SDK ## Test Results 34 tests passed, 0 failures

ashraf added 1 commit 2026-04-23 14:46:17 +00:00

refactor(sdk): centralize openrpc_client! macro in hero_livekit_sdk ... fc034762b8

#3

ashraf referenced this pull request 2026-04-23 14:46:22 +00:00

Introduce hero_livekit_sdk crate (shared OpenRPC client) #3

ashraf added 1 commit 2026-04-27 09:57:36 +00:00

fix(lint): collapse nested if-let chains for clippy::collapsible_if ... 7750c646cb

#3

ashraf force-pushed development_sdk_openrpc_client from 7750c646cb to 84bd9741ea 2026-04-27 10:11:46 +00:00 Compare

ashraf added 1 commit 2026-04-27 10:51:19 +00:00

fix(sdk): add build.rs to preserve openrpc module across OSchema regeneration ... 23820ce6d0

The hero_livekit build.rs (OSchema code generator) regenerates
hero_livekit_sdk/src/lib.rs on every build, stripping any hand-added
module declarations. Add a build.rs to the SDK crate that re-adds
`pub mod openrpc;` to lib.rs before compilation, ensuring the module
is always available regardless of regeneration order.

#3

ashraf force-pushed development_sdk_openrpc_client from 23820ce6d0 to ce752fd1e4 2026-04-27 10:59:50 +00:00 Compare

ashraf merged commit ce752fd1e4 into main 2026-04-27 12:15:37 +00:00

ashraf deleted branch development_sdk_openrpc_client 2026-04-27 12:15:37 +00:00

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels

No items

No labels

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

lhumina_code/hero_livekit!26

No description provided.