Livekit single crate to start, stop, install, etc in hero_proc services #1

New issue

Closed

opened 2026-04-19 20:59:28 +00:00 by mahmoud · 4 comments

mahmoud commented 2026-04-19 20:59:28 +00:00

Owner

Copy link

see https://forge.ourworld.tf/lhumina_code/hero_skills/src/branch/development/claude/skills/hero_proc_service_selfstart

see https://forge.ourworld.tf/lhumina_code/hero_skills/src/branch/development/claude/skills/hero_proc_service_selfstart

ashraf was assigned by mahmoud 2026-04-19 20:59:36 +00:00

mahmoud added this to the ACTIVE project 2026-04-19 20:59:38 +00:00

mahmoud referenced this issue 2026-04-19 21:17:46 +00:00

Replace custom build_lib.sh with canonical hero_lib copy + standardize Makefile #4

mahmoud referenced this issue 2026-04-19 21:17:51 +00:00

Add integration tests + testcases/ browser MCP specs (testing pyramid) #11

mahmoud referenced this issue 2026-04-19 21:25:29 +00:00

Align OSchema/UDS layout with canonical hero_osis/hero_voice pattern #15

ashraf referenced this issue 2026-04-22 15:18:27 +00:00

Align OSchema/UDS layout with canonical hero_osis/hero_voice pattern #15

ashraf referenced this issue 2026-04-23 14:34:10 +00:00

Replace custom build_lib.sh with canonical hero_lib copy + standardize Makefile #4

ashraf referenced this issue 2026-04-23 14:37:05 +00:00

Replace custom build_lib.sh with canonical hero_lib copy + standardize Makefile #4

ashraf commented 2026-04-27 07:36:05 +00:00

Member

Copy link

Implementation Spec for Issue #1

Objective

Wire up the auto-generated hero_livekit single-binary orchestrator so it compiles and works with hero_proc for lifecycle management (--start/--stop). The binary already exists at crates/hero_livekit/src/bin/hero_livekit.rs (generated by single_bin() in build.rs) but is disabled (autobins = false, no [[bin]] section, missing dependencies).

Requirements

• Enable the hero_livekit binary by adding [[bin]] section and required dependencies
• Refactor hero_livekit_ui into a library + binary so the single-binary can embed the UI router
• The hero_livekit binary supports --start (register with hero_proc), --stop (stop via hero_proc), and plain foreground mode
• Update Makefile install targets to include the new binary

Files to Modify/Create

• crates/hero_livekit_ui/src/lib.rs (new) -- Library exporting build_router() and UiMeta
• crates/hero_livekit_ui/src/main.rs -- Simplify to call library
• crates/hero_livekit_ui/Cargo.toml -- Add [lib] section
• crates/hero_livekit/Cargo.toml -- Add [[bin]] section and dependencies
• Makefile -- Add hero_livekit to install/installdev targets

Implementation Plan

Step 1: Refactor hero_livekit_ui into lib + bin

• Create lib.rs exporting UiMeta struct, build_router function, and all route handlers
• Simplify main.rs to use the library
• Add [lib] section to Cargo.toml

Step 2: Wire up hero_livekit binary

• Add bin section and dependencies to crates/hero_livekit/Cargo.toml
• Add hero_livekit to Makefile install targets

Step 3: Build and test

Acceptance Criteria

• cargo build -p hero_livekit --bin hero_livekit compiles successfully
• hero_livekit --help shows --start, --stop, --contexts flags
• hero_livekit_ui standalone binary still works
• Makefile install targets include hero_livekit
• All existing tests pass

## Implementation Spec for Issue #1 ### Objective Wire up the auto-generated `hero_livekit` single-binary orchestrator so it compiles and works with hero_proc for lifecycle management (--start/--stop). The binary already exists at `crates/hero_livekit/src/bin/hero_livekit.rs` (generated by `single_bin()` in build.rs) but is disabled (`autobins = false`, no `[[bin]]` section, missing dependencies). ### Requirements - Enable the `hero_livekit` binary by adding `[[bin]]` section and required dependencies - Refactor `hero_livekit_ui` into a library + binary so the single-binary can embed the UI router - The `hero_livekit` binary supports `--start` (register with hero_proc), `--stop` (stop via hero_proc), and plain foreground mode - Update Makefile install targets to include the new binary ### Files to Modify/Create - `crates/hero_livekit_ui/src/lib.rs` (new) -- Library exporting `build_router()` and `UiMeta` - `crates/hero_livekit_ui/src/main.rs` -- Simplify to call library - `crates/hero_livekit_ui/Cargo.toml` -- Add `[lib]` section - `crates/hero_livekit/Cargo.toml` -- Add `[[bin]]` section and dependencies - `Makefile` -- Add `hero_livekit` to install/installdev targets ### Implementation Plan #### Step 1: Refactor hero_livekit_ui into lib + bin - Create lib.rs exporting UiMeta struct, build_router function, and all route handlers - Simplify main.rs to use the library - Add [lib] section to Cargo.toml #### Step 2: Wire up hero_livekit binary - Add [[bin]] section and dependencies to crates/hero_livekit/Cargo.toml - Add hero_livekit to Makefile install targets #### Step 3: Build and test ### Acceptance Criteria - [ ] `cargo build -p hero_livekit --bin hero_livekit` compiles successfully - [ ] `hero_livekit --help` shows --start, --stop, --contexts flags - [ ] `hero_livekit_ui` standalone binary still works - [ ] Makefile install targets include hero_livekit - [ ] All existing tests pass

ashraf commented 2026-04-27 09:02:56 +00:00

Member

Copy link

Test Results

• Total: 34
• Passed: 34
• Failed: 0

The hero_livekit binary builds and all workspace tests pass. The --help output confirms --start, --stop, --contexts, --seed-dir, --seed-domains flags are available.

## Test Results - Total: 34 - Passed: 34 - Failed: 0 The hero_livekit binary builds and all workspace tests pass. The --help output confirms --start, --stop, --contexts, --seed-dir, --seed-domains flags are available.

ashraf commented 2026-04-27 09:03:02 +00:00

Member

Copy link

Implementation Summary

Changes Made

hero_livekit_ui refactored into lib + bin:

• Created crates/hero_livekit_ui/src/lib.rs exporting UiMeta, build_router(), bind_unix_socket(), ui_socket_path(), service_socket_path()
• Simplified crates/hero_livekit_ui/src/main.rs to use the library
• Added [lib] section to crates/hero_livekit_ui/Cargo.toml
• Downgraded axum from 0.8 to 0.7 to match hero_rpc_server's Router type
• Added WhitelistState::new_blocking() for synchronous initialization in embedded mode

hero_livekit binary enabled:

• Added [[bin]] section and dependencies (hero_rpc_server, hero_livekit_ui, clap, tracing-subscriber, axum) to crates/hero_livekit/Cargo.toml
• Removed autobins = false
• Fixed fn item to fn pointer coercion in the auto-generated binary
• Added hero_livekit_ui as workspace dependency

Makefile updated:

• Added hero_livekit binary to install/installdev targets

Result

The hero_livekit binary now supports the hero_proc_service_selfstart pattern:

• hero_livekit --start registers with hero_proc and starts
• hero_livekit --stop stops via hero_proc
• hero_livekit (no flags) runs foreground (hero_proc launches it this way)
• The standalone hero_livekit_ui binary continues to work independently

## Implementation Summary ### Changes Made **hero_livekit_ui refactored into lib + bin:** - Created `crates/hero_livekit_ui/src/lib.rs` exporting `UiMeta`, `build_router()`, `bind_unix_socket()`, `ui_socket_path()`, `service_socket_path()` - Simplified `crates/hero_livekit_ui/src/main.rs` to use the library - Added `[lib]` section to `crates/hero_livekit_ui/Cargo.toml` - Downgraded axum from 0.8 to 0.7 to match hero_rpc_server's Router type - Added `WhitelistState::new_blocking()` for synchronous initialization in embedded mode **hero_livekit binary enabled:** - Added `[[bin]]` section and dependencies (hero_rpc_server, hero_livekit_ui, clap, tracing-subscriber, axum) to `crates/hero_livekit/Cargo.toml` - Removed `autobins = false` - Fixed fn item to fn pointer coercion in the auto-generated binary - Added `hero_livekit_ui` as workspace dependency **Makefile updated:** - Added `hero_livekit` binary to install/installdev targets ### Result The `hero_livekit` binary now supports the hero_proc_service_selfstart pattern: - `hero_livekit --start` registers with hero_proc and starts - `hero_livekit --stop` stops via hero_proc - `hero_livekit` (no flags) runs foreground (hero_proc launches it this way) - The standalone `hero_livekit_ui` binary continues to work independently

ashraf referenced this issue from a commit 2026-04-27 09:03:51 +00:00

feat(cli): enable hero_livekit single-binary with hero_proc lifecycle

ashraf referenced this issue 2026-04-27 09:04:17 +00:00

feat(cli): enable hero_livekit single-binary with hero_proc lifecycle #28

ashraf commented 2026-04-27 09:04:23 +00:00

Member

Copy link

Pull request opened: #28

This PR implements the changes discussed in this issue.

Pull request opened: https://forge.ourworld.tf/lhumina_code/hero_livekit/pulls/28 This PR implements the changes discussed in this issue.

ashraf referenced this issue from a commit 2026-04-27 09:45:47 +00:00

fix(clippy): collapse nested if-let chains in whitelist and lk-backend

ashraf closed this issue 2026-04-27 14:53:48 +00:00

mahmoud referenced this issue 2026-04-27 17:23:41 +00:00

Re-align workspace layout with hero_compute (revisits #15) #29

Sign in to join this conversation.

No Branch/Tag specified

Branches Tags

main

development_mik_nu_demo

No results found.

Labels

Clear labels

No items

No labels

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

ACTIVE

Assignees

Clear assignees

No assignees

ashraf

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

lhumina_code/hero_livekit#1

No description provided.