fix(clients): add missing redis dep behind opencode feature #135

Merged

mik-tf merged 1 commit from development_mik_clients_redis_dep into development

2026-05-09 13:07:26 +00:00

mik-tf commented

2026-05-09 13:07:25 +00:00

Owner

crates/clients/src/opencode_api/client/models.rs imports use redis::Commands; plus redis::Client::open(...) / redis::RedisResult at four call sites, but redis was never declared as a dep of herolib_clients. Both opencode_demo and opencode_tester (gated --features opencode) fail to compile under the hero_builder source-build sweep.

Add redis = { version = "1", optional = true } matching the canonical workspace version (herolib_core, herolib_os, herolib_vault all use redis 1.x), and pull it in via the existing opencode feature so non-opencode consumers stay free of the dep.

Verified GREEN via ~/hero/bin/hero_builder --release --policy-mode warn: 4/4 targets built, including the two previously-red opencode binaries.

Tracked under lhumina_code/home#230 (P0 source-build sweep).

Signed-off-by: mik-tf

`crates/clients/src/opencode_api/client/models.rs` imports `use redis::Commands;` plus `redis::Client::open(...)` / `redis::RedisResult` at four call sites, but `redis` was never declared as a dep of `herolib_clients`. Both `opencode_demo` and `opencode_tester` (gated `--features opencode`) fail to compile under the `hero_builder` source-build sweep. Add `redis = { version = "1", optional = true }` matching the canonical workspace version (herolib_core, herolib_os, herolib_vault all use redis 1.x), and pull it in via the existing `opencode` feature so non-opencode consumers stay free of the dep. Verified GREEN via `~/hero/bin/hero_builder --release --policy-mode warn`: 4/4 targets built, including the two previously-red opencode binaries. Tracked under https://forge.ourworld.tf/lhumina_code/home/issues/230 (P0 source-build sweep). Signed-off-by: mik-tf

mik-tf added 1 commit

2026-05-09 13:07:25 +00:00

fix(clients): add missing redis dep behind opencode feature

Lint / lint-linux (pull_request) Successful in 14s

Details

Tests with Services / test-linux (pull_request) Failing after 27s

Details

7a2e456f18

`crates/clients/src/opencode_api/client/models.rs` imports
`use redis::Commands;` and calls `redis::Client::open(...)`,
`redis::RedisResult` at four call sites, but `redis` was never
declared as a dependency of `herolib_clients`. Both
`opencode_demo` and `opencode_tester` (gated `--features opencode`)
fail to compile under hero_builder source-build sweep.

Add `redis = { version = "1", optional = true }` matching the
canonical workspace version (herolib_core, herolib_os,
herolib_vault all use redis 1.x), and pull it in via the
existing `opencode` feature so non-opencode consumers stay free
of the dep.

Tracked under lhumina_code/home#230 (P0 source-build sweep).

Signed-off-by: mik-tf