lhumina_code/hero_lib
11
0
Fork 1
Code Issues 18 Pull requests Projects Releases 2 Packages 1 Wiki Activity Actions

Reuse Make targets in CI workflows #108

Merged
thabeta merged 2 commits from development_reuse_make_targets_in_workflows into development 2026-02-18 15:35:07 +00:00
Conversation 0 Commits 2 Files changed 4 +7 -33
mik-tf commented 2026-02-18 14:45:52 +00:00
Owner
Copy link

Simplify CI workflows to call Makefile targets instead of duplicating cargo commands inline. Also fixes stale package names in ci_rust.sh that were breaking CI.

Changes

  • make lint now includes fmt-check as prerequisite (format check + clippy in one target)
  • make test-rhai adds --verbose to match CI behavior
  • lint.yaml replaced two inline steps (fmt check + clippy) with single make lint
  • tests.yaml replaced three inline steps (build + rust tests + rhai tests) with single make test
  • Removed herolib_osis_client, herolib_oserver, herolib_rpc from ci_rust.sh (packages no longer exist)

Testing

  • make lint passes locally and in CI (run 617)
  • CI will validate test fix on this push

Closes #107
Closes #109

Simplify CI workflows to call Makefile targets instead of duplicating cargo commands inline. Also fixes stale package names in ci_rust.sh that were breaking CI. ## Changes - `make lint` now includes `fmt-check` as prerequisite (format check + clippy in one target) - `make test-rhai` adds `--verbose` to match CI behavior - `lint.yaml` replaced two inline steps (fmt check + clippy) with single `make lint` - `tests.yaml` replaced three inline steps (build + rust tests + rhai tests) with single `make test` - Removed `herolib_osis_client`, `herolib_oserver`, `herolib_rpc` from `ci_rust.sh` (packages no longer exist) ## Testing - `make lint` passes locally and in CI (run 617) - CI will validate test fix on this push Closes #107 Closes #109
👍 1
Reuse Make targets in CI workflows
Some checks failed
Lint / lint-linux (pull_request) Successful in 1m47s
Details
Tests with Services / test-linux (pull_request) Failing after 7m24s
Details
e94effe671 
Simplify lint.yaml and tests.yaml to call make lint and make test
instead of duplicating cargo commands inline. The Makefile lint target
now includes fmt-check as a prerequisite, and test-rhai adds --verbose
to match CI behavior.

Closes #107

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Remove stale package names from ci_rust.sh
All checks were successful
Lint / lint-linux (pull_request) Successful in 1m46s
Details
Tests with Services / test-linux (pull_request) Successful in 8m40s
Details
e16f7142fd 
herolib_osis_client, herolib_oserver, and herolib_rpc no longer exist
in the workspace. Removing them fixes CI test failures.

Closes #109

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
mik-tf changed title from WIP: Reuse Make targets in CI workflows to Reuse Make targets in CI workflows 2026-02-18 15:14:53 +00:00
thabeta merged commit aa75d7653e into development 2026-02-18 15:35:07 +00:00
thabeta deleted branch development_reuse_make_targets_in_workflows 2026-02-18 15:35:11 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
prio_critical

   
prio_low

   
type_bug

   
type_contact

   
type_issue

   
type_lead

   
type_question

   
type_story

   
type_task
No labels
prio_critical
prio_low
type_bug
type_contact
type_issue
type_lead
type_question
type_story
type_task
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
lhumina_code/hero_lib!108
No description provided.