fix(makefile): use bash + honor CARGO_TARGET_DIR for install #10

Merged

zaelgohary merged 1 commit from development_fix_makefile_install_linux into development

2026-05-03 14:15:34 +00:00

zaelgohary commented

2026-05-03 14:09:14 +00:00

Member

Summary

make install was failing on Linux with /bin/sh: 1: source: not found because the Makefile recipe lines use source $(BUILD_LIB) and /bin/sh resolves to dash on Debian. After that, install_binaries was looking at a target/release that did not exist because CARGO_TARGET_DIR is set to a shared per-user dir.

This sets SHELL := /bin/bash for recipe execution and makes RELEASE_DIR honor CARGO_TARGET_DIR — matching the pattern hero_aibroker uses (line 14-15).

N/A — surfaced as install-step failure during todays daily-sync.

Changes

SHELL := /bin/bash so recipes execute under bash (source works)
RELEASE_DIR ?= $(if $(CARGO_TARGET_DIR),$(CARGO_TARGET_DIR),target)/release

Test Results

make install ran clean on herodev and produced fresh binaries in ~/hero/bin/ (hero_foundry, hero_foundry_ui, hero_foundry_ui_server).

## Summary `make install` was failing on Linux with `/bin/sh: 1: source: not found` because the Makefile recipe lines use `source $(BUILD_LIB)` and `/bin/sh` resolves to `dash` on Debian. After that, install_binaries was looking at a `target/release` that did not exist because `CARGO_TARGET_DIR` is set to a shared per-user dir. This sets `SHELL := /bin/bash` for recipe execution and makes `RELEASE_DIR` honor `CARGO_TARGET_DIR` — matching the pattern hero_aibroker uses (line 14-15). ## Related Issue N/A — surfaced as install-step failure during todays daily-sync. ## Changes - `SHELL := /bin/bash` so recipes execute under bash (`source` works) - `RELEASE_DIR ?= $(if $(CARGO_TARGET_DIR),$(CARGO_TARGET_DIR),target)/release` ## Test Results make install ran clean on herodev and produced fresh binaries in ~/hero/bin/ (hero_foundry, hero_foundry_ui, hero_foundry_ui_server).