lhumina_code/hero_forge
20
0
Fork 0
Code Issues 2 Pull requests 1 Projects Releases Packages Wiki Activity Actions

Fix all clippy warnings and migrate CLI to clap #1

Open
delandtj wants to merge 1 commit from clippy-fixes-and-clap into main
pull from: clippy-fixes-and-clap
merge into: lhumina_code:main
Conversation 0 Commits 1 Files changed 25 +382 -441
delandtj commented 2025-12-20 17:06:53 +00:00
Member
Copy link

  • Fix 40+ clippy warnings across the codebase:

    • collapsible_if: Use if-let chains with && for cleaner nested conditionals
    • manual_strip: Use strip_prefix() instead of starts_with() + slicing
    • io_other_error: Use std::io::Error::other()
    • inherent_to_string: Implement Display trait for FilePermissions
    • unnecessary_lazy_evaluations: Use unwrap_or instead of unwrap_or_else
    • redundant_closure: Use tuple variant directly in map_err
    • type_complexity: Add CheckinRow type alias
    • unnecessary_unwrap: Use pattern matching
    • needless_borrow: Remove unnecessary references
    • while_let_on_iterator: Use for loop
    • redundant_allocation: Fix Arc<Arc<...>> in WebDAV server
    • derivable_impls: Use #[derive(Default)] with #[default] attribute
    • manual_inspect: Use inspect_err instead of map_err
    • ptr_arg: Use &Path instead of &PathBuf in function signatures

  • Migrate CLI argument parsing from hand-rolled to clap:

    • Add clap dependency with derive feature
    • Define Cli struct with proper argument definitions
    • Add Commands enum for start/stop/status subcommands
    • Auto-generated --help and --version
    • Type-safe argument parsing with validation

Passes cargo clippy --all-targets --all-features with zero warnings.

- Fix 40+ clippy warnings across the codebase: - collapsible_if: Use if-let chains with && for cleaner nested conditionals - manual_strip: Use strip_prefix() instead of starts_with() + slicing - io_other_error: Use std::io::Error::other() - inherent_to_string: Implement Display trait for FilePermissions - unnecessary_lazy_evaluations: Use unwrap_or instead of unwrap_or_else - redundant_closure: Use tuple variant directly in map_err - type_complexity: Add CheckinRow type alias - unnecessary_unwrap: Use pattern matching - needless_borrow: Remove unnecessary references - while_let_on_iterator: Use for loop - redundant_allocation: Fix Arc<Arc<...>> in WebDAV server - derivable_impls: Use #[derive(Default)] with #[default] attribute - manual_inspect: Use inspect_err instead of map_err - ptr_arg: Use &Path instead of &PathBuf in function signatures - Migrate CLI argument parsing from hand-rolled to clap: - Add clap dependency with derive feature - Define Cli struct with proper argument definitions - Add Commands enum for start/stop/status subcommands - Auto-generated --help and --version - Type-safe argument parsing with validation Passes cargo clippy --all-targets --all-features with zero warnings.
- Fix 40+ clippy warnings across the codebase:
  - collapsible_if: Use if-let chains with && for cleaner nested conditionals
  - manual_strip: Use strip_prefix() instead of starts_with() + slicing
  - io_other_error: Use std::io::Error::other()
  - inherent_to_string: Implement Display trait for FilePermissions
  - unnecessary_lazy_evaluations: Use unwrap_or instead of unwrap_or_else
  - redundant_closure: Use tuple variant directly in map_err
  - type_complexity: Add CheckinRow type alias
  - unnecessary_unwrap: Use pattern matching
  - needless_borrow: Remove unnecessary references
  - while_let_on_iterator: Use for loop
  - redundant_allocation: Fix Arc<Arc<...>> in WebDAV server
  - derivable_impls: Use #[derive(Default)] with #[default] attribute
  - manual_inspect: Use inspect_err instead of map_err
  - ptr_arg: Use &Path instead of &PathBuf in function signatures

- Migrate CLI argument parsing from hand-rolled to clap:
  - Add clap dependency with derive feature
  - Define Cli struct with proper argument definitions
  - Add Commands enum for start/stop/status subcommands
  - Auto-generated --help and --version
  - Type-safe argument parsing with validation

Passes cargo clippy --all-targets --all-features with zero warnings.
This pull request has changes conflicting with the target branch.
  • Cargo.toml
  • src/bin/heroforge-core.rs
  • src/fs/commit_thread.rs
  • src/fs/fs_interface.rs
  • src/fs/interface.rs
  • src/server/webdav/dav_fs.rs
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin clippy-fixes-and-clap:clippy-fixes-and-clap
git switch clippy-fixes-and-clap

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch main
git merge --no-ff clippy-fixes-and-clap
git switch clippy-fixes-and-clap
git rebase main
git switch main
git merge --ff-only clippy-fixes-and-clap
git switch clippy-fixes-and-clap
git rebase main
git switch main
git merge --no-ff clippy-fixes-and-clap
git switch main
git merge --squash clippy-fixes-and-clap
git switch main
git merge --ff-only clippy-fixes-and-clap
git switch main
git merge clippy-fixes-and-clap
git push origin main
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
despiegk
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
lhumina_code/hero_forge!1
No description provided.