fix(hero_embedderd): make Path import unconditional #34

Merged
zaelgohary merged 1 commit from development_fix_path_import_linux into development 2026-05-03 13:17:36 +00:00
Member

Summary

hero_embedderd use of Path::new(path) runs on both macOS and Linux (the linux branch also iterates fallback library paths) but the use std::path::Path; import was gated behind #[cfg(target_os = "macos")], so the linux release build failed with use of undeclared type Path. This re-applies the same fix from 3f9e8c3 (omarz, earlier today) that was reverted in 37ab134 without explanation. The release make install step now produces a binary on linux.

N/A — surfaced as an install-step build failure on linux during deploy.

Changes

  • dropped the #[cfg(target_os = "macos")] gate from use std::path::Path;

Test Results

cargo build --release -p hero_embedderd passes clean.

## Summary `hero_embedderd` use of `Path::new(path)` runs on both macOS and Linux (the linux branch also iterates fallback library paths) but the `use std::path::Path;` import was gated behind `#[cfg(target_os = "macos")]`, so the linux release build failed with `use of undeclared type Path`. This re-applies the same fix from 3f9e8c3 (omarz, earlier today) that was reverted in 37ab134 without explanation. The release `make install` step now produces a binary on linux. ## Related Issue N/A — surfaced as an install-step build failure on linux during deploy. ## Changes - dropped the `#[cfg(target_os = "macos")]` gate from `use std::path::Path;` ## Test Results cargo build --release -p hero_embedderd passes clean.
fix(hero_embedderd): make Path import unconditional
Some checks failed
Test / test (pull_request) Has been cancelled
2cdfa76169
zaelgohary merged commit 185cbc1f75 into development 2026-05-03 13:17:36 +00:00
zaelgohary deleted branch development_fix_path_import_linux 2026-05-03 13:17:36 +00:00
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
lhumina_code/hero_embedder!34
No description provided.