fix(hero_embedderd): make Path import unconditional #34
No reviewers
Labels
No labels
prio_critical
prio_low
type_bug
type_contact
type_issue
type_lead
type_question
type_story
type_task
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
lhumina_code/hero_embedder!34
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "development_fix_path_import_linux"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Summary
hero_embedderduse ofPath::new(path)runs on both macOS and Linux (the linux branch also iterates fallback library paths) but theuse std::path::Path;import was gated behind#[cfg(target_os = "macos")], so the linux release build failed withuse of undeclared type Path. This re-applies the same fix from3f9e8c3(omarz, earlier today) that was reverted in37ab134without explanation. The releasemake installstep now produces a binary on linux.Related Issue
N/A — surfaced as an install-step build failure on linux during deploy.
Changes
#[cfg(target_os = "macos")]gate fromuse std::path::Path;Test Results
cargo build --release -p hero_embedderd passes clean.