lhumina_code/hero_compute
0
0
Fork 0
Code Issues 7 Pull requests 2 Projects Releases 9 Packages Wiki Activity Actions

Secret-based auth for VM ownership #4

Merged
mahmoud merged 1 commit from development_secret into development 2026-03-07 23:43:11 +00:00
Conversation 2 Commits 1 Files changed 12 +445 -84
zaelgohary commented 2026-03-05 12:11:52 +00:00
Member
Copy link

Add an optional secret field to VMs to enable callers to scope and protect access.

  • Schema: Add secret?: str to Vm; add secret param to deploy_vm, list_vms, get_vm, delete_vm, start_vm, stop_vm, restart_vm, attach_hypervisor,
    vm_logs, vm_exec
  • rpc.rs: Validate secret on all VM ops; list_vms filters by secret
  • Empty/missing secret = no protection (backward compatible)
  • Wrong secret returns NotFound (no indication VM exists)
  • Update openrpc.json, hero_cloud_sdk, docs/api.md, UI, examples

Related issue: lhumina_code/hero_cloud#2

Add an optional secret field to VMs to enable callers to scope and protect access. - Schema: Add secret?: str to Vm; add secret param to deploy_vm, list_vms, get_vm, delete_vm, start_vm, stop_vm, restart_vm, attach_hypervisor, vm_logs, vm_exec - rpc.rs: Validate secret on all VM ops; list_vms filters by secret - Empty/missing secret = no protection (backward compatible) - Wrong secret returns NotFound (no indication VM exists) - Update openrpc.json, hero_cloud_sdk, docs/api.md, UI, examples Related issue: https://forge.ourworld.tf/lhumina_code/hero_cloud/issues/2
Add & validate secret param to vm ops, list_vms filters by secret, update openrpc.json, hero_cloud_sdk, docs/api.md, UI, examples
All checks were successful
Test / test (pull_request) Successful in 1m11s
Details
Test / test (push) Successful in 1m10s
Details
adab9870ad
mahmoud commented 2026-03-05 14:24:47 +00:00
Owner
Copy link

Good job! Could you also update the documentation? Many function signatures need to be updated to include the new secret parameter. Thanks

Good job! Could you also update the documentation? Many function signatures need to be updated to include the new secret parameter. Thanks
mahmoud merged commit c43a979ad5 into development 2026-03-07 23:43:11 +00:00
mahmoud deleted branch development_secret 2026-03-07 23:43:15 +00:00
zaelgohary commented 2026-03-08 09:34:07 +00:00
Author
Member
Copy link

@mahmoud wrote in lhumina_code/hero_cloud#4 (comment):

Good job! Could you also update the documentation? Many function signatures need to be updated to include the new secret parameter. Thanks

docs/api.md was already updated. Created a PR to update testing.md.

@mahmoud wrote in https://forge.ourworld.tf/lhumina_code/hero_cloud/pulls/4#issuecomment-10645: > Good job! Could you also update the documentation? Many function signatures need to be updated to include the new secret parameter. Thanks docs/api.md was already updated. Created a [PR](https://forge.ourworld.tf/lhumina_code/hero_cloud/pulls/6) to update testing.md.
Sign in to join this conversation.
Reviewers
No reviewers
mahmoud
Labels
Clear labels   
prio_critical

   
prio_low

   
type_bug

   
type_contact

   
type_issue

   
type_lead

   
type_question

   
type_story

   
type_task
No labels
prio_critical
prio_low
type_bug
type_contact
type_issue
type_lead
type_question
type_story
type_task
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
lhumina_code/hero_compute!4
No description provided.