fix(buildenv): BINARIES hero_collab_ui → hero_collab_web #53

Merged

mik-tf merged 1 commit from development_mik_buildenv_collab_web into development

2026-05-07 18:08:30 +00:00

mik-tf commented

2026-05-07 18:04:43 +00:00

Owner

Producer rebrand bedaffb flipped crates/hero_collab_ui [[bin]] name to hero_collab_web and renamed the socket from ui.sock to web.sock, but missed the BINARIES list in buildenv.sh that build-linux.yaml uses to (a) verify post-build artifacts exist under target/release/ and (b) name the release assets uploaded to Forgejo Releases.

Without this, the next tag fails at the post-build check:

ERROR: Binary $BIN_DIR/hero_collab_ui not found

cargo still produces a binary at target/release/hero_collab_web (due to the [[bin]] rename in crates/hero_collab_ui/Cargo.toml), so the workflow just needs to ask for the new name.

Companion commits

This repo: bedaffb — producer binary + socket rename.
lhumina_code/hero_skills: 51afcfd — consumer service_collab.nu pre-flipped to _web / web.sock to match.

Out of scope

PROJECT_STRUCTURE.md and plan/impl-*.md still mention hero_collab_ui as a binary / socket name. The plans use cargo build -p hero_collab_ui which is correct (package name unchanged); PROJECT_STRUCTURE.md is a separate doc cleanup.

Producer rebrand `bedaffb` flipped `crates/hero_collab_ui [[bin]] name` to `hero_collab_web` and renamed the socket from `ui.sock` to `web.sock`, but missed the `BINARIES` list in `buildenv.sh` that `build-linux.yaml` uses to (a) verify post-build artifacts exist under `target/release/` and (b) name the release assets uploaded to Forgejo Releases. Without this, the next tag fails at the post-build check: ``` ERROR: Binary $BIN_DIR/hero_collab_ui not found ``` cargo still produces a binary at `target/release/hero_collab_web` (due to the `[[bin]]` rename in `crates/hero_collab_ui/Cargo.toml`), so the workflow just needs to ask for the new name. ## Companion commits - This repo: `bedaffb` — producer binary + socket rename. - `lhumina_code/hero_skills`: `51afcfd` — consumer `service_collab.nu` pre-flipped to `_web` / `web.sock` to match. ## Out of scope `PROJECT_STRUCTURE.md` and `plan/impl-*.md` still mention `hero_collab_ui` as a binary / socket name. The plans use `cargo build -p hero_collab_ui` which is correct (package name unchanged); `PROJECT_STRUCTURE.md` is a separate doc cleanup.

mik-tf added 1 commit

2026-05-07 18:04:43 +00:00

fix(buildenv): BINARIES hero_collab_ui → hero_collab_web aa081075d7

Producer rebrand bedaffb flipped `crates/hero_collab_ui [[bin]] name`
to `hero_collab_web` and renamed the socket from `ui.sock` to `web.sock`,
but missed the `BINARIES` list that build-linux.yaml uses to (a) verify
post-build artifacts exist under target/release/ and (b) name the release
assets uploaded to Forgejo Releases.

Without this, the next tag fails at the post-build check:
    ERROR: Binary $BIN_DIR/hero_collab_ui not found

cargo will still produce a binary at target/release/hero_collab_web
because of the [[bin]] rename, so the workflow just needs to ask for
the new name.

Companion to:
- bedaffb (this repo: producer binary + socket rename)
- 51afcfd in lhumina_code/hero_skills (consumer service_collab.nu pre-flipped)

Signed-off-by: mik-tf