lhumina_code/hero_collab
0
0
Fork 0
Code Issues 5 Pull requests Projects Releases 2 Packages Wiki Activity Actions

fix(admin): sort api_docs methods so prefixes group once #49

Merged
zaelgohary merged 2 commits from development_admin_api_docs_sync into development 2026-05-06 11:52:36 +00:00
Conversation 0 Commits 2 Files changed 2 +34 -2
zaelgohary commented 2026-05-06 11:42:09 +00:00
Member
Copy link

Summary

Phase L sync — api_docs_tab is already spec-driven via rpc.discover, but the grouping walked spec order and started a new accordion every time the prefix changed. Whenever openrpc.json interleaved namespaces (system, user, message, presence did), each prefix rendered as multiple duplicate sections. Sorting the method list by name before grouping collapses every prefix to one section and surfaces the PR1–PR3 admin namespaces (claims, role, org_group, log, impersonate) cleanly.

Related Issue

Refs #43.

Changes

  • Sorted RpcMethodInfo list by name before prefix-grouping in api_docs_tab.rs.
  • Added tests/playwright/specs/api_docs.spec.ts asserting every PR1–PR3 admin namespace appears exactly once and the previously-duplicated system/user/message/presence collapse to one each.

Test Results

25/25 standalone Playwright specs pass (1 new + 24 inherited). cargo check --workspace clean.

## Summary Phase L sync — `api_docs_tab` is already spec-driven via `rpc.discover`, but the grouping walked spec order and started a new accordion every time the prefix changed. Whenever `openrpc.json` interleaved namespaces (`system`, `user`, `message`, `presence` did), each prefix rendered as multiple duplicate sections. Sorting the method list by name before grouping collapses every prefix to one section and surfaces the PR1–PR3 admin namespaces (`claims`, `role`, `org_group`, `log`, `impersonate`) cleanly. ## Related Issue Refs #43. ## Changes - Sorted `RpcMethodInfo` list by name before prefix-grouping in `api_docs_tab.rs`. - Added `tests/playwright/specs/api_docs.spec.ts` asserting every PR1–PR3 admin namespace appears exactly once and the previously-duplicated `system`/`user`/`message`/`presence` collapse to one each. ## Test Results 25/25 standalone Playwright specs pass (1 new + 24 inherited). `cargo check --workspace` clean.
zaelgohary merged commit 014f8ac404 into development 2026-05-06 11:52:36 +00:00
zaelgohary deleted branch development_admin_api_docs_sync 2026-05-06 11:52:36 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
prio_critical

   
prio_low

   
type_bug

   
type_contact

   
type_issue

   
type_lead

   
type_question

   
type_story

   
type_task
No labels
prio_critical
prio_low
type_bug
type_contact
type_issue
type_lead
type_question
type_story
type_task
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
zaelgohary
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
lhumina_code/hero_collab!49
No description provided.