lhumina_code/hero_collab

Fork 0

implement notion of groups in collab #3

New issue

Closed

opened 2026-03-19 10:22:09 +00:00 by despiegk · 3 comments

despiegk commented

2026-03-19 10:22:09 +00:00

Owner

in admin interface allow creation of groups
we can manage group members which can be other groups or members (users)

for each user have an alias as well next to email, so they can chose how they are seen in collab

make sure in the _web ui we can work with groups

test all with browser mcp

in admin interface allow creation of groups we can manage group members which can be other groups or members (users) for each user have an alias as well next to email, so they can chose how they are seen in collab make sure in the _web ui we can work with groups test all with browser mcp

despiegk commented

2026-03-19 10:26:25 +00:00

Author

Owner

Implementation Spec for Issue #3: Groups in Hero Collab

Objective

Add a groups system to hero_collab that allows administrators to create groups, manage group membership (users and nested groups), add an alias field to users, and provide full UI support for group management in the admin dashboard.

Requirements

Add an alias field to users so they can choose how they appear in collab
Create groups with a name, description, and workspace scope
Support group membership where members can be either users or other groups (nested groups)
Provide cycle detection to prevent circular group nesting
Add a group.members.resolve RPC method that flattens nested groups to produce a deduplicated list of user IDs
Expose all group CRUD and membership operations through the JSON-RPC API
Add group management UI (Groups tab) in the admin dashboard
Update the OpenRPC spec with all new methods and schemas
Update the SDK with typed group methods
Include group count in system metrics

Files to Modify/Create

Modify:

crates/hero_collab_server/src/db.rs — Add groups/group_members tables, user alias column
crates/hero_collab_server/src/models.rs — Add Group, GroupMember structs; alias to User
crates/hero_collab_server/src/handlers/mod.rs — Register group module
crates/hero_collab_server/src/handlers/user.rs — Handle alias field
crates/hero_collab_server/src/rpc.rs — Register group.* routes, add groups to metrics
crates/hero_collab_server/openrpc.json — Add group methods/schemas, alias to User
crates/hero_collab_sdk/src/lib.rs — Add Group/GroupMember structs and methods
crates/hero_collab_ui/templates/base.html — Add Groups tab button
crates/hero_collab_ui/templates/index.html — Add Groups tab pane, modals, member management
crates/hero_collab_ui/static/js/dashboard.js — Group management JS, user alias support
crates/hero_collab_ui/static/css/dashboard.css — Group-specific styling

Create:

crates/hero_collab_server/src/handlers/group.rs — All group CRUD and membership handlers

Implementation Plan

Step 1: Database schema and models

Add alias column to users table (with migration safety)
Create groups table (id, workspace_id, name, data, created_at)
Create group_members table (group_id, member_id, member_type, data)
Add Group, GroupMember structs to models.rs; alias field to User

Step 2: User alias support in handlers

Accept/store alias in user create/update handlers

Step 3: Group handler implementation

Create group.rs with: create, get, list, update, delete, member_add, member_remove, member_list, members_resolve
Cycle detection for nested groups
Register in handlers/mod.rs

Step 4: RPC dispatch and metrics

Register all group.* routes in rpc.rs dispatch
Add group count to system.metrics

Step 5: OpenRPC specification update

Add Group/GroupMember schemas, alias to User schema
Add all 9 group method entries

Step 6: SDK update

Add Group/GroupMember structs and all group methods to CollabClient

Step 7: Web UI — Groups tab and user alias

Groups tab with CRUD, member management, workspace filter
User alias in create/edit forms and list display
Group count in dashboard metrics

Step 8: Browser MCP testing

Test user alias, group CRUD, membership, nested groups, cycle prevention

Acceptance Criteria

Users have an alias field (create, update, display)
Groups can be created, listed, updated, deleted via RPC
Groups scoped to workspace
Group members can be users or other groups
group.members.resolve returns flat deduplicated user list
Circular nesting detected and rejected
Delete group cascades membership removal
Groups tab functional in admin dashboard
OpenRPC spec documents all new methods
SDK exposes typed group methods
All verified via browser MCP testing

## Implementation Spec for Issue #3: Groups in Hero Collab ### Objective Add a groups system to hero_collab that allows administrators to create groups, manage group membership (users and nested groups), add an alias field to users, and provide full UI support for group management in the admin dashboard. ### Requirements - Add an `alias` field to users so they can choose how they appear in collab - Create groups with a name, description, and workspace scope - Support group membership where members can be either users or other groups (nested groups) - Provide cycle detection to prevent circular group nesting - Add a `group.members.resolve` RPC method that flattens nested groups to produce a deduplicated list of user IDs - Expose all group CRUD and membership operations through the JSON-RPC API - Add group management UI (Groups tab) in the admin dashboard - Update the OpenRPC spec with all new methods and schemas - Update the SDK with typed group methods - Include group count in system metrics ### Files to Modify/Create **Modify:** - `crates/hero_collab_server/src/db.rs` — Add groups/group_members tables, user alias column - `crates/hero_collab_server/src/models.rs` — Add Group, GroupMember structs; alias to User - `crates/hero_collab_server/src/handlers/mod.rs` — Register group module - `crates/hero_collab_server/src/handlers/user.rs` — Handle alias field - `crates/hero_collab_server/src/rpc.rs` — Register group.* routes, add groups to metrics - `crates/hero_collab_server/openrpc.json` — Add group methods/schemas, alias to User - `crates/hero_collab_sdk/src/lib.rs` — Add Group/GroupMember structs and methods - `crates/hero_collab_ui/templates/base.html` — Add Groups tab button - `crates/hero_collab_ui/templates/index.html` — Add Groups tab pane, modals, member management - `crates/hero_collab_ui/static/js/dashboard.js` — Group management JS, user alias support - `crates/hero_collab_ui/static/css/dashboard.css` — Group-specific styling **Create:** - `crates/hero_collab_server/src/handlers/group.rs` — All group CRUD and membership handlers ### Implementation Plan #### Step 1: Database schema and models - Add `alias` column to users table (with migration safety) - Create `groups` table (id, workspace_id, name, data, created_at) - Create `group_members` table (group_id, member_id, member_type, data) - Add Group, GroupMember structs to models.rs; alias field to User #### Step 2: User alias support in handlers - Accept/store alias in user create/update handlers #### Step 3: Group handler implementation - Create group.rs with: create, get, list, update, delete, member_add, member_remove, member_list, members_resolve - Cycle detection for nested groups - Register in handlers/mod.rs #### Step 4: RPC dispatch and metrics - Register all group.* routes in rpc.rs dispatch - Add group count to system.metrics #### Step 5: OpenRPC specification update - Add Group/GroupMember schemas, alias to User schema - Add all 9 group method entries #### Step 6: SDK update - Add Group/GroupMember structs and all group methods to CollabClient #### Step 7: Web UI — Groups tab and user alias - Groups tab with CRUD, member management, workspace filter - User alias in create/edit forms and list display - Group count in dashboard metrics #### Step 8: Browser MCP testing - Test user alias, group CRUD, membership, nested groups, cycle prevention ### Acceptance Criteria - [ ] Users have an alias field (create, update, display) - [ ] Groups can be created, listed, updated, deleted via RPC - [ ] Groups scoped to workspace - [ ] Group members can be users or other groups - [ ] group.members.resolve returns flat deduplicated user list - [ ] Circular nesting detected and rejected - [ ] Delete group cascades membership removal - [ ] Groups tab functional in admin dashboard - [ ] OpenRPC spec documents all new methods - [ ] SDK exposes typed group methods - [ ] All verified via browser MCP testing

despiegk commented

2026-03-19 10:37:09 +00:00

Author

Owner

Implementation Complete

Changes Made

Database & Models (crates/hero_collab_server/src/)

db.rs — Added groups and group_members tables; safe migration for alias column on users
models.rs — Added Group, GroupMember structs; alias field on User

Handlers (crates/hero_collab_server/src/handlers/)

group.rs (new) — 9 handler functions: create, get, list, update, delete, member_add, member_remove, member_list, members_resolve. Includes cycle detection and recursive member resolution.
user.rs — Alias support in create/update
mod.rs — Registered group module

RPC (crates/hero_collab_server/src/rpc.rs)

Registered all 9 group.* routes
Added group count to system.metrics

OpenRPC Spec (crates/hero_collab_server/openrpc.json)

Added Group, GroupMember schemas; alias to User schema
Added all 9 group method specs
Updated system.metrics schema

SDK (crates/hero_collab_sdk/src/lib.rs)

Added Group, GroupMember structs
Added 9 group methods on CollabClient
Added alias to User struct and user_create

Web UI (crates/hero_collab_ui/)

Groups tab with full CRUD, workspace filter, search
Group detail panel with member management (add/remove/resolve)
User alias field in create/edit forms and list display
Groups count in dashboard metrics

Test Results

Total: 4 | Passed: 4 | Failed: 0
All existing tests pass (server health, RPC discover, client creation, doc-test)

## Implementation Complete ### Changes Made **Database & Models** (`crates/hero_collab_server/src/`) - `db.rs` — Added `groups` and `group_members` tables; safe migration for `alias` column on `users` - `models.rs` — Added `Group`, `GroupMember` structs; `alias` field on `User` **Handlers** (`crates/hero_collab_server/src/handlers/`) - `group.rs` (new) — 9 handler functions: create, get, list, update, delete, member_add, member_remove, member_list, members_resolve. Includes cycle detection and recursive member resolution. - `user.rs` — Alias support in create/update - `mod.rs` — Registered group module **RPC** (`crates/hero_collab_server/src/rpc.rs`) - Registered all 9 `group.*` routes - Added group count to `system.metrics` **OpenRPC Spec** (`crates/hero_collab_server/openrpc.json`) - Added Group, GroupMember schemas; alias to User schema - Added all 9 group method specs - Updated system.metrics schema **SDK** (`crates/hero_collab_sdk/src/lib.rs`) - Added Group, GroupMember structs - Added 9 group methods on CollabClient - Added alias to User struct and user_create **Web UI** (`crates/hero_collab_ui/`) - Groups tab with full CRUD, workspace filter, search - Group detail panel with member management (add/remove/resolve) - User alias field in create/edit forms and list display - Groups count in dashboard metrics ### Test Results - **Total: 4 | Passed: 4 | Failed: 0** - All existing tests pass (server health, RPC discover, client creation, doc-test)

despiegk commented

2026-03-19 10:38:33 +00:00

Author

Owner

Implementation committed: 7a97b2c

Browse: 7a97b2c

Implementation committed: `7a97b2c` Browse: https://forge.ourworld.tf/lhumina_code/hero_collab/commit/7a97b2c