fix: hero_proc_service_selfstart compliance — remove unused dep, clean kill_other #89

Merged
despiegk merged 1 commit from development_hero_proc_selfstart_compliance into development 2026-04-14 03:54:43 +00:00
Owner

Summary

  • Removed unused hero_proc_sdk dependency from hero_books_server/Cargo.toml
  • Replaced empty Some(vec![]) / Some(String::new()) with None in all three kill_other blocks

Test plan

  • Diff reviewed — no logic changes, only cleanup
  • Verified hero_proc SDK does not support HTTP-over-UDS health checks; UI/admin health checks correctly remain as process-liveness-only

lhumina_code/home#116

## Summary - Removed unused `hero_proc_sdk` dependency from `hero_books_server/Cargo.toml` - Replaced empty `Some(vec![])` / `Some(String::new())` with `None` in all three `kill_other` blocks ## Test plan - Diff reviewed — no logic changes, only cleanup - Verified hero_proc SDK does not support HTTP-over-UDS health checks; UI/admin health checks correctly remain as process-liveness-only https://forge.ourworld.tf/lhumina_code/home/issues/116
fix: hero_proc_service_selfstart compliance — remove unused dep, clean kill_other
Some checks failed
Test / test (pull_request) Failing after 6m34s
Test / integration (pull_request) Has been skipped
ba5f6f4a4f
lhumina_code/home#116
despiegk merged commit 4477a64570 into development 2026-04-14 03:54:43 +00:00
despiegk deleted branch development_hero_proc_selfstart_compliance 2026-04-14 03:54:44 +00:00
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
lhumina_code/hero_books!89
No description provided.