lhumina_code/hero_books
2
0
Fork 0
Code Issues 3 Pull requests Projects Releases 2 Packages Wiki Activity Actions

fix(books): trim trailing slash on BASE_PATH #112

Merged
zaelgohary merged 1 commit from development_fix_double_slash_rpc into development 2026-04-29 11:20:51 +00:00
Conversation 0 Commits 1 Files changed 1 +1 -1
zaelgohary commented 2026-04-29 11:05:19 +00:00
Member
Copy link

Summary

fetch(BASE_PATH + "/rpc") was producing //rpc because the templated {{ base }} already ends with /. Strip it once at definition.

Related Issue

Closes #113

Changes

  • Stripped trailing slash from BASE_PATH on init

Test Results

playwright trace: 0 failed requests on books open.

before

## Summary `fetch(BASE_PATH + "/rpc")` was producing `//rpc` because the templated `{{ base }}` already ends with `/`. Strip it once at definition. ## Related Issue Closes https://forge.ourworld.tf/lhumina_code/hero_books/issues/113 ## Changes - Stripped trailing slash from BASE_PATH on init ## Test Results playwright trace: 0 failed requests on books open. ![before](https://forge.ourworld.tf/attachments/8cea0fdf-766c-4a79-9157-9a5c8a6c150d)
before-fix.png
96 KiB
fix(books): trim trailing slash from BASE_PATH to avoid //rpc 404
All checks were successful
Test / test (pull_request) Successful in 9m30s
Details
Test / integration (pull_request) Successful in 5m45s
Details
70adca4ce4
zaelgohary merged commit 9317708ba2 into development 2026-04-29 11:20:51 +00:00
zaelgohary deleted branch development_fix_double_slash_rpc 2026-04-29 11:20:51 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
prio_critical

   
prio_low

   
type_bug

   
type_contact

   
type_issue

   
type_lead

   
type_question

   
type_story

   
type_task
No labels
prio_critical
prio_low
type_bug
type_contact
type_issue
type_lead
type_question
type_story
type_task
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
zaelgohary
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
lhumina_code/hero_books!112
No description provided.