lhumina_code/hero_books
19
0
Fork 0
Code Issues Pull requests Projects Releases 1 Packages Wiki Activity Actions

fix: build repair + MDX support + fmt + CI repair #73

Closed
mik-tf wants to merge 0 commits from development_combined_fixes into development
pull from: development_combined_fixes
merge into: lhumina_code:development
Conversation 0 Commits - Files changed -
mik-tf commented 2026-03-01 15:06:06 +00:00
Owner
Copy link

Summary

Combined fixes for hero_books. Includes all work from closed PRs #64 and #66 plus additional build repairs.

Commits

  1. Fix build — remove dead pub mod services, rename WIP dirs to proper module paths, non-fatal embedder health check, remove rust-toolchain.toml, disable broken client binary (Fixes #65, #69, #71, #72)
  2. MDX support — add content_type and content_raw fields to PageDetail for MDX rendering (Fixes #70)
  3. CI repair — build workspace binaries, remove missing ci-patch-deps.sh reference
  4. cargo fmt — format entire workspace

Fixes #65, #69, #70, #71
Related: #72
Supersedes: PR #64, PR #66

Test plan

  • cargo check passes (main binary)
  • cargo check --workspace passes
  • cargo fmt --check passes
  • Docker build succeeds with hero_books binary
  • hero_books starts in degraded mode without hero_embedder
## Summary Combined fixes for hero_books. Includes all work from closed PRs #64 and #66 plus additional build repairs. ### Commits 1. **Fix build** — remove dead `pub mod services`, rename WIP dirs to proper module paths, non-fatal embedder health check, remove `rust-toolchain.toml`, disable broken client binary (Fixes #65, #69, #71, #72) 2. **MDX support** — add `content_type` and `content_raw` fields to `PageDetail` for MDX rendering (Fixes #70) 3. **CI repair** — build workspace binaries, remove missing `ci-patch-deps.sh` reference 4. **cargo fmt** — format entire workspace Fixes #65, #69, #70, #71 Related: #72 Supersedes: PR #64, PR #66 ## Test plan - [x] `cargo check` passes (main binary) - [x] `cargo check --workspace` passes - [x] `cargo fmt --check` passes - [ ] Docker build succeeds with hero_books binary - [ ] hero_books starts in degraded mode without hero_embedder
fix: repair build — remove dead module, rename WIP dirs, non-fatal embedder, drop rust-toolchain.toml
Some checks failed
Test / test (pull_request) Failing after 2s
Details
Test / integration (pull_request) Has been skipped
Details
76dc6bfe61 
- Remove dead `pub mod services` from lib.rs (fixes compile error, #71)
- Rename WIP-named directories to proper module paths:
  - "admin_port usefal parts to herobooks ui" -> admin
  - "bin port to hero_books which is cli" -> (removed, client disabled)
  - "publishing_ probably to _server" -> publishing
- Add properly-named source modules (ai, book, books, doctree, embedder, vectorsdk, website)
- Make hero_embedder health check non-fatal — start in degraded mode (#65)
- Remove non-standard rust-toolchain.toml (#69)
- Disable broken hero_books_client binary target (#72)

Fixes #65, #69, #71, #72
The get_page RPC response now includes:
- content_type: "html" for regular markdown, "mdx" for MDX files
- content_raw: raw source content (only present for MDX files)

This enables the WASM frontend to detect MDX pages and render JSX
components client-side instead of relying on server-side HTML that
strips JSX.

Also regenerates schema docs, SDK types, and fixes fmt/clippy issues
from code generation.

Related: lhumina_code/hero_archipelagos#29

Co-Authored-By: mik-tf <mik@threefold.io>
build_lib.sh build() was missing --workspace flag, so only root package
binaries (hero_books, hero_books_client) were produced — hero_books_server
and hero_books_ui were skipped. test.yaml referenced scripts/ci-patch-deps.sh
which was removed along with .forgejo/deps.txt, causing immediate failure.

Co-Authored-By: mik-tf <perreault@incubaid.com>
style: cargo fmt across workspace + fix generated code formatting
Some checks failed
Test / test (pull_request) Failing after 2s
Details
Test / integration (pull_request) Has been skipped
Details
17a43b5e81
mik-tf changed title from WIP: fix build — dead module, WIP dir cleanup, non-fatal embedder, drop rust-toolchain.toml to WIP: fix build + MDX support + fmt + CI repair 2026-03-01 15:13:36 +00:00
style: fix remaining rustfmt issues in generated code
All checks were successful
Test / test (pull_request) Successful in 5m38s
Details
Test / integration (pull_request) Successful in 8m51s
Details
6cc53a9223
mik-tf changed title from WIP: fix build + MDX support + fmt + CI repair to fix: build repair + MDX support + fmt + CI repair 2026-03-01 15:50:34 +00:00
mik-tf closed this pull request 2026-03-03 18:53:34 +00:00
All checks were successful
Test / test (pull_request) Successful in 5m38s
Details
Test / integration (pull_request) Successful in 8m51s
Details

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
lhumina_code/hero_books!73
No description provided.