Remove non-standard rust-toolchain.toml — use Cargo.toml rust-version per hero_ecosystem convention #69

New issue

Closed

opened 2026-03-01 14:51:20 +00:00 by mik-tf · 1 comment

mik-tf commented

2026-03-01 14:51:20 +00:00

Owner

Problem

hero_books has a rust-toolchain.toml pinning to Rust 1.93 with a musl target. This is non-standard per the hero_ecosystem skill which specifies:

Rust 1.92+ with rust-version = "1.92" in Cargo.toml (single source of truth)
No rust-toolchain.toml prescribed

The Cargo.toml already correctly has edition = "2024" and rust-version = "1.92", so the toolchain file is redundant.

This likely causes the Docker build failure in hero_services — the rust:bookworm builder image may not be able to auto-install 1.93 during build-services.sh, causing hero_books to be the only service that fails to compile.

Fix

Delete rust-toolchain.toml. The Cargo.toml rust-version field is sufficient.

## Problem hero_books has a `rust-toolchain.toml` pinning to Rust 1.93 with a musl target. This is non-standard per the `hero_ecosystem` skill which specifies: - Rust 1.92+ with `rust-version = "1.92"` in Cargo.toml (single source of truth) - No `rust-toolchain.toml` prescribed The `Cargo.toml` already correctly has `edition = "2024"` and `rust-version = "1.92"`, so the toolchain file is redundant. This likely causes the Docker build failure in hero_services — the `rust:bookworm` builder image may not be able to auto-install 1.93 during `build-services.sh`, causing hero_books to be the only service that fails to compile. ## Fix Delete `rust-toolchain.toml`. The `Cargo.toml` `rust-version` field is sufficient.