lhumina_code/hero_biz

Fork 0

bug: deal_sid and function_title fields silently lost on every save round-trip #44

New issue

Closed

opened 2026-05-07 08:29:43 +00:00 by casper-stevens · 5 comments

casper-stevens commented

2026-05-07 08:29:43 +00:00

Member

Summary

Two fields added to their respective models are not mapped when constructing the OSIS structs for save, so they are silently dropped on every write:

`Task.deal_sid`

deal_sid was added to TaskRecord in commit 764d90d, but services/mod.rs initializes deal_sid: None when loading and the h0_task construction on save does not include a deal_sid mapping. Every call to save_task permanently erases the deal_sid value.

`Person.function_title`

Similarly, function_title: Option<String> was added to PersonRecord but is always initialized to None on load and is not included in the h0_person construction on save.

Impact

Any task with a linked deal will have that link silently cleared on the next save. This is a data-loss bug that is not visible to the user.

Fix

Map both fields in the OSIS struct construction in services/mod.rs:

// In save_task:
h0_task.deal_sid = task.deal_sid.clone();

// In save_person (or the h0_person builder):
h0_person.function_title = person.function_title.clone();

And ensure both are read back when loading from OSIS.

Affected code

crates/hero_biz_ui/src/services/mod.rs — save_task, save_person, and their OSIS load paths

Found in

PR #21 review

## Summary Two fields added to their respective models are not mapped when constructing the OSIS structs for save, so they are silently dropped on every write: ### `Task.deal_sid` `deal_sid` was added to `TaskRecord` in commit `764d90d`, but `services/mod.rs` initializes `deal_sid: None` when loading and the `h0_task` construction on save does not include a `deal_sid` mapping. Every call to `save_task` permanently erases the `deal_sid` value. ### `Person.function_title` Similarly, `function_title: Option<String>` was added to `PersonRecord` but is always initialized to `None` on load and is not included in the `h0_person` construction on save. ## Impact Any task with a linked deal will have that link silently cleared on the next save. This is a data-loss bug that is not visible to the user. ## Fix Map both fields in the OSIS struct construction in `services/mod.rs`: ```rust // In save_task: h0_task.deal_sid = task.deal_sid.clone(); // In save_person (or the h0_person builder): h0_person.function_title = person.function_title.clone(); ``` And ensure both are read back when loading from OSIS. ## Affected code - `crates/hero_biz_ui/src/services/mod.rs` — `save_task`, `save_person`, and their OSIS load paths ## Found in PR #21 review

casper-stevens commented

2026-05-07 10:38:46 +00:00

Author

Member

Implementation Spec for Issue #44

Objective

Fix two data-loss bugs in crates/hero_biz_ui/src/services/mod.rs where Task.deal_sid and Person.function_title are silently discarded on every save round-trip because they are not mapped to or from the OSIS backend structs.

Root Cause

Neither deal_sid on hero_osis_sdk::projects::Task nor function_title on hero_osis_sdk::business::Person exist as OSIS schema fields — the storage layer has no column for them. Both fields are application-level extensions that require a storage strategy.

The existing codebase already solves this for HR fields (job_title:, department:, start_date:, salary:) using a prefixed-tag convention on Person.tags. This same pattern must be applied to both fields.

Requirements

deal_sid must survive a full save_task + load_task round-trip.
function_title must survive a full save_person + load_person round-trip.
Storage uses the existing tags prefixed-key pattern: "deal_sid:<value>" and "function_title:<value>".
Tags round-trips must be correct: non-managed tags are preserved; the managed key is removed when the field is None or empty.
The internal tag must be stripped from the user-visible tags field on load.
No OSIS schema or SDK changes required.
All changes confined to services/mod.rs.

Files to Modify

crates/hero_biz_ui/src/services/mod.rs — load_task, save_task, load_person, save_person

Implementation Plan

Step 1 — Fix `save_task`: encode `deal_sid` into tags

In save_task, replace tags: task.tags.clone() with:

tags: {
    let mut t: Vec<String> = task.tags.iter()
        .filter(|s| !s.starts_with("deal_sid:"))
        .cloned()
        .collect();
    if let Some(ref d) = task.deal_sid {
        let d = d.trim();
        if !d.is_empty() {
            t.push(format!("deal_sid:{}", d));
        }
    }
    t
},

Step 2 — Fix `load_task`: decode `deal_sid` from tags

In load_task, replace deal_sid: None with:

deal_sid: h0.tags.iter()
    .find(|s| s.starts_with("deal_sid:"))
    .map(|s| s["deal_sid:".len()..].to_string()),

And strip the internal tag from the user-visible tags field:

tags: h0.tags.iter()
    .filter(|s| !s.starts_with("deal_sid:"))
    .cloned()
    .collect(),

Step 3 — Fix `save_person`: encode `function_title` into tags

In save_person, replace tags: person.tags.clone() with:

tags: {
    let mut t: Vec<String> = person.tags.iter()
        .filter(|s| !s.starts_with("function_title:"))
        .cloned()
        .collect();
    if let Some(ref ft) = person.function_title {
        let ft = ft.trim();
        if !ft.is_empty() {
            t.push(format!("function_title:{}", ft));
        }
    }
    t
},

Step 4 — Fix `load_person`: decode `function_title` from tags

In load_person, replace function_title: None with:

function_title: h0_person.tags.iter()
    .find(|s| s.starts_with("function_title:"))
    .map(|s| s["function_title:".len()..].to_string()),

And strip the internal tag from the user-visible tags field:

tags: h0_person.tags.iter()
    .filter(|s| !s.starts_with("function_title:"))
    .cloned()
    .collect(),

Acceptance Criteria

save_task with deal_sid: Some("abc123") followed by load_task returns deal_sid == Some("abc123")
save_task with deal_sid: None leaves no deal_sid: entry in tags
load_task never returns deal_sid:... in the user-visible tags list
save_person with function_title: Some("Investor") followed by load_person returns function_title == Some("Investor")
save_person with function_title: None leaves no function_title: entry in tags
load_person never returns function_title:... in the user-visible tags list
cargo build succeeds with no new warnings or errors

Notes

The prefixed-tag pattern is already established: hr_create/hr_update encode job_title:, department:, start_date:, and salary: as prefixed tags on Person. This fix is idiomatic.
Existing data saved before this fix will have both fields as None on load. The values were already lost on the previous save (the reported bug). This fix prevents future data loss; it does not recover already-lost data.
The task_create and task_update handlers currently set deal_sid: None. Adding UI support for linking tasks to deals is out of scope and would require separate handler changes.

## Implementation Spec for Issue #44 ### Objective Fix two data-loss bugs in `crates/hero_biz_ui/src/services/mod.rs` where `Task.deal_sid` and `Person.function_title` are silently discarded on every save round-trip because they are not mapped to or from the OSIS backend structs. ### Root Cause Neither `deal_sid` on `hero_osis_sdk::projects::Task` nor `function_title` on `hero_osis_sdk::business::Person` exist as OSIS schema fields — the storage layer has no column for them. Both fields are application-level extensions that require a storage strategy. The existing codebase already solves this for HR fields (`job_title:`, `department:`, `start_date:`, `salary:`) using a prefixed-tag convention on `Person.tags`. This same pattern must be applied to both fields. ### Requirements - `deal_sid` must survive a full `save_task` + `load_task` round-trip. - `function_title` must survive a full `save_person` + `load_person` round-trip. - Storage uses the existing `tags` prefixed-key pattern: `"deal_sid:<value>"` and `"function_title:<value>"`. - Tags round-trips must be correct: non-managed tags are preserved; the managed key is removed when the field is `None` or empty. - The internal tag must be stripped from the user-visible `tags` field on load. - No OSIS schema or SDK changes required. - All changes confined to `services/mod.rs`. ### Files to Modify - `crates/hero_biz_ui/src/services/mod.rs` — `load_task`, `save_task`, `load_person`, `save_person` ### Implementation Plan #### Step 1 — Fix `save_task`: encode `deal_sid` into tags In `save_task`, replace `tags: task.tags.clone()` with: ```rust tags: { let mut t: Vec<String> = task.tags.iter() .filter(|s| !s.starts_with("deal_sid:")) .cloned() .collect(); if let Some(ref d) = task.deal_sid { let d = d.trim(); if !d.is_empty() { t.push(format!("deal_sid:{}", d)); } } t }, ``` #### Step 2 — Fix `load_task`: decode `deal_sid` from tags In `load_task`, replace `deal_sid: None` with: ```rust deal_sid: h0.tags.iter() .find(|s| s.starts_with("deal_sid:")) .map(|s| s["deal_sid:".len()..].to_string()), ``` And strip the internal tag from the user-visible `tags` field: ```rust tags: h0.tags.iter() .filter(|s| !s.starts_with("deal_sid:")) .cloned() .collect(), ``` #### Step 3 — Fix `save_person`: encode `function_title` into tags In `save_person`, replace `tags: person.tags.clone()` with: ```rust tags: { let mut t: Vec<String> = person.tags.iter() .filter(|s| !s.starts_with("function_title:")) .cloned() .collect(); if let Some(ref ft) = person.function_title { let ft = ft.trim(); if !ft.is_empty() { t.push(format!("function_title:{}", ft)); } } t }, ``` #### Step 4 — Fix `load_person`: decode `function_title` from tags In `load_person`, replace `function_title: None` with: ```rust function_title: h0_person.tags.iter() .find(|s| s.starts_with("function_title:")) .map(|s| s["function_title:".len()..].to_string()), ``` And strip the internal tag from the user-visible `tags` field: ```rust tags: h0_person.tags.iter() .filter(|s| !s.starts_with("function_title:")) .cloned() .collect(), ``` ### Acceptance Criteria - [ ] `save_task` with `deal_sid: Some("abc123")` followed by `load_task` returns `deal_sid == Some("abc123")` - [ ] `save_task` with `deal_sid: None` leaves no `deal_sid:` entry in tags - [ ] `load_task` never returns `deal_sid:...` in the user-visible `tags` list - [ ] `save_person` with `function_title: Some("Investor")` followed by `load_person` returns `function_title == Some("Investor")` - [ ] `save_person` with `function_title: None` leaves no `function_title:` entry in tags - [ ] `load_person` never returns `function_title:...` in the user-visible `tags` list - [ ] `cargo build` succeeds with no new warnings or errors ### Notes - The prefixed-tag pattern is already established: `hr_create`/`hr_update` encode `job_title:`, `department:`, `start_date:`, and `salary:` as prefixed tags on `Person`. This fix is idiomatic. - Existing data saved before this fix will have both fields as `None` on load. The values were already lost on the previous save (the reported bug). This fix prevents future data loss; it does not recover already-lost data. - The `task_create` and `task_update` handlers currently set `deal_sid: None`. Adding UI support for linking tasks to deals is out of scope and would require separate handler changes.

casper-stevens commented

2026-05-07 10:59:14 +00:00

Author

Member

Test Results

Passed: 0
Failed: 0
Ignored: 0

Status: Build failed — no tests were executed.

Compilation Errors

The build failed with 244 compiler errors across the hero_biz_ui and hero_biz_app crates. No test binaries were produced, so no tests ran.

The errors fall into two categories:

1. Axum version conflict (E0277 — 208 errors)

There are two incompatible versions of axum in the dependency graph: axum 0.7.9 and axum 0.8.9. Handlers use CookieJar and axum-extra from one version while the router expects traits from the other. Every handler registration fails with:

the trait bound `CookieJar: IntoResponseParts` is not satisfied
the trait bound `fn(State<...>, CookieJar, ...) -> ...: Handler<_, _>` is not satisfied

Affected handlers include: login_submit, logout, index, index_redirect, persons_list, person_new, person_create, persons_detail, person_edit, person_update, person_link_delete, companies_list, company_new, company_create, companies_detail, company_edit, company_update, and many more.

2. Missing function init_logger (E0425 — 1 error)

cannot find function `init_logger` in module `crate::logging`
  --> crates/hero_biz_ui/src/web/server.rs:101:21

The function init_logger is referenced in server.rs but is not defined in the logging module.

3. Mismatched types (E0308 — 1 error)

Related to the axum version mismatch.

Root Cause

The primary issue is that hero_biz_ui imports axum-extra 0.9.6 (which pairs with axum 0.8.x) while another dependency pulls in axum 0.7.9. The CookieJar extractor and IntoResponseParts trait are incompatible between these versions. Pinning all axum-family crates to a single version (either all 0.7.x or all 0.8.x) should resolve the bulk of errors.

## Test Results - Passed: 0 - Failed: 0 - Ignored: 0 **Status: Build failed — no tests were executed.** ### Compilation Errors The build failed with 244 compiler errors across the `hero_biz_ui` and `hero_biz_app` crates. No test binaries were produced, so no tests ran. The errors fall into two categories: **1. Axum version conflict (`E0277` — 208 errors)** There are two incompatible versions of `axum` in the dependency graph: `axum 0.7.9` and `axum 0.8.9`. Handlers use `CookieJar` and `axum-extra` from one version while the router expects traits from the other. Every handler registration fails with: ``` the trait bound `CookieJar: IntoResponseParts` is not satisfied the trait bound `fn(State<...>, CookieJar, ...) -> ...: Handler<_, _>` is not satisfied ``` Affected handlers include: `login_submit`, `logout`, `index`, `index_redirect`, `persons_list`, `person_new`, `person_create`, `persons_detail`, `person_edit`, `person_update`, `person_link_delete`, `companies_list`, `company_new`, `company_create`, `companies_detail`, `company_edit`, `company_update`, and many more. **2. Missing function `init_logger` (`E0425` — 1 error)** ``` cannot find function `init_logger` in module `crate::logging` --> crates/hero_biz_ui/src/web/server.rs:101:21 ``` The function `init_logger` is referenced in `server.rs` but is not defined in the `logging` module. **3. Mismatched types (`E0308` — 1 error)** Related to the axum version mismatch. ### Root Cause The primary issue is that `hero_biz_ui` imports `axum-extra 0.9.6` (which pairs with `axum 0.8.x`) while another dependency pulls in `axum 0.7.9`. The `CookieJar` extractor and `IntoResponseParts` trait are incompatible between these versions. Pinning all axum-family crates to a single version (either all 0.7.x or all 0.8.x) should resolve the bulk of errors.

casper-stevens commented

2026-05-07 11:19:05 +00:00

Author

Member

Test Results

Passed: 7
Failed: 0
Ignored: 1 (doc-test stub)

Build: clean (cargo build succeeded with 0 errors, 0 warnings).

All 7 existing tests in hero_biz_ui::services::tests continue to pass.

## Test Results - Passed: 7 - Failed: 0 - Ignored: 1 (doc-test stub) Build: clean (`cargo build` succeeded with 0 errors, 0 warnings). All 7 existing tests in `hero_biz_ui::services::tests` continue to pass.

casper-stevens commented

2026-05-07 11:19:26 +00:00

Author

Member

Implementation Summary

Changes Made

crates/hero_biz_ui/src/services/mod.rs — issue #44 fix

save_task: encodes deal_sid as a prefixed tag (deal_sid:<value>) before writing to OSIS, filtering out any stale copy first.
load_task: decodes deal_sid from the tag prefix on load; strips the internal tag from the user-visible tags field.
save_person: encodes function_title as a prefixed tag (function_title:<value>) before writing to OSIS.
load_person: decodes function_title from the tag prefix on load; strips the internal tag from the user-visible tags field.

Storage strategy: neither field exists in the OSIS schema. The fix uses the existing prefixed-tag convention already in place for HR fields (job_title:, department:, start_date:, salary:).

crates/hero_biz_ui/Cargo.toml — dependency fix

Reverted axum from 0.8 to 0.7 to resolve a version conflict with axum-extra 0.9 (which pairs with axum 0.7). The axum 0.8 bump in commit a1c9bb3 was not accompanied by the necessary axum-extra and askama_axum upgrades, which broke the build with 120+ handler trait errors. A dedicated axum 0.8 upgrade (requiring axum-extra 0.12+ and an askama integration migration) is left for a separate issue.

crates/hero_biz_ui/src/logging.rs and crates/hero_biz/src/main.rs — build fix

Removed redundant Arc::new(logger) wrapping in both files. Logger::new() already returns Arc<Logger>; the extra wrap produced Arc<Arc<Logger>> which failed to compile.

crates/hero_biz_ui/src/web/server.rs — build fix

Updated call from crate::logging::init_logger(...) (non-existent) to crate::logging::init_hero_log("biz.admin") (the actual function name after the logging rewrite in a1c9bb3).

Audit

A full audit of all save_* and load_* functions in services/mod.rs found no other fields silently dropped on round-trip. The only structurally similar case (contact.user_sid: None in load_contact) is intentional — it is populated from link relationships at the handler layer immediately after loading.

Test Results

7 passed, 0 failed — all existing tests continue to pass.
cargo build: clean, no errors or warnings.

## Implementation Summary ### Changes Made **`crates/hero_biz_ui/src/services/mod.rs`** — issue #44 fix - `save_task`: encodes `deal_sid` as a prefixed tag (`deal_sid:<value>`) before writing to OSIS, filtering out any stale copy first. - `load_task`: decodes `deal_sid` from the tag prefix on load; strips the internal tag from the user-visible `tags` field. - `save_person`: encodes `function_title` as a prefixed tag (`function_title:<value>`) before writing to OSIS. - `load_person`: decodes `function_title` from the tag prefix on load; strips the internal tag from the user-visible `tags` field. Storage strategy: neither field exists in the OSIS schema. The fix uses the existing prefixed-tag convention already in place for HR fields (`job_title:`, `department:`, `start_date:`, `salary:`). **`crates/hero_biz_ui/Cargo.toml`** — dependency fix - Reverted `axum` from `0.8` to `0.7` to resolve a version conflict with `axum-extra 0.9` (which pairs with axum 0.7). The axum 0.8 bump in commit `a1c9bb3` was not accompanied by the necessary `axum-extra` and `askama_axum` upgrades, which broke the build with 120+ handler trait errors. A dedicated axum 0.8 upgrade (requiring `axum-extra 0.12+` and an askama integration migration) is left for a separate issue. **`crates/hero_biz_ui/src/logging.rs`** and **`crates/hero_biz/src/main.rs`** — build fix - Removed redundant `Arc::new(logger)` wrapping in both files. `Logger::new()` already returns `Arc<Logger>`; the extra wrap produced `Arc<Arc<Logger>>` which failed to compile. **`crates/hero_biz_ui/src/web/server.rs`** — build fix - Updated call from `crate::logging::init_logger(...)` (non-existent) to `crate::logging::init_hero_log("biz.admin")` (the actual function name after the logging rewrite in `a1c9bb3`). ### Audit A full audit of all `save_*` and `load_*` functions in `services/mod.rs` found no other fields silently dropped on round-trip. The only structurally similar case (`contact.user_sid: None` in `load_contact`) is intentional — it is populated from link relationships at the handler layer immediately after loading. ### Test Results - 7 passed, 0 failed — all existing tests continue to pass. - `cargo build`: clean, no errors or warnings.

casper-stevens referenced this issue from a commit

2026-05-07 11:59:09 +00:00

fix(build): resolve three compilation failures from a1c9bb3 logging rewrite

casper-stevens commented

2026-05-07 12:28:09 +00:00

Author

Member

Fixed in commit 6387be8 on branch development_casper.

Both function_title (Person) and deal_sid (Task) are now round-tripped via tagged fields in the OSIS persistence layer, following the existing tag-encoding pattern already in use for other HR extension fields. Data is no longer silently dropped on save.

Fixed in commit `6387be8` on branch `development_casper`. Both `function_title` (Person) and `deal_sid` (Task) are now round-tripped via tagged fields in the OSIS persistence layer, following the existing tag-encoding pattern already in use for other HR extension fields. Data is no longer silently dropped on save.

casper-stevens closed this issue

2026-05-07 12:28:09 +00:00

No labels

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

lhumina_code/hero_biz#44

No description provided.

Rows
Columns

bug: deal_sid and function_title fields silently lost on every save round-trip #44

Summary

Task.deal_sid

Person.function_title

Impact

Fix

Affected code

Found in

Implementation Spec for Issue #44

Objective

Root Cause

Requirements

Files to Modify

Implementation Plan

Step 1 — Fix save_task: encode deal_sid into tags

Step 2 — Fix load_task: decode deal_sid from tags

Step 3 — Fix save_person: encode function_title into tags

Step 4 — Fix load_person: decode function_title from tags

Acceptance Criteria

Notes

Test Results

Compilation Errors

Root Cause

Test Results

Implementation Summary

Changes Made

Audit

Test Results

`Task.deal_sid`

`Person.function_title`

Step 1 — Fix `save_task`: encode `deal_sid` into tags

Step 2 — Fix `load_task`: decode `deal_sid` from tags

Step 3 — Fix `save_person`: encode `function_title` into tags

Step 4 — Fix `load_person`: decode `function_title` from tags