fix(room): replace NewRoom and RoomDetail TODO redirects with placeholders #201

Merged
zaelgohary merged 2 commits from development_fix_room_todo_stubs_show_placeholder into development 2026-05-03 16:19:33 +00:00
Member

Summary

RoomView::NewRoom and RoomView::RoomDetail were rendering RoomsListView {} with a TODO comment, which silently redirected users back to the list when they tried to create a new room or view a room detail. This replaces the silent redirect with an honest "Not yet implemented" placeholder + a Back button — preserving the entry points so a future implementer can swap in the real components without touching the routing.

Closes #199

Changes

  • replaced TODO redirect with placeholder UI for NewRoom and RoomDetail
  • both placeholders use the existing handle_view_change to return to the active rooms list
  • RoomDetail surfaces the room_sid that was selected (was previously dropped via room_sid: _)
## Summary RoomView::NewRoom and RoomView::RoomDetail were rendering `RoomsListView {}` with a TODO comment, which silently redirected users back to the list when they tried to create a new room or view a room detail. This replaces the silent redirect with an honest "Not yet implemented" placeholder + a Back button — preserving the entry points so a future implementer can swap in the real components without touching the routing. ## Related Issue Closes https://forge.ourworld.tf/lhumina_code/hero_archipelagos/issues/199 ## Changes - replaced TODO redirect with placeholder UI for NewRoom and RoomDetail - both placeholders use the existing `handle_view_change` to return to the active rooms list - RoomDetail surfaces the room_sid that was selected (was previously dropped via `room_sid: _`)
fix(room): replace NewRoom and RoomDetail TODO redirects with honest placeholders
Some checks failed
Build and Test / build (pull_request) Has been cancelled
4257fee1b6
style: use Bootstrap classes instead of inline CSS
All checks were successful
Build and Test / build (pull_request) Successful in 6m49s
b39e27d6c3
zaelgohary merged commit c8769c10ff into development 2026-05-03 16:19:33 +00:00
zaelgohary deleted branch development_fix_room_todo_stubs_show_placeholder 2026-05-03 16:19:33 +00:00
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
lhumina_code/hero_archipelagos!201
No description provided.