lhumina_code/hero_archipelagos
1
0
Fork 0
Code Issues 50 Pull requests Projects Releases Packages Wiki Activity Actions

fix(books): drop trailing slash from base_url so /rpc doesn't become //rpc #196

Merged
zaelgohary merged 1 commit from development_fix_books_double_slash into development 2026-04-30 11:32:44 +00:00
Conversation 0 Commits 1 Files changed 1 +1 -1
zaelgohary commented 2026-04-30 10:43:14 +00:00
Member
Copy link

Summary

Books island POSTs to /hero_books/ui//rpc (double slash → 404). base_url was built with a trailing slash, then services::rpc_call appends /rpc → //rpc.

Related Issue

N/A — caught via QA audit.

Changes

  • Drop the trailing slash from base_url in BooksApp.

Test Results

cargo check, fmt, test all pass.

## Summary Books island POSTs to `/hero_books/ui//rpc` (double slash → 404). `base_url` was built with a trailing slash, then `services::rpc_call` appends `/rpc` → `//rpc`. ## Related Issue N/A — caught via QA audit. ## Changes - Drop the trailing slash from `base_url` in BooksApp. ## Test Results cargo check, fmt, test all pass.
fix(books): drop trailing slash from base_url so /rpc doesn't become //rpc
All checks were successful
Build and Test / build (pull_request) Successful in 6m15s
Details
d4c169087e
zaelgohary merged commit 5e13d7a3a0 into development 2026-04-30 11:32:44 +00:00
zaelgohary deleted branch development_fix_books_double_slash 2026-04-30 11:32:44 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
prio_critical

   
prio_low

   
type_bug

   
type_contact

   
type_issue

   
type_lead

   
type_question

   
type_story

   
type_task
No labels
prio_critical
prio_low
type_bug
type_contact
type_issue
type_lead
type_question
type_story
type_task
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
zaelgohary
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
lhumina_code/hero_archipelagos!196
No description provided.