lhumina_code/hero_aibroker
25
0
Fork 0
Code Issues 5 Pull requests 1 Projects Releases Packages Wiki Activity Actions

Rename _openrpc → _server, _http → _ui, _client → _sdk crates #22

New issue
Open
opened 2026-03-10 09:40:19 +00:00 by timur · 1 comment
timur commented 2026-03-10 09:40:19 +00:00
Owner
Copy link

Problem

The crate naming doesn't follow the Hero service naming convention (/hero_crates_best_practices_check).

Current state

Current crate Convention says
hero_aibroker_openrpc hero_aibroker_server
hero_aibroker_http hero_aibroker_ui
hero_aibroker_client hero_aibroker_sdk
hero_aibroker_rhai delete (Rhai bindings handled externally)
(missing) hero_aibroker_examples

What to do

  1. Rename crates/hero_aibroker_openrpc/ → crates/hero_aibroker_server/
    • Update Cargo.toml package name, [[bin]] name, all internal references
    • Update socket file from hero_aibroker_openrpc.sock → hero_aibroker_server.sock
  2. Rename crates/hero_aibroker_http/ → crates/hero_aibroker_ui/
    • Update package name, binary name, socket name
  3. Rename crates/hero_aibroker_client/ → crates/hero_aibroker_sdk/
    • Update package name, all dependents
  4. Remove crates/hero_aibroker_rhai/ from workspace
  5. Create crates/hero_aibroker_examples/ with health + basic_usage examples
  6. Update workspace Cargo.toml members list
  7. Update Makefile references

Reference

## Problem The crate naming doesn't follow the Hero service naming convention (`/hero_crates_best_practices_check`). ## Current state | Current crate | Convention says | |---------------|----------------| | `hero_aibroker_openrpc` | `hero_aibroker_server` | | `hero_aibroker_http` | `hero_aibroker_ui` | | `hero_aibroker_client` | `hero_aibroker_sdk` | | `hero_aibroker_rhai` | **delete** (Rhai bindings handled externally) | | (missing) | `hero_aibroker_examples` | ## What to do 1. Rename `crates/hero_aibroker_openrpc/` → `crates/hero_aibroker_server/` - Update `Cargo.toml` package name, `[[bin]]` name, all internal references - Update socket file from `hero_aibroker_openrpc.sock` → `hero_aibroker_server.sock` 2. Rename `crates/hero_aibroker_http/` → `crates/hero_aibroker_ui/` - Update package name, binary name, socket name 3. Rename `crates/hero_aibroker_client/` → `crates/hero_aibroker_sdk/` - Update package name, all dependents 4. Remove `crates/hero_aibroker_rhai/` from workspace 5. Create `crates/hero_aibroker_examples/` with health + basic_usage examples 6. Update workspace `Cargo.toml` members list 7. Update Makefile references ## Reference - Convention: https://forge.ourworld.tf/lhumina_code/home/issues/6 - Skill: `/hero_crates_best_practices_check`
timur commented 2026-03-10 09:40:52 +00:00
Author
Owner
Copy link

The zinit lifecycle and serve rename convention have been applied to the current hero_aibroker_openrpc crate in commits 0c273a0 and 415ac19 on development_timur (PR #21).

This issue tracks the next step: renaming the crates themselves to match the naming convention.

Once PR #21 is merged, the rename can be done on top of it.

The zinit lifecycle and serve rename convention have been applied to the current `hero_aibroker_openrpc` crate in commits `0c273a0` and `415ac19` on `development_timur` (PR #21). This issue tracks the **next step**: renaming the crates themselves to match the naming convention. Once PR #21 is merged, the rename can be done on top of it.
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
development
development_timur
development_mik
development_theme_sync
main
No results found.
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
lhumina_code/hero_aibroker#22
No description provided.