Improving Error Handling #20

rawan · 2026-02-24T14:13:28Z

rawan commented

2026-02-24 14:13:28 +00:00

related issues:
#17

for more info:
https://gist.github.com/xmonader/aff3afb23e100b29bb2ffb3455421981#51-excessive-use-of-unwrap-and-expect

https://gist.github.com/xmonader/aff3afb23e100b29bb2ffb3455421981#52-silent-error-suppression

related issues: https://forge.ourworld.tf/geomind_code/my_hypervisor/issues/17 for more info: https://gist.github.com/xmonader/aff3afb23e100b29bb2ffb3455421981#51-excessive-use-of-unwrap-and-expect https://gist.github.com/xmonader/aff3afb23e100b29bb2ffb3455421981#52-silent-error-suppression

rawan added 2 commits

2026-02-24 14:13:28 +00:00

fix: fixed excessive use of unwrap()

Unit and Integration Test / test (push) Successful in 2m14s

Details

f0f32f9fc3

fix: silent errors

Unit and Integration Test / test (push) Successful in 2m12s

Details

90a6ca04fc

salmaelsoly requested changes

2026-02-25 10:05:47 +00:00

Dismissed

crates/chvm-init/src/rootfs.rs

					
				@ -48,0 +47,4 @@

				            eprintln!("[init] Warning: Failed to create {new_path}: {e}");

				            continue;

				        }

				        if let Err(e) = mount(

what if the error was the dir already exist? we will skip mount call for that as well, i think we need to try move mount if error too

https://doc.rust-lang.org/beta/std/fs/fn.create_dir_all.html#errors

create_dir_all doesn't return an error if the directory already exists. it justcreates the directory if it's missing.

https://doc.rust-lang.org/beta/std/fs/fn.create_dir_all.html#errors `create_dir_all` doesn't return an error if the directory already exists. it justcreates the directory if it's missing.

👍 1