my_hypervisor supports basic stats retrieval

despiegk commented

2026-03-18 05:00:44 +00:00

Owner

make cmd ... stats --json
or something like it

this shows

mem used
cpu used
network used

...

make cmd ... stats --json or something like it this shows - mem used - cpu used - network used ...

despiegk added this to the now milestone

2026-03-18 05:00:48 +00:00

rawan was assigned by thabeta

2026-03-18 13:10:22 +00:00

rawan commented

2026-03-18 14:20:44 +00:00

Member

Implementation Spec for Issue #39: `chvm stats` Command

Objective

Add a stats subcommand to chvm that displays real-time resource usage (CPU, memory, network I/O) for a running VM, with optional --json flag for machine-readable output. Data comes from the Cloud Hypervisor REST API endpoint GET /api/v1/vm.counters.

Requirements

Command accepts a VM identifier (ID, name, or ID prefix) with the same resolution logic as inspect, exec, etc.
VM must be in Running state; returns an error otherwise
Displays: Memory (configured), CPU (vCPU count + counters), Network (bytes rx/tx)
--json flag outputs machine-readable JSON with raw counters + VM metadata
Human-readable table output by default
Tab-completion works for the VM name/ID argument

Files to Modify/Create

File	Action	Description
`crates/chvm-lib/src/hypervisor/api.rs`	Modify	Add `vm_counters()` calling `GET /api/v1/vm.counters`
`crates/chvm-lib/src/vm/manager.rs`	Modify	Add `stats()` method (resolve VM, check Running, call counters API)
`crates/chvm-cli/src/cli.rs`	Modify	Add `Stats(StatsArgs)` variant + `StatsArgs` struct
`crates/chvm-cli/src/commands/stats.rs`	Create	Command handler: format & print stats
`crates/chvm-cli/src/commands/mod.rs`	Modify	Add `pub mod stats;`
`crates/chvm-cli/src/main.rs`	Modify	Add `Commands::Stats(args)` dispatch arm

Implementation Plan

Step 1: Add vm_counters API function in api.rs (no deps)
Step 2: Add stats() method to VmManager in manager.rs (depends: Step 1)
Step 3: Add StatsArgs + Stats variant in cli.rs (no deps)
Step 4: Create commands/stats.rs handler with human-readable + JSON output (depends: Steps 1-3)
Step 5: Wire into mod.rs + main.rs (depends: Steps 3-4)
Step 6: Add unit tests (depends: Steps 1-5)

Acceptance Criteria

chvm stats <vm> prints human-readable CPU, memory, and network stats
chvm stats <vm> --json prints machine-readable JSON
Error on non-running VM
VM resolution by name, full ID, short ID prefix
Tab-completion works
cargo build, cargo clippy -- -D warnings, cargo test, cargo fmt --check all pass

## Implementation Spec for Issue #39: `chvm stats` Command ### Objective Add a `stats` subcommand to chvm that displays real-time resource usage (CPU, memory, network I/O) for a running VM, with optional `--json` flag for machine-readable output. Data comes from the Cloud Hypervisor REST API endpoint `GET /api/v1/vm.counters`. ### Requirements - Command accepts a VM identifier (ID, name, or ID prefix) with the same resolution logic as `inspect`, `exec`, etc. - VM must be in `Running` state; returns an error otherwise - Displays: Memory (configured), CPU (vCPU count + counters), Network (bytes rx/tx) - `--json` flag outputs machine-readable JSON with raw counters + VM metadata - Human-readable table output by default - Tab-completion works for the VM name/ID argument ### Files to Modify/Create | File | Action | Description | |------|--------|-------------| | `crates/chvm-lib/src/hypervisor/api.rs` | Modify | Add `vm_counters()` calling `GET /api/v1/vm.counters` | | `crates/chvm-lib/src/vm/manager.rs` | Modify | Add `stats()` method (resolve VM, check Running, call counters API) | | `crates/chvm-cli/src/cli.rs` | Modify | Add `Stats(StatsArgs)` variant + `StatsArgs` struct | | `crates/chvm-cli/src/commands/stats.rs` | Create | Command handler: format & print stats | | `crates/chvm-cli/src/commands/mod.rs` | Modify | Add `pub mod stats;` | | `crates/chvm-cli/src/main.rs` | Modify | Add `Commands::Stats(args)` dispatch arm | ### Implementation Plan **Step 1**: Add `vm_counters` API function in `api.rs` (no deps) **Step 2**: Add `stats()` method to VmManager in `manager.rs` (depends: Step 1) **Step 3**: Add `StatsArgs` + `Stats` variant in `cli.rs` (no deps) **Step 4**: Create `commands/stats.rs` handler with human-readable + JSON output (depends: Steps 1-3) **Step 5**: Wire into `mod.rs` + `main.rs` (depends: Steps 3-4) **Step 6**: Add unit tests (depends: Steps 1-5) ### Acceptance Criteria - [ ] `chvm stats <vm>` prints human-readable CPU, memory, and network stats - [ ] `chvm stats <vm> --json` prints machine-readable JSON - [ ] Error on non-running VM - [ ] VM resolution by name, full ID, short ID prefix - [ ] Tab-completion works - [ ] `cargo build`, `cargo clippy -- -D warnings`, `cargo test`, `cargo fmt --check` all pass

rawan commented

2026-03-18 14:39:35 +00:00

Member

Test Results

All checks passed:

cargo build --workspace ✅
cargo clippy --workspace -- -D warnings ✅ (0 warnings)
cargo fmt --check ✅
cargo test --workspace ✅

Unit test summary:

chvm-cli: 7 passed
chvm-init: 3 passed
chvm-lib: 144 passed
Total: 154 passed, 0 failed

Integration tests require a running system with KVM and root access — to be run separately.

## Test Results **All checks passed:** - `cargo build --workspace` ✅ - `cargo clippy --workspace -- -D warnings` ✅ (0 warnings) - `cargo fmt --check` ✅ - `cargo test --workspace` ✅ **Unit test summary:** - chvm-cli: 7 passed - chvm-init: 3 passed - chvm-lib: 144 passed - **Total: 154 passed, 0 failed** Integration tests require a running system with KVM and root access — to be run separately.

rawan commented

2026-03-18 14:40:24 +00:00

Member

Implementation Summary

New Command: `chvm stats <container> [--json]`

Displays real-time resource usage stats for a running VM using Cloud Hypervisor's counters API.

Changes Made

Files modified:

crates/chvm-lib/src/hypervisor/api.rs — Added vm_counters() function calling GET /api/v1/vm.counters
crates/chvm-lib/src/vm/manager.rs — Added stats() method to VmManager (resolve VM, check Running state, fetch counters)
crates/chvm-cli/src/cli.rs — Added Stats(StatsArgs) variant with --json flag and tab-completion
crates/chvm-cli/src/commands/mod.rs — Registered stats module
crates/chvm-cli/src/main.rs — Added Stats dispatch arm

Files created:

crates/chvm-cli/src/commands/stats.rs — Command handler with human-readable and JSON output modes

Output Formats

Human-readable (default):

Container name + short ID
CPU: vCPU count
Memory: allocated MB
Network: RX/TX bytes per interface (human-readable sizes)
Block I/O: read/write bytes per device

JSON (--json):

VM metadata (id, name, vcpu, memory_mb) + raw counters from Cloud Hypervisor

All checks pass

cargo build ✅
cargo clippy -- -D warnings ✅
cargo fmt --check ✅
cargo test --workspace ✅ (154 tests, 0 failures)

## Implementation Summary ### New Command: `chvm stats <container> [--json]` Displays real-time resource usage stats for a running VM using Cloud Hypervisor's counters API. ### Changes Made **Files modified:** - `crates/chvm-lib/src/hypervisor/api.rs` — Added `vm_counters()` function calling `GET /api/v1/vm.counters` - `crates/chvm-lib/src/vm/manager.rs` — Added `stats()` method to VmManager (resolve VM, check Running state, fetch counters) - `crates/chvm-cli/src/cli.rs` — Added `Stats(StatsArgs)` variant with `--json` flag and tab-completion - `crates/chvm-cli/src/commands/mod.rs` — Registered `stats` module - `crates/chvm-cli/src/main.rs` — Added `Stats` dispatch arm **Files created:** - `crates/chvm-cli/src/commands/stats.rs` — Command handler with human-readable and JSON output modes ### Output Formats **Human-readable** (default): - Container name + short ID - CPU: vCPU count - Memory: allocated MB - Network: RX/TX bytes per interface (human-readable sizes) - Block I/O: read/write bytes per device **JSON** (`--json`): - VM metadata (id, name, vcpu, memory_mb) + raw counters from Cloud Hypervisor ### All checks pass - `cargo build` ✅ - `cargo clippy -- -D warnings` ✅ - `cargo fmt --check` ✅ - `cargo test --workspace` ✅ (154 tests, 0 failures)