Escape does not close the comment thread popover #34

New issue

Open

opened 2026-04-21 14:22:09 +00:00 by AhmedHanafy725 · 1 comment

AhmedHanafy725 commented

2026-04-21 14:22:09 +00:00

Member

Root cause: showCommentPopover in comments.js has no keydown handler. Only showInputPopover (the new-comment textarea) listens for Escape.

Fix: when the thread popover opens, attach a document-level keydown handler that calls hidePopover() on Escape; detach it in hidePopover so it doesn't leak.

Opening a comment thread by clicking its marker shows a popover with replies and Resolve / Delete actions. Pressing Escape should dismiss the popover but nothing happens — the user has to click the X button or click outside the whiteboard container. Root cause: `showCommentPopover` in `comments.js` has no keydown handler. Only `showInputPopover` (the new-comment textarea) listens for Escape. Fix: when the thread popover opens, attach a document-level keydown handler that calls `hidePopover()` on Escape; detach it in `hidePopover` so it doesn't leak.