Rubber-band selection doesn't include comment markers #33

New issue

Open

opened 2026-04-21 14:22:08 +00:00 by AhmedHanafy725 · 1 comment

AhmedHanafy725 commented

2026-04-21 14:22:08 +00:00

Member

Dragging a rubber-band selection over an area that contains comment markers selects every other object but skips the comments, so a group drag leaves comments behind.

Root cause: onMouseUp in tools.js iterates only layer.find('.object'), but comment markers have name: 'comment-marker' (they are not whiteboard objects).

Fix: after collecting .object intersections, also walk layer.find('.comment-marker') nodes and add the ones that intersect the rubber-band box to the transformer's selection.

Dragging a rubber-band selection over an area that contains comment markers selects every other object but skips the comments, so a group drag leaves comments behind. Root cause: `onMouseUp` in `tools.js` iterates only `layer.find('.object')`, but comment markers have `name: 'comment-marker'` (they are not whiteboard objects). Fix: after collecting `.object` intersections, also walk `layer.find('.comment-marker')` nodes and add the ones that intersect the rubber-band box to the transformer's selection.