ci: explicit refspecs in dev-or-main fetch

mik-tf commented

2026-05-04 23:16:10 +00:00

Owner

Follow-up to PR #140. The dev-or-main guard was structurally correct but assumed actions/checkout@v4-style remote tracking. Whiteboard's checkout is a manual git clone --depth 100 --branch which creates zero refs/remotes/* refs; a bare git fetch origin development main then writes to FETCH_HEAD only, so git branch -r --contains has nothing to match and the guard rejects every tag.

Symptom: v0.1.0-rc1 (tag commit a8059f7, HEAD of development at PR #140 merge) failed with: ERROR: Tag v0.1.0-rc1 is not on development or main. Aborting.

Fix: explicit refspecs on the fetch so origin/development and origin/main are materialized.

Verified locally by reproducing the workflow's clone+fetch sequence in /tmp; with the explicit refspecs git branch -r --contains correctly returns origin/development for the tag commit.

A simpler long-term alternative is to replace the manual git clone with uses: actions/checkout@v4 (matches hero_proxy / hero_aibroker exactly). Deferred to a separate PR — this surgical one-line fix unblocks the release pipeline today.

Signed-off-by: mik-tf

Follow-up to PR #140. The dev-or-main guard was structurally correct but assumed actions/checkout@v4-style remote tracking. Whiteboard's checkout is a manual git clone --depth 100 --branch <ref> which creates zero refs/remotes/* refs; a bare git fetch origin development main then writes to FETCH_HEAD only, so git branch -r --contains has nothing to match and the guard rejects every tag. **Symptom:** v0.1.0-rc1 (tag commit a8059f7, HEAD of development at PR #140 merge) failed with: ERROR: Tag v0.1.0-rc1 is not on development or main. Aborting. **Fix:** explicit refspecs on the fetch so origin/development and origin/main are materialized. **Verified locally** by reproducing the workflow's clone+fetch sequence in /tmp; with the explicit refspecs git branch -r --contains correctly returns origin/development for the tag commit. A simpler long-term alternative is to replace the manual git clone with uses: actions/checkout@v4 (matches hero_proxy / hero_aibroker exactly). Deferred to a separate PR — this surgical one-line fix unblocks the release pipeline today. Signed-off-by: mik-tf

mik-tf added 1 commit

2026-05-04 23:16:10 +00:00

ci: use explicit refspecs in dev-or-main fetch

CI / build (pull_request) Successful in 2m46s

Details

4628408927

PR #140's dev-or-main guard was structurally correct but assumed
actions/checkout@v4-style remote tracking. Whiteboard's checkout is
a manual `git clone --depth 100 --branch <ref>` (a holdover from
PR #126), which creates zero refs/remotes/* refs. A bare
`git fetch origin development main` then writes only to FETCH_HEAD
and never populates origin/development or origin/main, so
`git branch -r --contains "$TAG_COMMIT"` has no refs to match and
the guard rejects every tag.

Symptom: v0.1.0-rc1 was tagged from a8059f7 (HEAD of development at
PR #140 merge), the workflow ran, and the guard step printed:

  ERROR: Tag v0.1.0-rc1 is not on development or main. Aborting.

Fix is one line: pass explicit refspecs to git fetch so the
remote-tracking refs are materialized:

  git fetch origin \
    '+refs/heads/development:refs/remotes/origin/development' \
    '+refs/heads/main:refs/remotes/origin/main' || true

Verified locally by reproducing the workflow's clone+fetch sequence
in /tmp; with the explicit refspecs git branch -r --contains
correctly returns origin/development for the tag commit.

A simpler alternative is replacing the manual clone block with
uses: actions/checkout@v4, which is what hero_aibroker / hero_proxy
do. Deferred to a follow-up since this is a one-line surgical fix
that unblocks the release pipeline today; the broader checkout
canonicalization is worth a separate PR with its own review.

Signed-off-by: mik-tf

mik-tf added 1 commit

2026-05-04 23:19:02 +00:00

ci: strip verbose comment block from guard step

CI / build (pull_request) Has been cancelled

Details

e04b43f936